From nobody Wed Aug 26 11:33:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hVMwT6wgSz6pwpM for ; Wed, 26 Aug 2026 11:33:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hVMwT5T8Cz4FgY for ; Wed, 26 Aug 2026 11:33:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787744009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M9lcfRsdshSymJ1pFb/G5zmr9M96Kse5ow49Cg3nHBE=; b=s/YqgJiAjsIkfJxG8ldviX6W4VDXeLY/lsTsyLOk5ecpMuaFnOHGeXKpT7nhr6okp+36be vS68zpDKpjpN8HrML6+CA/xuY3bfCuVJixG0rH7YavZR3IRJJfM63Y77PYPYn7/nZ8+his GQ6XM21g6fFY5qHL9QlaO6U1GZp8gubcGm7U1XqGrxzgZtz9qlWbv5biwQl7RN6bFSh8tI PZeGVL4Io80NJ9HJdI/UiShQ4anTVlvyfgOK4a4cDQ2Jyd1JWnFexx0V9GGBrgUmL1Mscv HnhiBvz15CMSLbgbuIXTWMgMzQ8ER8V1xbsZY3R1h5JTdPZEiL+f9GmIuflsUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787744009; a=rsa-sha256; cv=none; b=mweYYgpR787eXpaPJ9ekd+KOc/qoH2BZ0rQGVfET4G/ZtkliBzY/NNMwxtaqqDGZwx2kkO PrFiyji1Vth47AT/vA2uIqNk5ciLoQe5IAIB0JQyAD+NhgDE0p/gkb730m/7qEZZFfDFkM zqtFZlfoOV+kMLydy3CWQHLRcSfQh8SNaCKrhMJLXQ62CMcE10cQK5tXNerYv6J/jLxHL6 TkDFl6QXWf9JhGLnrVb35cyGbagiZeHlRW5Hh/ULGyBlxv50smkOx0atpUOw3Es2MJ7tPe LqVmXSxHCeBI72LxSGzioJKqniqpTH8E7VQ6DcwEUUBz2rUk0wPY1ivQlscZGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787744009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M9lcfRsdshSymJ1pFb/G5zmr9M96Kse5ow49Cg3nHBE=; b=d8fIebvlRBMYZdEPD7UKB7pch/fysB5UG1RhYGqR/ddX8iaf1U0p5tqjl6iv0sWX+hU49F +40WC2zxtP2ryeITdiiXX9lfmYDdguVqkO1cdWHPN2QtIgB2CjqcTXX5aQpAnfFW3pX/9b 5cVbi6ty4Rrd5hwK0afsqNKWUd696VyjM8gpFcwIFQrcXZ5F6aHAtDR0ihbvk6oTmKdHCI 0VJ1DwQ0caqgtEL9nI5E4H8bUKa2uLpcOef13NlzyxDzuDCnGcZq3xiUTR7dmKjHo3NJ5X b+uBouWiMZi+8aYn98DpQboNHeZ1pxCu+s4AGTDWds59yAVPhOw0+uuxXHb2nw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hVMwT4VgRzcgF for ; Wed, 26 Aug 2026 11:33:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ffbe by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 11:33:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 57775b3be6be - main - arm64/smmu: Fix undefined behaviour in Q_OVF List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57775b3be6be253f3612f5b0a74dc9bf2b36d6d7 Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 11:33:29 +0000 Message-Id: <6a8ecf09.3ffbe.4c5d4357@gitrepo.freebsd.org> The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=57775b3be6be253f3612f5b0a74dc9bf2b36d6d7 commit 57775b3be6be253f3612f5b0a74dc9bf2b36d6d7 Author: Andrew Turner AuthorDate: 2026-07-28 14:04:50 +0000 Commit: Andrew Turner CommitDate: 2026-08-26 11:31:36 +0000 arm64/smmu: Fix undefined behaviour in Q_OVF "1 << 31" is a signed int left shift 31 which is undefined as the shift is too large. Use an unsigned int to make the value defined. Sponsored by: Arm Ltd --- sys/arm64/iommu/smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/iommu/smmu.c b/sys/arm64/iommu/smmu.c index 2d34b9177ed7..9a6f15e83def 100644 --- a/sys/arm64/iommu/smmu.c +++ b/sys/arm64/iommu/smmu.c @@ -142,7 +142,7 @@ #define Q_WRP(q, p) ((p) & (1 << (q)->size_log2)) #define Q_IDX(q, p) ((p) & ((1 << (q)->size_log2) - 1)) -#define Q_OVF(p) ((p) & (1 << 31)) /* Event queue overflowed */ +#define Q_OVF(p) ((p) & (1u << 31)) /* Event queue overflowed */ #define SMMU_Q_ALIGN (64 * 1024)