From nobody Wed Aug 26 10:12:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hVL7B0XNTz6pphR for ; Wed, 26 Aug 2026 10:12:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hVL794jB6z42JP for ; Wed, 26 Aug 2026 10:12:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787739157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+uki+VkDAveMLjSgrxB1Y/GtrZZSiZOeESW3sAoQfQo=; b=CAWD+1kug6k2hl+H/AkID0JacnmCMrUu2PdYpqk06plMvAKXwgLZr1B3I10a3Q3zeKNF+l 3183N3BklIbZUKG0sepaEvUevIZ3HfF6gmUh2PCZNOFBX0NxGAGctB6+ZOZhZ8y8ejsEkV vTe+R6YSbgVLYb1h5gHrlzqznwurxkVSSvc5qqrvxEEC92tp3auilIGvMc93qgUQy1q1lQ bx8l1RtbxxooNEl6M8AT4Nat08QWT6hAWzEFxlfgUc62kuDBds4A5ccHPkJBj7MdF8OMyI uFnPPxsQLO0bVtw3eHZZSqORIxlMTvc/LCOPgADgFKlqG8HHTYGO0Dl1bAvD8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787739157; a=rsa-sha256; cv=none; b=v0zOJU76l+4jhGcVS2of95pw3hamhEXU9t6zVuQJt1d+Hj0h9q7L6bJ0rmqKL4+5uNHlwi 2e/wKqDZ9Je6kA0/ml+uj26QsUDgbB543lXANlPWOxwYlfWOhcrH9K9NRaHDOVO070fP1S XG5oADUhkktS+KEgEpKidO+H4y+6NKhVB8wIficLz8EnFITaD8Yadt+j6cx3MnFG+jNkfs kX+wQJtnWTZcF1PVkSoDxASV16s4jWLf8D0OCPgenusczmMn7od2R6lKhZKS3d5vMtbceT 3Ne0rwPkaV0gBewn8aFKdOo98GpWykZyG9XzqC8UVzZ7/Y5mBVAJFigTZnzeuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787739157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+uki+VkDAveMLjSgrxB1Y/GtrZZSiZOeESW3sAoQfQo=; b=WpAF73SbqefgIo3PVMweTEQoAHzZqx5b0zdIzKkRJe+II1fE5la6a54yDKV2g+QebgWpbh kGp0K9dHr+TvQc2ZC5L7FPL++wsRWVhx3EAsvnnvyaYLJAvxEt476iKkNP11U5t6NbGixO d+euYKz5+9bYhMJK4k5QUmry85ADHrGOiNu/7YFf52OlxFRo4tb3e0u6+AECZWhR5HsE1r Y6HsRcQxbKxx1DtQ8OqR5uGLcd2oFjDB0zhZHExlgZQpqGrUaZFUW/IMDRdsscdZOtCTSx fUld+UPGOJK+vRs2L2p9HBIWnP7RFTcUjc8G8EQmANFd28AP6CExnJfrdatI9w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hVL793ncNzZGX for ; Wed, 26 Aug 2026 10:12:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38f8b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 10:12:37 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Lexi Winter Subject: git: 5b466d39237c - stable/15 - xinstall: Const correctness for C23 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 5b466d39237c711f1e2d65157970cc5f0637a55c Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 10:12:37 +0000 Message-Id: <6a8ebc15.38f8b.6e6c000b@gitrepo.freebsd.org> The branch stable/15 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=5b466d39237c711f1e2d65157970cc5f0637a55c commit 5b466d39237c711f1e2d65157970cc5f0637a55c Author: Lexi Winter AuthorDate: 2026-08-03 14:07:09 +0000 Commit: Lexi Winter CommitDate: 2026-08-26 09:56:12 +0000 xinstall: Const correctness for C23 On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr() now implements the C23 behaviour where passing a const pointer to strchr() also returns a const pointer. This breaks xinstall during the bootstrap build, since it assumes the return value is always a mutable pointer. As the returned pointer is never used to modify the value, fix this by making the temporary variable const. MFC after: 1 week Reviewed by: ray, markj, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58492 (cherry picked from commit 2296c39a9ebc4f081d90b6554d8839e8cde8490a) --- usr.bin/xinstall/xinstall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr.bin/xinstall/xinstall.c b/usr.bin/xinstall/xinstall.c index 7636da20153b..36af3528cae6 100644 --- a/usr.bin/xinstall/xinstall.c +++ b/usr.bin/xinstall/xinstall.c @@ -819,7 +819,8 @@ install(const char *from_name, const char *to_name, u_long fset, u_int flags) char backup[MAXPATHLEN], pathbuf[MAXPATHLEN], tempfile[MAXPATHLEN]; struct stat from_sb, temp_sb, to_sb; struct timespec tsb[2]; - char *digestresult, *p; + char *digestresult; + const char *p; int from_fd, temp_fd, to_fd, serrno; bool devnull, exists, files_match, ispipe, stripped;