From nobody Wed Aug 26 10:12:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hVL790fBCz6pq0C for ; Wed, 26 Aug 2026 10:12:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hVL784khYz42FR for ; Wed, 26 Aug 2026 10:12:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787739156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pxetjVW1zzVyFDrYrAUZVFlMFwzCuZvGu5CisR9MKQg=; b=XFQsOcBCuZYdcJF6EVkUXl/Xaf0QhLD0AGi5fDd1f6jDY12pJhe1L3pf/D0jLQdPC7QhsA fSF9qi/IMno4ABEUEcXSKdlJUsk29Hk9thR4LrsNyIA1ZVMOtk6e9uJTnHGLmmBohXsUZq jfXZTthbmS1GhTtGTwykAq1+np+SZUsiCU4+4ZsR8T8Fs1y3G6lPJDbgo+7nlSfBpVEUA4 q059ViSHLISfLNNYUIrBe6flTzNRbtA2ojR/GdB2GW/ii0Wkb+HhWSo/JWcisNQBlrXTVJ /J0i4qzOPSBMNXVecQbKpStM5nPdf3tGiMCu8GLXHSlLYWpFHusxXCmVQX3ETQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787739156; a=rsa-sha256; cv=none; b=LRFKRCz1fdqTcEko/cK3sI9VZrstU6oXmOMA2i7FVfXgl3bSWxsxzhD6ATJc7rJqU1g5ik Yr3TlkRgDTysKgbAEm5ldm474BMmilo80HffM5UMoHcFeQKAqLBBuNlZi8lWL7NPrhPumR 3CDYsM9ZumaSRsXYCwZ+LaOM9S5VGs8hQugNWm7spzbpJ55hChYX2DSV8WRnOtxO3DeLOQ klfqOLyBV3HnF0qbmPSxqqttnc9+reWbQRvdccIRClc6GI6arNgTQCadSz2d7vqnw2MDYU P6D02+FJUHHMtRd0wKOsqS6eCB0AQq/TdREBk6DbV7o0nx5KycHfr+6Cp/9KHg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787739156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pxetjVW1zzVyFDrYrAUZVFlMFwzCuZvGu5CisR9MKQg=; b=Ubpi2bquWz1LhaWcS6OISZw5czxw8PW7iCHl1YmXKDt9+Bqe7pXzfsybqyXbvYSTH3mXYf AOpjkEER/QMeFeV5296zmyF1+xkrTWwxPgx2i6+ek9XG6D1OMaoZMH9zWHDHV/XEuclcTO jH9+hdpy0asrGECfrIwnSD58gx1mxEl1YSB92a0jgTio+gK0OcoSkNmJmmmrpX4Bdbdd1I lALrqcoSZBD9niMS0Py+LrqXUDMw11hxCe4flPRuEeDBZd/qhSr4nkYjdv1e7qgsOmY+bB gyfNpJSAPdDKZx+o0V8z0pbJBm2hBlobPk7KskwLZQBxjHkISbnfBy6c+UtvPA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hVL783JtqzZCw for ; Wed, 26 Aug 2026 10:12:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3930c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 10:12:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Lexi Winter Subject: git: 876f29df3e2a - stable/15 - sort: Const correctness for C23 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 876f29df3e2ae25b7e9c225a12a1a7e293196a3e Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 10:12:36 +0000 Message-Id: <6a8ebc14.3930c.15e967f2@gitrepo.freebsd.org> The branch stable/15 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=876f29df3e2ae25b7e9c225a12a1a7e293196a3e commit 876f29df3e2ae25b7e9c225a12a1a7e293196a3e Author: Lexi Winter AuthorDate: 2026-08-03 14:06:18 +0000 Commit: Lexi Winter CommitDate: 2026-08-26 09:56:12 +0000 sort: Const correctness for C23 On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr() now implements the C23 behaviour where passing a const pointer to strchr() also returns a const pointer. This breaks sort during the bootstrap build, since it assumes the return value is always a mutable pointer. As the returned pointer is never used to modify the value, fix this by making the temporary variable const. MFC after: 1 week Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58491 (cherry picked from commit 78f842dda35b7280e8682f90506ff05b591c6b3a) --- usr.bin/sort/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/sort/sort.c b/usr.bin/sort/sort.c index 6e4023c43063..422884573ae9 100644 --- a/usr.bin/sort/sort.c +++ b/usr.bin/sort/sort.c @@ -735,7 +735,7 @@ parse_k(const char *s, struct key_specs *ks) { false, false, false, false, false, false }; if (s && *s) { - char *sptr; + const char *sptr; sptr = strchr(s, ','); if (sptr) {