From nobody Wed Aug 26 01:07:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hV61v1KZWz6qLpY for ; Wed, 26 Aug 2026 01:07:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hV61t0rDrz42L5 for ; Wed, 26 Aug 2026 01:07:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787706434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MDnHhhyRmeLgPCGdamQA+reUStXDLO3tNW0hXiZryXQ=; b=fIPAxNIVdk4/5o6VToD2+OYbSeLEFJvAV90KaIkMLeZpUGRYK979IfSUapPfvO6o/gQrTl vPZZNMHW/Hljdyacwc4TqWlHfsib+6Syqph5Vfegfxzgc4JddPMSQoIH4xx/mGWRsSYdbb Q9CnCzkpG/t/O3LFL/67DWvu7B/juG3uv2tIGl2v6wJgbZv9AKXXpW9HjVhdrZ1o4+RA4L wXiefImniHHYfM7F1MPfq2Rtcv85PhGBxH5lfS74wGpIQhwY+O9JE8DcYJ3a326LsEkt/k 3Rxf2YLKHO6oHcNNYeAKj+/a88zX5/wluxVzHZpcgQsBRSeP6+OOx7tgpxrjMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787706434; a=rsa-sha256; cv=none; b=sJBiqsEjNNLw1/j7e054uV/nDSL54uDboH1g9+hHpd7bQtjI6sxV3qUzEqQbZd7csIi8g3 gYPzCl7OF7+K8cmQg+m/EZZfdE1tPz1U5BokL8u8p+zv1MXT5V/tvtJxm34SAUdDWI+8wC vaIBz5kuXooHHV7ou0W/lCmOSE82D60FzDPKv5DRockG71Ecjt1uYsk5N/nxkI6K5V4ttI Za7OjjNikOqHCijzE2jS/kcXRX90hNOoz6Q7W59EiumBE2qpooz7eDmMbCSZosuVa1r+nM e/rEFPiyNcbtCVaAsvcRmKbohHvhywFOHrQ2Bw0qZg379ENEnngDIuTlOwLu9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787706434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MDnHhhyRmeLgPCGdamQA+reUStXDLO3tNW0hXiZryXQ=; b=BeRzqAlfYaHqNDSkaYSWhANdlxO7pCg7WmDbuO7s2Am0GgOwnBRYEMxv5D00YSyoTjtlml KH5+kBPvzKZ/CSabP95nq06X0vtzSd/Bb01JXipTqRF7PQMK0asYUoJdWe3RW36za6UlxI itoudHdFJt1JADK4DGo/hF/9FP8NOfG0yu0UrqniZ4YDxTVISwZjuFz37sUcqxIvIHFJLf zyFisSYRvAlsXhJmIszQeLl+YNeZsZxOfenQm60EWyeCHy9fXjIksrTllwwFn1TjhMSWVt 5vUzRiTjnkTrwziZxiOB3D9OTLkboD+QVTLJxhohjVeJRJFWzAn8EhRxJMvkyQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hV61s68lCz1BP for ; Wed, 26 Aug 2026 01:07:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44a20 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 01:07:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 87b97830f7e6 - stable/14 - iflib: Allow conditional LED device support List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 87b97830f7e65685448827bc87ee82d769eecb20 Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 01:07:13 +0000 Message-Id: <6a8e3c41.44a20.615e6a50@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=87b97830f7e65685448827bc87ee82d769eecb20 commit 87b97830f7e65685448827bc87ee82d769eecb20 Author: Kevin Bowling AuthorDate: 2026-08-12 01:29:31 +0000 Commit: Kevin Bowling CommitDate: 2026-08-26 01:06:54 +0000 iflib: Allow conditional LED device support A driver class may implement LED control even though the capability is not available on every device or firmware version it supports. Add an optional capability method and consult it before creating the led(4) device. Default to supported so existing providers are unchanged. This will be used by bnxt which blends PF and VF in the same driver. (cherry picked from commit 2519e19f05e0c3e5925bf81b729b4c28f2ad1af6) --- sys/net/ifdi_if.m | 10 ++++++++++ sys/net/iflib.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/sys/net/ifdi_if.m b/sys/net/ifdi_if.m index d52bf66bd110..a4cede67f16d 100644 --- a/sys/net/ifdi_if.m +++ b/sys/net/ifdi_if.m @@ -71,6 +71,12 @@ CODE { { } + static bool + null_led_supported(if_ctx_t _ctx __unused) + { + return (true); + } + static void null_vlan_register_op(if_ctx_t _ctx __unused, uint16_t vtag __unused) { @@ -341,6 +347,10 @@ METHOD void led_func { int _onoff; } DEFAULT null_led_func; +METHOD bool led_supported { + if_ctx_t _ctx; +} DEFAULT null_led_supported; + METHOD void vlan_register { if_ctx_t _ctx; uint16_t _vtag; diff --git a/sys/net/iflib.c b/sys/net/iflib.c index ed6ce3de70de..9c8fb396e3e1 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -5432,7 +5432,7 @@ iflib_device_register(device_t dev, void *sc, if_shared_ctx_t sctx, if_ctx_t *ct kobj_desc = &ifdi_led_func_desc; kobj_method = kobj_lookup_method(((kobj_t)ctx)->ops->cls, NULL, kobj_desc); - if (kobj_method != &kobj_desc->deflt) + if (kobj_method != &kobj_desc->deflt && IFDI_LED_SUPPORTED(ctx)) iflib_led_create(ctx); return (0);