From nobody Wed Aug 26 01:07:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hV61j3NXrz6qLyy for ; Wed, 26 Aug 2026 01:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hV61j15stz420p for ; Wed, 26 Aug 2026 01:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787706425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8MOmqQe/UEF2vS7MYf0My2TXV4570rXepfz7VqY1pt8=; b=snZE+yCsIwJzKxRB4ntWUf7TgfFQJpQw1HjXkcNFiLDbqwsfv9aaJpiS6lzADPWs2IohEu WM8f1xnm1Zhy8GIk/5fzjd5WpOFON/PhFz0XUUV3LAI8KkQay242RIOVg48PY7UhwpH79L NmutGOu9Q2hqZGMUZfq8GK0HyQ8UfSknC6ChK8KS6sg2In6jji42TQEkPM8s2wwHOtvFM0 GFc9Ear8sxS2pbTWOhXbdaug0BpSrURJCRS5BaeWEpsFfRWKtjNnFKtjgH2b3e+7avYxwm Cf5kqIEuMvR3PofZzevrSmsCutEg1h3wuTY3hmJ7pVyNkIQ0HQZPgTaK292xkQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787706425; a=rsa-sha256; cv=none; b=x3tIcH2Wt3NV8mVPeNu1u1tRmiwse4bgSZ0LRYGOtG1qFYVBkFm9lEnRqwzCCw1ZLQ3c4S HPM8eVILB2ghgLMp0XIP+uf3mkqz7v6KQwjosX+htpBAtG8JeEdsYYosxeRauSbxFOrE6m y7JZjwkBalJ+JxNnnjdPbiAqLP37WQsst5ROYOUBW7J40H7+iBBLsgk9UEoRxatTzZeIuN o1S3+bPbD9gsIvgNaTj4arPUzGzxueBBaw0KFjr3rw2E5NePULDa6aGSb0bj5v4myWN3qh 89mtaH6geRd9tbtTaWnQlYMcqeVkilvVd19LMAqtW67MX378HOe6MXJIAXHBcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787706425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8MOmqQe/UEF2vS7MYf0My2TXV4570rXepfz7VqY1pt8=; b=jwPRhcC5t/+P7A8bkUqHXr80G39gzMgxlgN2tFeB3tJI9pe0MXFSDANDIH2x2QJ6SDuBKA m76a63BwVeUMO/ZWG7zyYG7SXz/iprbLJNrMORSHUjyxc5TZJ/YA7PllSLEDvkUXgyGNlY JhEX7tLqxvedFlnNwkJ1zlonOdjhvGTtDPegOQu80VCMrjMD10H9C0hJoqwUeU1zg8qI3N ejYWnNscBGYjO0wyX0/Y6S8d2ixW8F75NGwmnsmRXNCk/JOHZHpjZE6oQnCb6WhS9LAhSY RCOs43SEUE7wxeF4Bgcx9KWoWXwNVVlOyWEqimQbN7ywilCot5UvZw/Kn67RVg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hV61h6kfZzl7 for ; Wed, 26 Aug 2026 01:07:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4469a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 01:07:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 9fbf42910ec4 - stable/14 - igc: Remove invalid debug ring pointer iteration List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9fbf42910ec4ce05ec9a1256ea23c7de9d57b332 Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 01:07:04 +0000 Message-Id: <6a8e3c38.4469a.1badba2c@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9fbf42910ec4ce05ec9a1256ea23c7de9d57b332 commit 9fbf42910ec4ce05ec9a1256ea23c7de9d57b332 Author: Kevin Bowling AuthorDate: 2026-08-12 03:03:11 +0000 Commit: Kevin Bowling CommitDate: 2026-08-26 01:02:07 +0000 igc: Remove invalid debug ring pointer iteration The debug routine reads queue registers by queue index. It also advanced unused pointers to rings embedded in queue structures. Those pointers had the wrong stride and could proceed beyond the ring object. Remove the unused pointer arithmetic. (cherry picked from commit 423927d6c3dc87628fc2a19f25b5b5c07b3b73e2) --- sys/dev/igc/if_igc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index 6722061df54c..6f1df6d6fdf9 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -3540,8 +3540,6 @@ igc_print_debug_info(struct igc_softc *sc) { device_t dev = iflib_get_dev(sc->ctx); if_t ifp = iflib_get_ifp(sc->ctx); - struct tx_ring *txr = &sc->tx_queues->txr; - struct rx_ring *rxr = &sc->rx_queues->rxr; if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) printf("Interface is RUNNING "); @@ -3553,14 +3551,14 @@ igc_print_debug_info(struct igc_softc *sc) else printf("and ACTIVE\n"); - for (int i = 0; i < sc->tx_num_queues; i++, txr++) { + for (int i = 0; i < sc->tx_num_queues; i++) { device_printf(dev, "TX Queue %d ------\n", i); device_printf(dev, "hw tdh = %d, hw tdt = %d\n", IGC_READ_REG(&sc->hw, IGC_TDH(i)), IGC_READ_REG(&sc->hw, IGC_TDT(i))); } - for (int j=0; j < sc->rx_num_queues; j++, rxr++) { + for (int j = 0; j < sc->rx_num_queues; j++) { device_printf(dev, "RX Queue %d ------\n", j); device_printf(dev, "hw rdh = %d, hw rdt = %d\n", IGC_READ_REG(&sc->hw, IGC_RDH(j)),