From nobody Wed Aug 26 01:00:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hV5sf1VLyz6qLNt for ; Wed, 26 Aug 2026 01:00:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hV5sf0CxXz41F9 for ; Wed, 26 Aug 2026 01:00:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787706006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RO38McCsnnVlKItfLgJRgrPSOzH4HSDQaRGaJocZYFs=; b=lyDDA6WSmRNVSf0kYj2PM8V7lw8l6hfcDK2ODOxbIY5Vq3b/+kPqfGmOVQwUADuh6iPQOV 2whQzn6miBxlhnCdg0sxieX0eQXu2qDCEEmZC1t8CyGCayxSCUlQ3Dch5lJN1OJF589WAf +jBZdnVm7P9tdYYgfvy+rEWaGK6LkiOf7tEzN4eM1JThIndN6I/uAZdDzVYDF5ED+ZZYS0 jYb5tMrdNrZVumCa1dmrS7LIK49lqkqUG4ckHXnRZGHGMRH52WN0nASoug8xrHlHVsvNJF TPLApxuitO40uC15sMMqzaLyB5ZF82Vwdxp6rJD2j5TcVq3sqONEvdnt9rootQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787706006; a=rsa-sha256; cv=none; b=FxkiQCc51130Opz/yvylLhiZQ9NSTXTu7hJE9e6dniMRmxYXFETX0ilJQo8Bp5W9aJtFRC CN1nxXiNJkQWP1JvfJA8ZGjJEYW/GzPOMN219ybCaN7r2s9MtFBA9bVpiZuqSCP+3Viys6 aLtvs8Krgfh6lgZ/wpPh9TDKHEQS3/3zzwqf8uj/0a772KOOlwn95wgxEcO1p5R8Ls8Tr8 eYXWbTcYt+GBGXdLmgy8t72kLnwoGPht/NiQf0vI16i21GnG9HiVEUOdvQrGIDh0/NqKjG y+ulGnIRjUjPJ0nZKcBKkiO1AafGeAvkGtbMJJnvmIixEwV5FzU4DF9i78JV/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787706006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RO38McCsnnVlKItfLgJRgrPSOzH4HSDQaRGaJocZYFs=; b=vNi9r99yuWOQiOI+n+151jaYQFoCZ+2dTdHoc8EuJn9iXnM1y4RZRRxxZAetw+TrJeDpdo WBCZSxlv+WPq3ciPhORdmIb+vm2DfwsQhlZuJlMUoy5SyIozGVIaw+J9b01ZRO1Ly+zgOY CyP/2dAHYjQKdMgbDUkF0/i4oimSqVOvIPrn8uFnV2O4ZaIelXyvshMwwYKkKN7R80eIoG w9nyAMb8vrY59WKkcrqVZrfzKce3wUEHjT8e3gKbOJK4Ezx1AoX1VYK23WLaegtdU1afMo x3u18LpEAFHu74RN03a8DmIBfoPAnq45WIKrxRSiPN3MRz6aXrhWz4LzWAii3Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hV5sd5dsTzVb for ; Wed, 26 Aug 2026 01:00:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4459e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 01:00:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 9d5a14887559 - stable/14 - e1000: Identify SerDes adapters with LED blink List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9d5a1488755938edf8a05d472fe68399b9129c11 Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 01:00:05 +0000 Message-Id: <6a8e3a95.4459e.69eb42d3@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9d5a1488755938edf8a05d472fe68399b9129c11 commit 9d5a1488755938edf8a05d472fe68399b9129c11 Author: Kevin Bowling AuthorDate: 2026-08-12 00:29:17 +0000 Commit: Kevin Bowling CommitDate: 2026-08-26 00:59:48 +0000 e1000: Identify SerDes adapters with LED blink The generic LED on and off operations do not handle internal SerDes media, leaving the led(4) device ineffective on my I210 fiber port. Use the hardware blink operation for the on phase on internal SerDes. The off phase restores the saved OEM LED configuration as before. (cherry picked from commit 28f96cc3748fc46408cc6ab6172f09bc2182cad7) --- sys/dev/e1000/if_em.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 704fd099870b..c9abee7eb65e 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -4924,7 +4924,10 @@ em_if_led_func(if_ctx_t ctx, int onoff) if (onoff) { e1000_setup_led(&sc->hw); - e1000_led_on(&sc->hw); + if (sc->hw.phy.media_type == e1000_media_type_internal_serdes) + e1000_blink_led(&sc->hw); + else + e1000_led_on(&sc->hw); } else { e1000_led_off(&sc->hw); e1000_cleanup_led(&sc->hw);