From nobody Wed Aug 26 00:57:03 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hV5p80CtMz6qKsn for ; Wed, 26 Aug 2026 00:57:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hV5p73BMNz3vGK for ; Wed, 26 Aug 2026 00:57:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787705823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jO4FZzP2drHYTYxkAHkMWkWEK+oG0NOvHU2TktDxy94=; b=oerl96pY5OidkDuyvvgvDtKQfx5mnUKq8KOTcOzE0cvIUV0GGmh4NJurwMHSV8FdzTMG/Z NfyHBUDr/WO5UE9T/L4CLwepNojRpLTumMKNELEy5vxaeKerUNkCLvMiUcWswGjOlYX3yj G9MDoAfQYltEbWMor12c4LZbbuj4ubcCYFLENOvSvhjf5mJNYaXcus5Ap7GotFwHdl539Z 6zXEs7q5+84e8RETgcFUpHjGf+gFGLUzKcy4xcznEYajR4qBmZ+wD9a75rdQnHqytltiAu ESA6XximTFEGDLUUCkeCliYBi+eWHhbwFJvS8GHwieMVZ4R+XKeVCzB23T0vVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787705823; a=rsa-sha256; cv=none; b=R0GlXS+RY+v3wl4WVXrNFSbl4SHGc7LtVD7JRgcJ1/LFVzc+4pib+pWOMJvET6cFypgnTa /motKbY3YMeaDiJUjkqETyaRnUZEn+Mi2ZownK0iOMatkF9TaVJWeX9zKmKpFPN2Wo6kAz IyYKez9lTv1rC6w8KViFoEC7E4HXSInj3qWNaSmhCV0ExAbShlAaIz8XAPqUR8pw5bEPgt WkHth9gZX0CEw6gHGPO59yz8dI+rdreN5AOAmbeyHiZyvkM6+/iDZGiG3vxMHUTNh55gAX 0D5+ISSX71QA1Xl/r20s2HQ7GtsxPTXumvbdAeLS/0PmkfkK+8STtfsrhwFFsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787705823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jO4FZzP2drHYTYxkAHkMWkWEK+oG0NOvHU2TktDxy94=; b=Pg18NxhowjgZZCq+2zjf6ngAu6mLLc3WQSgGL4XKu0KUxf1b1lJNgXA07jaI/1LPV4mLHh 34Be9v7XVCsrd1QCdzU0eWDrgxkq00Z3lCEbwEKgr8+2LBXI7BrL6C8LTNUWyNRSisvfUp /csgfm8fYEW9LCvrW17nPinVAFqzfRNFAl8Cvjque29IHpBAkvNebko6U3U4lP9mDd1Y0V 0jOqPynhI60Y+6X9EYYZ1diX4o7ZO4G1XpUADW/zcixOOKKk8soQgTKjk25nU/GRuhDkx+ PA+W7LvahSRtDVQkD+5U5qPAQrkjaaKfaovyWYLxGbu+f0X2CHD3LqjFFpGyaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hV5p71SMHz17L for ; Wed, 26 Aug 2026 00:57:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 437a6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 26 Aug 2026 00:57:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 63d782348e44 - stable/15 - igc: Remove invalid debug ring pointer iteration List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 63d782348e44f7635fcf9ff455d05490a8030e93 Auto-Submitted: auto-generated Date: Wed, 26 Aug 2026 00:57:03 +0000 Message-Id: <6a8e39df.437a6.66430121@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=63d782348e44f7635fcf9ff455d05490a8030e93 commit 63d782348e44f7635fcf9ff455d05490a8030e93 Author: Kevin Bowling AuthorDate: 2026-08-12 03:03:11 +0000 Commit: Kevin Bowling CommitDate: 2026-08-26 00:56:51 +0000 igc: Remove invalid debug ring pointer iteration The debug routine reads queue registers by queue index. It also advanced unused pointers to rings embedded in queue structures. Those pointers had the wrong stride and could proceed beyond the ring object. Remove the unused pointer arithmetic. (cherry picked from commit 423927d6c3dc87628fc2a19f25b5b5c07b3b73e2) --- sys/dev/igc/if_igc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index 6722061df54c..6f1df6d6fdf9 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -3540,8 +3540,6 @@ igc_print_debug_info(struct igc_softc *sc) { device_t dev = iflib_get_dev(sc->ctx); if_t ifp = iflib_get_ifp(sc->ctx); - struct tx_ring *txr = &sc->tx_queues->txr; - struct rx_ring *rxr = &sc->rx_queues->rxr; if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) printf("Interface is RUNNING "); @@ -3553,14 +3551,14 @@ igc_print_debug_info(struct igc_softc *sc) else printf("and ACTIVE\n"); - for (int i = 0; i < sc->tx_num_queues; i++, txr++) { + for (int i = 0; i < sc->tx_num_queues; i++) { device_printf(dev, "TX Queue %d ------\n", i); device_printf(dev, "hw tdh = %d, hw tdt = %d\n", IGC_READ_REG(&sc->hw, IGC_TDH(i)), IGC_READ_REG(&sc->hw, IGC_TDT(i))); } - for (int j=0; j < sc->rx_num_queues; j++, rxr++) { + for (int j = 0; j < sc->rx_num_queues; j++) { device_printf(dev, "RX Queue %d ------\n", j); device_printf(dev, "hw rdh = %d, hw rdt = %d\n", IGC_READ_REG(&sc->hw, IGC_RDH(j)),