From nobody Tue Aug 25 18:56:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTxnz6PyFz6ppF6; Tue, 25 Aug 2026 18:56:23 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTxnz5Vcjz3wpG; Tue, 25 Aug 2026 18:56:23 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787684183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WTg6tt9RAgEfS5EFegCLkgy3JAzGURX7SBiMK1qDo0c=; b=DVnBHLi6na9t2fOKtFnUZMDcX/9gC8UovR2h0YRQzmAs3N5Ds8xWiOqG5l12jww6iXWH7D T6kNCSdUjdImdOM//tf8dvcDyoDwFloc5L8Rr5j2n4OdR0bLEDxMY4WQmqrfJwbLcPkEaa B8snWYvS1JFx+njBm5o6ugojpckM/FA+qF6p4+UHo3B3Yae+h1gPR4ReAGAQG6tVO2r4d2 ouCmefc/Y5Hxy2ucfDtQiDyZpBOUgyzNHMlxzJU2gckmGTrsbSlJtW5K/S8tSmeh/VbL2S AUsZ4+WUJFzJgiff2ZdrAQXGa+OvgkwWzqrLFMSGGs6bjhWR+PdJNZfkx/Zy4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787684183; a=rsa-sha256; cv=none; b=jkenL7z8LgOghTyIFlyHYynq0phA6Jfh3OM8vH0ji5HDgQTMTimXNApX/ew5i8JVLxKt2N tGe09qFbdkWHrc+kq1h6pbuFvgpBmkzy5LKDqeD7ROTi7rX6p/a158kuWyrJhN2OaxTlRU dbolL421+zYQwwN9Ws5kKtz4r6uqN0IscmjwZCHhrWy3NIndnBLwxVhj0bv+90y7veFmMZ xlBa2rwhZYs4p8MUJmJxW9WSoryWwKUPHuBpnqAuc6bq89SVsKhyJhPr7fdhg8uGyXgWrS v01By21sp3NGQSlTo0WYgk5mRLTh4hgKE1RKV7wMx14YN91UYp4EZV0HWmERPg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787684183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WTg6tt9RAgEfS5EFegCLkgy3JAzGURX7SBiMK1qDo0c=; b=bhohxOZBcMHnrmnlqgarqnevsZACWTI3/PsnB83X3BEtrkcmWWEeZkceFg2wnBx06F65/q jh17wnSECpVamgFSfn+Ke9vp5hGIAY4pdKNlSSZvLS2lPGAlKIsSslXzqvI+UELOlBXh+6 I8bhZDdQcQg21/qdw5JwJW/c400SW9gHuWYu2keOQIMOZm6FwcnQiH+j5kSYU5zwJ1Z4kB rt/LxPL9HSvewgjTIUEUboNFmdjUJ44+dcQ755wRuED36PIv4eQMWB4hxHOewpv0ZbZWn/ 6squOsKoK07MmUhT40e0qfqBcZQ18c+AzsaiamDOgk9x+55M3iNsfy1glhvtpw== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hTxny5cQlz18kR; Tue, 25 Aug 2026 18:56:22 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 25 Aug 2026 11:56:19 -0700 From: Gleb Smirnoff To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cb7009867ae6 - main - socket: Restore handling of IPPROTO_DIVERT Message-ID: References: <6a8ddc49.415a8.4a8f8c61@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a8ddc49.415a8.4a8f8c61@gitrepo.freebsd.org> On Tue, Aug 25, 2026 at 06:17:45PM +0000, Mark Johnston wrote: M> The branch main has been updated by markj: M> M> URL: https://cgit.FreeBSD.org/src/commit/?id=cb7009867ae6b33aa39cb6cb1453b69073144b44 M> M> commit cb7009867ae6b33aa39cb6cb1453b69073144b44 M> Author: Mark Johnston M> AuthorDate: 2026-08-25 18:09:09 +0000 M> Commit: Mark Johnston M> CommitDate: 2026-08-25 18:09:09 +0000 M> M> socket: Restore handling of IPPROTO_DIVERT M> M> Python scripts which use divert sockets no longer work after commit M> e967a2a03677; even if one patches socket() calls, getaddrlen() doesn't M> work on divert sockets, needed to use recvfrom(). M> M> Restore compatibility when COMPAT_FREEBSD15 is defined. M> M> Reviewed by: kib M> Sponsored by: OPNsense M> Sponsored by: Klara, Inc. M> Differential Revision: https://reviews.freebsd.org/D59018 I'm not happy with this change. I know that I'm slow on reacting on reviews, but for this one you didn't give me a week to say anything. I did a lot of work to discover and upstream all applications in the ports that use divert(4) to properly use PF_DIVERT. I worked with python to adopt PF_DIVERT and I also fixed the getaddrlen() there, too. See https://github.com/python/cpython/pull/142993 I addressed all python scripts in the tests to properly use PF_DIVERT. Unfortunately python is very slow with accepting changes and our ports are very slow with adopting newer python versions. However, the bugfix can be easily added to python312 port as a patch. Now with this change we will have extra check for every socket(2) syscall to satisfy a very small number of installations, who are ether willing to run FreeBSD 16 with outdated python either with proper version of python, but are unwilling to apply a trivial change to their script. Can you estimate number of this installations? And we all know that COMPAT_FREEBSD15 is going to be part of GENERIC for the time being, thus the argument that it can potentially be compiled out isn't strong at all. -- Gleb Smirnoff