From nobody Tue Aug 25 17:34:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTvz55S9Yz6pjHP; Tue, 25 Aug 2026 17:34:09 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTvz54jqGz3cjL; Tue, 25 Aug 2026 17:34:09 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787679249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pdeTqu2sXGhdt0pri+Z5RpY+6n1pxERUt9/MfTYY0Y4=; b=lyMpSwWcvGsdtYFvzIUUPlY6/eOmAzeYihx6TtffZPAXR/TN11f/Dd2PcHhcBBRKle0cd8 WtDFSL474dOMx74Ank5TdyIccdCpAAggeKHc0NdlPrAyRHAvXXFxFJXdSzMMMt2v4zfjqe DXbslZa9uMYgYt2O57x0bMJb/VdkibnkAj1lgaBNrd+3KhSIXvm0BH4DrYyStVxTeUzsiA fptzoFsB/RApkB1w82A5Utwbrz8KX5K2WiBD9eRcFIlJjSUFVUrec/dNPTCrJe8tpoeA4L MxNPHL8VnOzjDUhWFySdVJhvNGzkKrz04IuU7tHt7Di1Du/CXXPyoCqEJg7G3g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787679249; a=rsa-sha256; cv=none; b=TavOTdwF9QnB5J41m498GkJO+QiqQiUA3IUIRp2KtsRk+94VI6gBBpwOQEEhnJLija2weu I7F4wFBxcG6ntG1NnazP0bgFJvtCjYWRi/sbl/c3cZ1YK/x4Oy7AjIHXZiRbgUsXLQ4UbQ 4JePDRn8VEy56AzUXpQG4tVT4YMT690TAwbaUIVj0L+zh6bTKUhHnNF9En3+4oaVllQqlf U1KxkOc+ZILHZHsb6r2Y3bxtXosOkG6uzBbagbz2vMzbBPdAI6+Z1YsG09SMFlQqUZX1z4 bNnTcyBpGoRNSU+hWa+HTTTRJACV7lOzQDarQfUQfr3dDovvsnqJZ2/2RRHK/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787679249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pdeTqu2sXGhdt0pri+Z5RpY+6n1pxERUt9/MfTYY0Y4=; b=QmMUkG0pcIuahc/9qu6l7jGQrTmIdxwthC0DGSPeJGtg73tVCRrZ2CxTjr/EvLw7eA2A2S sJFi0k7kLE/sQh64lN8S3h/6dmHKBY8weWpK9gjWLAQpcQIthJ6+RoDXveUHH+JWAVVDB5 kwfHFIqMw36+S5GkxwFx3zgqGYMdIyzf06FqSLK1toCR2pGA3JIDUoXLb9mnHzh0L6pRv/ HVq6AMbdjZYENIfO2Bf/IpzEEq2MYiE9fryeKyj0xMf9w0yvw3LkZst5dzNlvtc1Dxrn9X TzeVTjsQPBq5UHSK6h+OVtvILkSsS7VtKMseiT6+qtytnoTCdJaxTWaUtGi0Wg== Received: from ltc.des.dev (92-129-202-201.ftth.fr.orangecustomers.net [92.129.202.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hTvz52hM3z16tG; Tue, 25 Aug 2026 17:34:09 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 2906EF83DD; Tue, 25 Aug 2026 19:34:07 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Devin Teske Cc: Faraz Vahedi , Warner Losh , src-committers , "" , "" Subject: Re: git: 8d29d2429649 - main - libc: Restore prior C23 include guards In-Reply-To: <730AFA99-F6E9-4D78-BE52-54E1DEE3ABF4@freebsd.org> (Devin Teske's message of "Tue, 25 Aug 2026 09:16:12 -0700") References: <6a85843a.3287f.2aec5cf8@gitrepo.freebsd.org> <865x0z6526.fsf@ltc.des.dev> <86wltf4mz8.fsf@ltc.des.dev> <86ik4y4gsv.fsf@ltc.des.dev> <730AFA99-F6E9-4D78-BE52-54E1DEE3ABF4@freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 25 Aug 2026 19:34:07 +0200 Message-ID: <86ecfm3y0g.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Devin Teske writes: > If someone uses __STDC_VERSION_*_H__ to inject C23 syntax of their > own, they are asking the advertisement to do visibility's job. I may > be missing a case where that is the right test; I have not found it in > 7.1.2p6 yet. Imagine a single-header library (i.e. a big collection of static inline functions) that uses __STDC_VERSION_FOO_H__ to choose between a C23 solution and a backward-compatible solution. This header is then included in a C99 program and fails because we are advertising C23 features to a C99 program. It's really not that hard to understand. > Your predicate (__ISO_C_VISIBLE >=3D 2023 || __BSD_VISIBLE) would make > the macros mean "this compilation can see C23 semantics from this > header." That is a policy we can talk about on its own. I would > rather not fold it into the _FOO_H_ restore, which was only POLA after > gmp. I don't know what you mean with =E2=80=9Cfold it into the _FOO_H_ restore= =E2=80=9D. The =E2=80=9C_FOO_H_ restore=E2=80=9D has already happened and we're not going = to rewrite history. I am asking for this feature to be implemented correctly. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org