From nobody Tue Aug 25 10:48:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTkyq20d6z6q2Gf; Tue, 25 Aug 2026 10:48:19 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTkyq1CTyz3Pbm; Tue, 25 Aug 2026 10:48:19 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787654899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AymXSclNLXQwlgPdeDK++ZmskMnSdpqPKsht2rEJwvQ=; b=omdx8/RY6EPqqLvkTOkp1PgF2o12ixwHCoXK8J3VMrJo1vbrJ+c+gvPIKRjR9zugzp30HN ygQSLAC4Zi/lL5LDoa2xr0WSY0nlBqCLdC2bZ1OvIjte330SVb/usVukeofpfVrU4WRaDz WkH1TtEqi/CPd+i4IUsmoZ9H+Ceo/wLByVSvh5gLRE0z+zEea+btvFcw5mo7q0KFot9rnT vg0ZNetFIaBVDiQB5GeJN/0MBiWRBaGgncU7Gq1v1YSAf+hLO1dLgreKX1OSjbbDFvwhBo 7WwYDIFrF6MhoUn24whpO/A+lCVxJyw3BM30tM4ALoCRP2plQOykxg2RjAbpTw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787654899; a=rsa-sha256; cv=none; b=QIURK/e/mNIemeP8T2mCgeGZs3rWp5R+Hb6VTBUSEjqD0uGOXlz5LtyFU6BV8AGiWkytVV uZWH7pE/uoVMgQN3uNiUtad1G7bJ2NMcNIBAVzMX6Cs1YphK9CwH7xqqW0pNdD1lGuokiY m4Kfhi/gTi/LjIaJyaN4IislZRVlNOV639Xg5MSXWiRr9M4qmcN3hcE7eNCnKjkpGs+qWw tPpdnrSCqitDwdgfrKhHbC+9tF4gp0ZCul4Jpo8IBzOoXgyFyTz5RvU9XAmKc74nMBGa+Q H9uFIsPpWQXWSKmCAnTXoeLQujEUaoHkKE16Cu7FBfxhjjZQrpGEjWE8XxcW9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787654899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AymXSclNLXQwlgPdeDK++ZmskMnSdpqPKsht2rEJwvQ=; b=BBGnu6qC66o8emx54tK9Xx5onZilGIMT01WQrL4/6AIKfKpWNcb4fvsCOq518NaxJ5ODHL lDes0CH5oc4bbpBTNN29UnfX6ZssOCqYyScrnAblEI0Pt8h+NUt+vV/PfQImeid0rTpInp SuFp9fN66hiHBx2wt1X5oM6P+j2PgbsDIKtWvi0/4J5aNcYDgA5T9kvs1FyouA4dUYfcdO SBWZ7c/GGXIyz0osus5mqU2Sarjxm29p8l1cLtOMK+KnnDKHReXaJTTwZJns98iePGBCWz ooAc0iB89oUMujDu3x1rMbIgtaf/nisumdRlnuV02OWLmDw9iVyPyuYoNLc6zg== Received: from ltc.des.dev (92-129-202-201.ftth.fr.orangecustomers.net [92.129.202.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hTkyp5g1Nzy0T; Tue, 25 Aug 2026 10:48:18 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 8E802F86E7; Tue, 25 Aug 2026 12:48:16 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Faraz Vahedi Cc: Warner Losh , src-committers , "" , "" Subject: Re: git: 8d29d2429649 - main - libc: Restore prior C23 include guards In-Reply-To: (Faraz Vahedi's message of "Mon, 24 Aug 2026 18:22:23 +0330") References: <6a85843a.3287f.2aec5cf8@gitrepo.freebsd.org> <865x0z6526.fsf@ltc.des.dev> <86wltf4mz8.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 25 Aug 2026 12:48:16 +0200 Message-ID: <86ik4y4gsv.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Faraz Vahedi writes: > Since these macros solely advertise which revision of the header our > libc implements and are neither a language-mode nor visibility switch, > I believe we=E2=80=99re fine. C23-only identifiers are already gated on = our > visibility macros, and exposure of these feature test macros per se > are not of any harm, even for libraries targeting modes prior to C23. > For the same very reason, it is also fine to have these as include > guards (which brand new C23 headers like and > still do). > > My restoration of traditional guards was just to avoid any possible > POLA violation for those depending on them (albeit wrong) as reported > by dim for math/gmp port as an example. Just because you don't understand why they did it doesn't mean it's wrong. It just means you're young and inexperienced and have no business making categorical statements like the above. Please make the __STDC_VERSION macros conditional on __ISO_C_VISIBLE >=3D 2023 || __BSD_VISIBLE. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org