From nobody Tue Aug 25 00:42:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTXC4xMbz6pNmW for ; Tue, 25 Aug 2026 00:42:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTXC24yzz3GMq for ; Tue, 25 Aug 2026 00:42:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TDOyTqEeIkcMXj1GJYi807CYhNadzd+xENUo2mdWGBY=; b=RsEIYOtJ5VVKtRWQvfVDAIyrKs/k4eKwCXmtz1f1Lg3Ktq/cpVIt1dPt33pfMruDbYqrB+ bOTTxWqDVEA2DeMl7pjei1V04jS6UBspWoXuEN/iVuJo+uC9OSCLKSTDzaDdbGUab6iHp8 AWtE1ED+rgrMqUUmLJKIh8GuVNyNgtY2gZxZWR9syTqYeLdkrP0EabbRUclexFiJVGjtdh seGFunGtAvt4Fizo5yQv6iEXgjE8Yfz856rSrGUJEV1V4nL1ELCSspzAK0AiEoPNbjOfiL CS1SD9rdYOWWeR1xfZmc9S2nUC0ok5KW086qZAKqnXLOSlPbBylYbQyYsAk9Rw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787618571; a=rsa-sha256; cv=none; b=CUks0rufJqtJOWzbS0wqYHflmeMevCavPtiR3Q72ng1oemfeXZm7ITxMZ5mwqgClbkA2jC UuFteoLeKZ3TcDSIUgWeTXIM5q9g8tkpaQNXAnOmfBYLBhuMMIcN0KoPg2DQbdC2IlQ9Be JAwGd2IYwYRkyq9vzA2yQ0pKUmEFTa0zPjFLgeJrmc/C70RzLJN7ia4dgEkXFN/pfOY0rl c0XwDk5NStbQD860l2HzEyNt0OtOKVxI633Z3JhtaXI8JjLAQu7KRFV487MZTvnxDTegig 91NaZmMbkxEpn1l2HYV7Ex2AFqP1A+yQwR2bbmofgplJfG/atP/wjJWdvekAyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TDOyTqEeIkcMXj1GJYi807CYhNadzd+xENUo2mdWGBY=; b=o3qp1oqgnDMI3N9hAXQc/ISPPk3kVK34RkYLD8awYTsIKayAbXCKzU1pRNy/Xn36METfQo t9YHH6upeMR6GJLwaeiyGAgOIlCozxctKqui7Icwsd12cxl+ygBva0BNoWnnuWFs3yYVck l/fZ/pOEY+4pLt6D7/FEDZbnmL8lALVL00IcZndfP54QjGIXZXGJLEliW5GiRcednbTEKH hSn34TA5ff8auFzwcI9Ow+QfIEkKYeEzHTVukKt+pYjmP0uAMXu/0DTUEmAX5P7+c8ZBUj 68OUhT841ZsngyuPn3iLo6RyHh2mCwH6YRio62equkLY1mDZ5hQDZMzHzbEEGA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTXC11mFzCnd for ; Tue, 25 Aug 2026 00:42:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40dc7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:42:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Aleksandr Loktionov From: Kevin Bowling Subject: git: 1aa70ba43f47 - stable/14 - igc: fix MAC address hash bit shift List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1aa70ba43f476e626be122b77ffb3503ac2c3664 Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:42:51 +0000 Message-Id: <6a8ce50b.40dc7.462809cd@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=1aa70ba43f476e626be122b77ffb3503ac2c3664 commit 1aa70ba43f476e626be122b77ffb3503ac2c3664 Author: Aleksandr Loktionov AuthorDate: 2026-08-11 19:34:01 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:40:39 +0000 igc: fix MAC address hash bit shift DPDK commit message net/e1000/base: fix MAC address hash bit shift In e1000_hash_mc_addr_generic() the expression: "mc_addr[4] >> 8 - bit_shift", right shifting "mc_addr[4]" shift by more than 7 bits always yields zero, so hash becomes not so different. Add initialization with bit_shift = 1, and add a loop condition to ensure bit_shift will be always in [1..8] range. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Aleksandr Loktionov Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Obtained from: DPDK (1749e662f6) (cherry picked from commit cba56bc3427db0bb4efc3d0117cda4bdc7717f98) --- sys/dev/igc/igc_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/igc/igc_mac.c b/sys/dev/igc/igc_mac.c index 6a00867c7a8e..2c32f0c7a606 100644 --- a/sys/dev/igc/igc_mac.c +++ b/sys/dev/igc/igc_mac.c @@ -301,7 +301,7 @@ int igc_rar_set_generic(struct igc_hw *hw, u8 *addr, u32 index) u32 igc_hash_mc_addr_generic(struct igc_hw *hw, u8 *mc_addr) { u32 hash_value, hash_mask; - u8 bit_shift = 0; + u8 bit_shift = 1; DEBUGFUNC("igc_hash_mc_addr_generic"); @@ -311,7 +311,7 @@ u32 igc_hash_mc_addr_generic(struct igc_hw *hw, u8 *mc_addr) /* For a mc_filter_type of 0, bit_shift is the number of left-shifts * where 0xFF would still fall within the hash mask. */ - while (hash_mask >> bit_shift != 0xFF) + while (bit_shift < 4 && hash_mask >> bit_shift != 0xFF) bit_shift++; /* The portion of the address that is used for the hash table