From nobody Tue Aug 25 00:42:43 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTX365ygz6pNqB for ; Tue, 25 Aug 2026 00:42:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTX34YhWz3G6k for ; Tue, 25 Aug 2026 00:42:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=feQa+7Gelhc5Zwv1rti4NeWAGR/v85ebQlc8vN6Lbns=; b=AF2tq5LDNL1mr9r6sijkDEU+I9RMnK5HXJZj6wDmBDhCdC1/K1Nr3swy2KvQY9rbLwNdhq TgLXy1BD/Gdd4ebmAwd8bLA5EhZT15gytDrU1TZdv3bUS2ltdEyK0NoaNXN53XpRjlKHrX ul6dDD0lDi7HHMQt1MI4Cjyxjh/wsT/eo6qy4XAx0i9zc0OPbkYegWQw3rwuPlzHb87nmo n89UOm3yfs5VUQT1+cGPTPPlXCtPTWGi9Ro2IZKab6DgzSzNnBri1CshMb4wpXDJ8Wfnu0 lg79vk0pGvSQt96iWmfISsAiQPrqrxIOC6eEXIVMiOnFiATPqOGWWtjQXtmMUA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787618563; a=rsa-sha256; cv=none; b=uEoFgmPP4aj+TH335lsVXs7eXBklWQqMBACdETaA0HeH6Xcq+ZoFFbSl7x9IAFzS2prCvF NbwB65PEnUKKtSr9/Ghi8SZxkErwLkHp6J3Moo5qd1eNVJD7BKf67RJUffnl9znqYJn8hJ +osdizTBj6V0C1PRQR8xk1vRyyd3zQ7mIfV9ohOlzXCKIQH2PvGb+zowdouLOQNAeXAf/G LrBNNlIJ2UhC6rHZ04lrGP1Qi8bVtqq+5HiYcBrO8LqY/X5VIJR9APhvNcZKAecBCq7HS0 CE3lmV+P7PxElNPoQMnM4V5kjPaN/22wwJYayAtwSQJdOzy/3pZEJtBtKuySqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=feQa+7Gelhc5Zwv1rti4NeWAGR/v85ebQlc8vN6Lbns=; b=SwTQmYnyMyYWOfz05KoB/Z2deJ8glR98TtxjMWnvOpcmhTW92jEw6tt0ovhK9R9v0XIXmE yCVFKXEYPc52+G0iUVyeIQRCqyoXJkaZt7mTBy5lkFk0yi8VzZjt4Aq/DDiIuupEmlINbN yNutqbZPUeC3o7ok17G9+cy62mlDa6bKxtPTls8mR7h2q1iQRUQ5ArJGk2ZZaTMHCJQ9Ds eYQEjYNRiMPG0sAFj+ERr5BgPtfCW9AQKCUgC0KIdg1OniZO/GqcTNz8+BaQGdX//Gztej BQYgHd9PUwpZZHixt5s8L/S//oSASI5JAcYj5fNxYquSSoZax5mdfCPSRcjaqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTX334RvzC0r for ; Tue, 25 Aug 2026 00:42:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40231 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:42:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Barbara Skobiej From: Kevin Bowling Subject: git: 14639ea38304 - stable/14 - e1000: fix data type in MAC hash List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 14639ea383043a061e8a699b196d897bbff23884 Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:42:43 +0000 Message-Id: <6a8ce503.40231.678dd9d4@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=14639ea383043a061e8a699b196d897bbff23884 commit 14639ea383043a061e8a699b196d897bbff23884 Author: Barbara Skobiej AuthorDate: 2025-02-06 16:08:41 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:39:14 +0000 e1000: fix data type in MAC hash DPDK commit message net/e1000/base: fix data type in MAC hash One of the bit shifts in MAC hash calculation triggers a static analysis warning about a potential overflow. Fix the data type to avoid this. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Obtained from: DPDK (458734aaac) (cherry picked from commit a09034d561cbb3792ecc0146b41d4794ab3bda37) --- sys/dev/e1000/e1000_mac.c | 6 ++++-- sys/dev/e1000/e1000_vf.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/sys/dev/e1000/e1000_mac.c b/sys/dev/e1000/e1000_mac.c index a34e2c873a0e..eb2c29d153dc 100644 --- a/sys/dev/e1000/e1000_mac.c +++ b/sys/dev/e1000/e1000_mac.c @@ -576,8 +576,10 @@ u32 e1000_hash_mc_addr_generic(struct e1000_hw *hw, u8 *mc_addr) break; } - hash_value = hash_mask & (((mc_addr[4] >> (8 - bit_shift)) | - (((u16) mc_addr[5]) << bit_shift))); + hash_value = (u32)mc_addr[4]; + hash_value >>= 8 - bit_shift; + hash_value |= (u32)mc_addr[5] << bit_shift; + hash_value &= hash_mask; return hash_value; } diff --git a/sys/dev/e1000/e1000_vf.c b/sys/dev/e1000/e1000_vf.c index 89ce0181faef..5b19375e6034 100644 --- a/sys/dev/e1000/e1000_vf.c +++ b/sys/dev/e1000/e1000_vf.c @@ -371,8 +371,10 @@ static u32 e1000_hash_mc_addr_vf(struct e1000_hw *hw, u8 *mc_addr) while (bit_shift < 4 && hash_mask >> bit_shift != 0xFF) bit_shift++; - hash_value = hash_mask & (((mc_addr[4] >> (8 - bit_shift)) | - (((u16) mc_addr[5]) << bit_shift))); + hash_value = (u32)mc_addr[4]; + hash_value >>= 8 - bit_shift; + hash_value |= (u32)mc_addr[5] << bit_shift; + hash_value &= hash_mask; return hash_value; }