From nobody Tue Aug 25 00:37:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTPy2JJxz6pNWN for ; Tue, 25 Aug 2026 00:37:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTPx6Fqcz4PKX for ; Tue, 25 Aug 2026 00:37:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zeAnyY5KbhbIlZmJyKTxabG6tqXBDkvm+ZuCmNOOVDU=; b=f99JFtZXiBZ9ryJa8d0xdUccHNd67Ly8mk/9a/E7J2errMWISyuROY1HMvqRvJrpa/dwVl KfYJY5tKbKGSGXeZPZ84Vxbq1wp5jNqNfJOsasBUC3YRlHcLpu7jvmjR6gtd1xw29zxZZy +gKlhQjZ7/PUVOACSu4J6qhS1bzMNVO1E90diFt5RDbq/oHC6gdMGzA00yCvia89wCIntH bTa7DaJ2Q8dOx2GHHPpvQWLTYYoblUBWybEhJHlRxFTMQoBmfO0Eb2SYS2Y7myIEXH96we uisQR2RVFfQf2DYliQyzV8JD3kL8sCSDRKzK9z/G+OHvlwqwB0+MOaij6RHtpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787618245; a=rsa-sha256; cv=none; b=qZJnzzx6hSVgMEqUV9x/r65BAVTET/2nG3eW9xEwmOUh23GaBex2uQjk6XVuVmmE+47tMx +zmj5SOD2KSg2URcPFJafeqdgCmrx8jgqWj/hRpESTlOOTZ/0PCFdLOefKxx+XpBQNNBG0 dFUV14tsS8o0v1qX66Gy/E3T3SFS1O/FlEpW4TjrTh4dDgiB4YC44ia4xnVpLK488VijBe ZWQRzgWvwmUt0T77Qt/xEIOLVi0wLOoCnwQK0fNI+HykT2PxxzXBJ9CY59iHIbK9oo30bO zqOTJRC1dYhXkRf6t6kji0YNZs+QN5Air8eiVCw9zl+UVMNh4E+y7D17O3NphA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zeAnyY5KbhbIlZmJyKTxabG6tqXBDkvm+ZuCmNOOVDU=; b=sY3LR7KaP4rMuXnsGk6lHyz/jsT/rX5nIgwyqEYmI1ttnQQ0RTb/NMnVp3vo2DF1yBnKMi o/J4HocLow/+fBa9KcLE+HpMHbPTZSFamEjaJffT17/3JNzSiywRVePQrvt3sG7sS7Qd5r ioudxvgLtDyPlieeVhKgHZfeFEMtTn84yVYrCiTwnf27V9vggGAn0TuyDEd2voRCyTVonO +yCSONaZJPf8724TkphwMVAfmjxTVMhFOGopAjnvBsE5sKWBRqJ5ahfbj9HPUDrCGZ0g7q SZQH1f0VhthIzI7XA6v+1+Pz/t7HsLFArubjYRIdDvPLJ8vqPUnTvg0H3YaGUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTPx56KRzC0R for ; Tue, 25 Aug 2026 00:37:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3dc78 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:37:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Sasha Neftin From: Kevin Bowling Subject: git: a8a18e78e744 - stable/14 - e1000: improve NVM checksum handling List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a8a18e78e7445214a00bd40550b8e3d71760f510 Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:37:25 +0000 Message-Id: <6a8ce3c5.3dc78.767492c0@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=a8a18e78e7445214a00bd40550b8e3d71760f510 commit a8a18e78e7445214a00bd40550b8e3d71760f510 Author: Sasha Neftin AuthorDate: 2025-02-07 12:45:22 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:34:42 +0000 e1000: improve NVM checksum handling DPDK commit message net/e1000/base: improve NVM checksum handling When reading NVM checksum, we may encounter the following scenarios: - Checksum may be invalid, and can be updated - Checksum may be invalid but cannot be updated because NVM is read-only For the latter case, we should just ignore invalid checksum and not attempt to update it. Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Obtained from: DPDK (5241c17f0d) (cherry picked from commit 8e8755e011955d12abab7c2be324429cccf0b975) --- sys/dev/e1000/e1000_ich8lan.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/sys/dev/e1000/e1000_ich8lan.c b/sys/dev/e1000/e1000_ich8lan.c index d454b2ede3dc..1a67f4d8f42d 100644 --- a/sys/dev/e1000/e1000_ich8lan.c +++ b/sys/dev/e1000/e1000_ich8lan.c @@ -4436,13 +4436,20 @@ static s32 e1000_validate_nvm_checksum_ich8lan(struct e1000_hw *hw) return ret_val; if (!(data & valid_csum_mask)) { - data |= valid_csum_mask; - ret_val = hw->nvm.ops.write(hw, word, 1, &data); - if (ret_val) - return ret_val; - ret_val = hw->nvm.ops.update(hw); - if (ret_val) - return ret_val; + DEBUGOUT("NVM checksum valid bit not set\n"); + + if (hw->mac.type < e1000_pch_tgp) { + data |= valid_csum_mask; + ret_val = hw->nvm.ops.write(hw, word, 1, &data); + if (ret_val) + return ret_val; + ret_val = hw->nvm.ops.update(hw); + if (ret_val) + return ret_val; + } else if (hw->mac.type == e1000_pch_tgp) { + /* Transitional TGP images may omit the valid bit. */ + return E1000_SUCCESS; + } } return e1000_validate_nvm_checksum_generic(hw);