From nobody Tue Aug 25 00:37:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTPx2TWgz6pNRB for ; Tue, 25 Aug 2026 00:37:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTPw5qK7z4PHG for ; Tue, 25 Aug 2026 00:37:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jmpIQYsVtUbWdBI6e/pIDevvGb1a6NTJKfwL3sKIKEo=; b=Hh8OAnBXOdF8u3EhEhxmfxfyb+troKoSusk9d+YX8FlUvYBnjKmmjLAGFwXunjlPFoIEXE BxaDeD/3PFpt/hOn84ltKWJwHtWEAcIptXuwtGQ0sP5NT46XBdcaV78nd486I6X1SUic/A /7l0yR1Qqu+qe8jh3DTxnku8FBrlAPIOQvrp+e2FK9h7/l/Pd/x8dDDIpQohUj2WJoirRM mgJdGPADxq/Nq37tPS3gXNMR+89sG5F45YQiICvES7E0v44Hj3qx3+F/bEtLk2mGJL9vhn mfhVqhykz74ZchJoXmE8BJNg4ZrceLoORcKABT3lgye4QSPZ9JKlbjPdKGcyyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787618244; a=rsa-sha256; cv=none; b=c09enPH0Kt3gFE4raFDOZoVPhwqD2DxUWduQ8XDwsqSyIAKQKOVDKnEvD+2lpbyZ0dd0sy qnSy4gmvb0qtk3p3pFElkvG2PXjGXYR9aRo5vrxriz5jNQ4DqM4K7qK38rRyg1FSyy23r5 vpVoJ/zVJztZFPx+eOeM+ahzUVrBoahmYN3gqWf1UsfNpC52jnT7xd4DXQuNN2dXjVJxtr MFFdShYnNhQ4Kkof7z90vx/zludMY5WYowtaBa2l9trAY6Q+t6eBr17iUHWuvSFDtP7Con uTQJa5OuGZk3PB0DNheOAaKRbgxZhMbeUPz4TvyLguGZI/gqigB7T2EIdjjWRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787618244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jmpIQYsVtUbWdBI6e/pIDevvGb1a6NTJKfwL3sKIKEo=; b=efzwqD8kGGgJZx/KjVCX3xnG05by0S3McCQcp5iR4jaVp6bxYbudYQ5ghZUQzuI6Z3mkNL 3/nOUmIaNFNmASnbib17OZsG8WBXq8KZIZJ1FvMhVNoJKB3s7ORPa/r9wrADFpBacOMZZx pQiSwZQD9bzzCWQcm2c+j7nj4S0vNWk9LjXH4f2mvpjdCEO8QdCDVl5ZYL94A8tMVK3Cs6 z+1ins5YIdh8iF0JeHk6yUUCj87b5JDcJzzcK4WksSyJvp3KuyOQc8DY034ABkS/1zf90x Ir/BXN0oObUM2PaJW0zXdE1n+VRGhCaJW+OmRxau+/8fai9SYuyRU5suj89wGQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTPw4VtnzCKD for ; Tue, 25 Aug 2026 00:37:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40300 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:37:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Menachem Fogel From: Kevin Bowling Subject: git: 55005cc408bd - stable/14 - e1000: fix NVM loop bounds and pointer access List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 55005cc408bd7a65e68b8640ad813b272ae7907e Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:37:24 +0000 Message-Id: <6a8ce3c4.40300.1ea092cf@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=55005cc408bd7a65e68b8640ad813b272ae7907e commit 55005cc408bd7a65e68b8640ad813b272ae7907e Author: Menachem Fogel AuthorDate: 2026-05-20 12:52:44 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:34:28 +0000 e1000: fix NVM loop bounds and pointer access DPDK commit message net/e1000/base: fix NVM loop bounds and pointer access Improve the NVM checksum routines by ensuring loop bounds are compared at the correct integer width. Use array indexing instead of explicit pointer arithmetic. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Menachem Fogel Signed-off-by: Dima Ruinskiy Signed-off-by: Ciara Loftus Acked-by: Bruce Richardson Obtained from: DPDK (39fba42d04) (cherry picked from commit 0fc30789dff08d62c5c830e9aa8c5a0ca9080ad9) --- sys/dev/e1000/e1000_82575.c | 4 ++-- sys/dev/e1000/e1000_manage.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/e1000/e1000_82575.c b/sys/dev/e1000/e1000_82575.c index 47b8006314f8..d0aebbce74d8 100644 --- a/sys/dev/e1000/e1000_82575.c +++ b/sys/dev/e1000/e1000_82575.c @@ -2348,7 +2348,7 @@ s32 e1000_validate_nvm_checksum_with_offset(struct e1000_hw *hw, u16 offset) DEBUGFUNC("e1000_validate_nvm_checksum_with_offset"); - for (i = offset; i < ((NVM_CHECKSUM_REG + offset) + 1); i++) { + for (i = offset; i < (u16)((NVM_CHECKSUM_REG + offset) + 1); i++) { ret_val = hw->nvm.ops.read(hw, i, 1, &nvm_data); if (ret_val) { DEBUGOUT("NVM Read Error\n"); @@ -2385,7 +2385,7 @@ s32 e1000_update_nvm_checksum_with_offset(struct e1000_hw *hw, u16 offset) DEBUGFUNC("e1000_update_nvm_checksum_with_offset"); - for (i = offset; i < (NVM_CHECKSUM_REG + offset); i++) { + for (i = offset; i < (u16)(NVM_CHECKSUM_REG + offset); i++) { ret_val = hw->nvm.ops.read(hw, i, 1, &nvm_data); if (ret_val) { DEBUGOUT("NVM Read Error while updating checksum.\n"); diff --git a/sys/dev/e1000/e1000_manage.c b/sys/dev/e1000/e1000_manage.c index 96a7a3dde8a9..2cbf5af0af1a 100644 --- a/sys/dev/e1000/e1000_manage.c +++ b/sys/dev/e1000/e1000_manage.c @@ -159,7 +159,7 @@ bool e1000_enable_tx_pkt_filtering_generic(struct e1000_hw *hw) len = E1000_MNG_DHCP_COOKIE_LENGTH >> 2; offset = E1000_MNG_DHCP_COOKIE_OFFSET >> 2; for (i = 0; i < len; i++) - *(buffer + i) = E1000_READ_REG_ARRAY_DWORD(hw, E1000_HOST_IF, + buffer[i] = E1000_READ_REG_ARRAY_DWORD(hw, E1000_HOST_IF, offset + i); hdr_csum = hdr->checksum; hdr->checksum = 0; @@ -203,7 +203,7 @@ s32 e1000_mng_write_cmd_header_generic(struct e1000_hw *hw, /* Write the relevant command block into the ram area. */ for (i = 0; i < length; i++) { E1000_WRITE_REG_ARRAY_DWORD(hw, E1000_HOST_IF, i, - *((u32 *) hdr + i)); + ((u32 *)hdr)[i]); E1000_WRITE_FLUSH(hw); }