From nobody Tue Aug 25 00:31:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTTHF2fPZz6pMpd for ; Tue, 25 Aug 2026 00:31:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTTHF0G7Mz49cW for ; Tue, 25 Aug 2026 00:31:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787617897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=maJRc3rnRcPq2GcUfcy/PvysOUu/YnOflzz7MRGppCM=; b=C4eJe7860wp76BPvmv8rPp/XfUdU5Vd80y4cwJ1pZhn+fLjl2U/dC2LDY3iyMqq/++i9R1 /L/TirPfhU8oIxPJ7XvcAs9Yyw9rxorK1cyY0GwYVDSY7kAnp9hH4L2z60zl3oYkDZS8ar ZqRSR3Y1YBwvcVFHZJFe+yROe8NMyDOTBIkUi5+orIPH6ZCiAce6EI7+Zf2nfSJsm97vml tb3qfH/1XquSO4Pnw4T3Vox6OdHdn7IKOW+BaIPYJoAkoPJF4LsE+T/dOTbjVCvCeOR4KU 0hKoqRRUFgHbj/Udfhyu5PsvjsWLLpQPOF8PzzLqw9tw03R0YLNVsG/1ffHeDQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787617897; a=rsa-sha256; cv=none; b=Mh96Q5kXFL1NO8aGrwT1pPSWoWRtHSrWvaTnB9nfxs6AX3+LapxWGRkwMmX1K9py/Xoo7w ay0IdJk2+iP/YF9JzRGw1fhVraYZhEQq0/X8cEDUkhMWS25de86Q+lqCTgmK4g6Dvq53DA /9SguPs1HemqoGtLpinVc33qWLZhoqRqNbL1EiK0wbkmRJ2y+Gpv0uSje5nAKEJPPt5U3I OSZOy4CGu61czbBm+dMdqshw4ki3YEZQOUxhus4xoEHxNCTXpPyxPYk6wh8MlowiX9LJ1Q xT1dgVsidP0MdRjlaJAAMomItnC5muT7aQwPM6wI2sH531zGTjK5xKBpluXK7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787617897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=maJRc3rnRcPq2GcUfcy/PvysOUu/YnOflzz7MRGppCM=; b=V8+sEXXqkPiS6vgctlJE43afwjzCc1jAwjvzpf+uEt6lxZtgzOmP7ydaYdoQ1ftT0WGKDb s4ywNVJanBhIHS0N+IFVwhWcB6FzknV/VbpfE+yR0Is0C0x+KLmB26IUI3RKdlK/vHh1Ye 3qn3cVDqfBm4aJ0N8z2CurtjjWYjSh/mT5iFppPT+Jbl6/4h0FERkeHOaDGS61zAv46UqX 7/pSZ4VjBzvCt6ThDs9uznUKqSivXuK2k+98Cr7aQm5hepv8V3XPEjUlUdViJ7xqKnb7pg Mcn9NfRT3kGrmYwI/irzhujMzhewBN71dQ+B27JOpd/Gv5LrfpW0BOcTezUtAw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hTTHD6MCSzC2C for ; Tue, 25 Aug 2026 00:31:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e6af by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Aug 2026 00:31:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: f86489cec3da - stable/15 - e1000: Verify i210 and i211 multicast table writes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: f86489cec3da08c753fa6c75be3749fe5bffb5ae Auto-Submitted: auto-generated Date: Tue, 25 Aug 2026 00:31:36 +0000 Message-Id: <6a8ce268.3e6af.211dcfc@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f86489cec3da08c753fa6c75be3749fe5bffb5ae commit f86489cec3da08c753fa6c75be3749fe5bffb5ae Author: Kevin Bowling AuthorDate: 2026-08-11 17:35:43 +0000 Commit: Kevin Bowling CommitDate: 2026-08-25 00:27:43 +0000 e1000: Verify i210 and i211 multicast table writes The i210 and i211 can occasionally fail to accept multicast table writes, particularly while addresses are added and removed rapidly. Read the table back and rewrite mismatches for up to three passes. This prevents multicast reception from retaining stale filter state while keeping the workaround limited to the affected controllers. (cherry picked from commit bb8d0944b5d53863f00492b69b7bf13d2618fc95) --- sys/dev/e1000/e1000_mac.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/sys/dev/e1000/e1000_mac.c b/sys/dev/e1000/e1000_mac.c index 46e91773c126..f311df658d78 100644 --- a/sys/dev/e1000/e1000_mac.c +++ b/sys/dev/e1000/e1000_mac.c @@ -584,6 +584,37 @@ u32 e1000_hash_mc_addr_generic(struct e1000_hw *hw, u8 *mc_addr) return hash_value; } +/** + * e1000_i21x_check_mta - Verify MTA writes on i210 and i211 + * @hw: pointer to the HW structure + * + * The i210 and i211 can occasionally fail to accept MTA writes. Read the + * table back and rewrite mismatched entries, with a bounded retry count. + **/ +static void +e1000_i21x_check_mta(struct e1000_hw *hw) +{ + bool failed; + int i, retries = 3; + + do { + failed = false; + for (i = hw->mac.mta_reg_count - 1; i >= 0; i--) { + if (E1000_READ_REG_ARRAY(hw, E1000_MTA, i) == + hw->mac.mta_shadow[i]) + continue; + failed = true; + E1000_WRITE_REG_ARRAY(hw, E1000_MTA, i, + hw->mac.mta_shadow[i]); + E1000_WRITE_FLUSH(hw); + } + if (failed && --retries == 0) { + DEBUGOUT("Failed to update MTA after retries\n"); + break; + } + } while (failed); +} + /** * e1000_update_mc_addr_list_generic - Update Multicast addresses * @hw: pointer to the HW structure @@ -619,6 +650,8 @@ void e1000_update_mc_addr_list_generic(struct e1000_hw *hw, for (i = hw->mac.mta_reg_count - 1; i >= 0; i--) E1000_WRITE_REG_ARRAY(hw, E1000_MTA, i, hw->mac.mta_shadow[i]); E1000_WRITE_FLUSH(hw); + if (hw->mac.type == e1000_i210 || hw->mac.type == e1000_i211) + e1000_i21x_check_mta(hw); } /**