From nobody Mon Aug 24 14:22:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hTCmY2tTPz6pSd7; Mon, 24 Aug 2026 14:22:37 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hTCmY2H4Lz3fcr; Mon, 24 Aug 2026 14:22:37 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787581357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0R6EoylAvSVpJK1tu3vVm/hYgytzlLL4NayKOeoBBC4=; b=jRwDn23DBRZuSVrCfmn83vAdWvEk5Vi7dtl4u6eIm4WIWGIcNBvGCScmvHuwh48VHMOZgY YpjBXAAlrwqW75iWypjA1tc4cSBlank/P53ID3WWT0OzFSrMee3A4XGzs8J1t3KF3tMfHu DK6tvSLoRH1akyYuazpBKhG8pdmwqECdug4kgf2OErnUCjXZjnKK7phG++X67oM1LM7xVz qObfAZZi1gUId94yGqQZDJhSoL+thZtVfW6Gz952mNrXekeNi8pzMQTVyrrBJxJwe2YKaY Ih3dAS9wD0krZXNLgLshAstlSStJ6HEU1ums8elhn4PAFu4UjoRUzkmwiCEIlw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787581357; a=rsa-sha256; cv=none; b=VmviEmAbS1aahml91VvPr8OrinA/KJx4fDQrEPH6+FCcCFO6oVl/44FF5ZxjviXsojQsKz tn/0oomlBuR2YPOcsiT1AfmvWXNp1neJFx+oiQbOk5B4tf6qBk+l5V423VBb+9s9hh7yWI bkVdhz0yWpboAk1knD6+M+lU9+g2il4L2Ms3g0bFOw2w3E8IRhZnif2Tde0xQ4qJXdFB9w N4D3BcnJ9PLuRU0Q6/8QTGJfN3ybCvMHpiC8i7XQlgfkXrnn7lXu4XmMcXOOV/2+e9/0ts /QHuIEknC6hXVFqQMKc6e0/GVxaw3Ef739JankjBt0qJfqIlZfnwiyQq+evzqw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787581357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0R6EoylAvSVpJK1tu3vVm/hYgytzlLL4NayKOeoBBC4=; b=QQWYibIiLAlEe7XMqmVHvc092bwMWJOkeL2TxQ94cVR4ifJDxHD1ATlRxGjUKBcroZQsl3 Ff9sU+QI4H5xZNCpt631p5LlHoABvZIMHQpTzNARzwIphpgX44N2IkhlS0OW12lYI2QpIU X4JehfwGerr0XExqH1qei0zXSwzwWeTv3uyWbhEAq6AtmoRGccoqBprJOB1px2xM91etJu 82IpEYLbyQ4agXIeuSip9bp4ehky3vgM09LVBgazzGJFX83IYXbHbhbloxf7Wwu4M9dDfy r7l8/a0zH60MncS3oeQZNwWewG3uJ8aAKVku09TTS5GROOuov8fQ6QUThi2pVA== Received: from ltc.des.dev (2a01cb0585070b00922e16fffef1acef.ipv6.abo.wanadoo.fr [IPv6:2a01:cb05:8507:b00:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hTCmY0C3fzFTT; Mon, 24 Aug 2026 14:22:37 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id CD9A5F864E; Mon, 24 Aug 2026 16:22:35 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Warner Losh Cc: Faraz Vahedi , src-committers , "" , "" Subject: Re: git: 8d29d2429649 - main - libc: Restore prior C23 include guards In-Reply-To: (Warner Losh's message of "Mon, 24 Aug 2026 08:11:47 -0600") References: <6a85843a.3287f.2aec5cf8@gitrepo.freebsd.org> <865x0z6526.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 24 Aug 2026 16:22:35 +0200 Message-ID: <86wltf4mz8.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Warner Losh writes: > Dag-Erling Sm=C3=B8rgrav writes: > > Shouldn't these be conditional on the visibility macros? > Seems fine to me since it's in the implementation namespace. Maybe > you could share your reasoning. Imagine a library which is is written to be backward compatible with C99 but offers additional functionality which requires a C23 compiler and uses one of these __STDC_VERSION_* macros to control its visibility in the header. An application written in C99 uses this library and builds with -std=3Dc99. Because we set __STDC_VERSION_* unconditionally, the library now exposes C23-only code to the C99 program, which therefore fails to build. Therefore, these macros should only be defined if __BSD_VISIBLE || __ISO_C_VISIBLE >=3D 2023. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org