From nobody Mon Aug 24 09:14:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hT4wy4Zzsz6p6Gh for ; Mon, 24 Aug 2026 09:14:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hT4wy2DbJz3w1t for ; Mon, 24 Aug 2026 09:14:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787562866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YqPkjK9JSt2Pqvdtom9YM13qBrk8HVwFr2H//pXmZRU=; b=urF83qfWa0sT9He8FV3HVew48guM8vbsPG7eRYKayZmUTHGvniJiJ7Owd1UEjopMMd7vOA nsOYQdxHyU3QjF945nV6ijekGEkJPSlKU6C8seBPJTvH/UmNarcuBm/koQUpZrp1IyiUAR 2+WU+rQH+fV0pihfg1nZnNY9tPFGMN+hQHhb1Uym39H7GTIMUicL26FvCYKoXtAzdckA6Z 4vVxBNG1y/BYilhB53Nn9Exa4TKTj0ZuXY9tV9IoQi3BGJSbKXl50u8VFDtXjp8LQOwR+v H+XCUOrrA7c2rEPfQqeZz9bTJ1f52oCHzVGNpXVCJ0A/RPtU/ActpaBLGT00wQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787562866; a=rsa-sha256; cv=none; b=Pql/I3j6prqIlle69H6BvrSZO01N+ud7DqgkNR+3ULaXX3E2TJlS8kvlBwoVlVN4dP4E2Q Lrrr1lr/N4g8Cofemzz4q5gJpjG3qgbjJ/VXXe6HgZZmGFWF+15vDdnqoj8rUHSBzDcMTA feEg+1O/XKw4GbTG1jHMK5krBKOF0yOA+qVsLQ46MaJx6wFFtWoR273JqNl1reuRYbKmQI pXpDCqAkwxKoHloGIE+ALD6NyNJ7eZf/zZ1d4yntPnkUgNBY7Ns3/25sJGcNZuuAW+zp+n pnUhcPImlZnnUQw9R9w1gdxWuIQgyQ3sijkJ0gKjHq3jCGa/HGKETLe/rqr3NA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787562866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YqPkjK9JSt2Pqvdtom9YM13qBrk8HVwFr2H//pXmZRU=; b=aQWbxHZElXn0O9o/Iolum4DAhhgaJTrVOzLcSaqQwHFBGDDK+tV+lvMxS6ys9nlTsTzXzU ftthHSdKBlOGY9a8cZSbA1yaHuO7CalGWL051AYU7/2BgrT2ehyDwE8thQRfMI8i6znmJV 8+VMNQbIJuoVviVgnXL+ByiCjbqMYmd+6cBE4xxpDVqOPUDmBEFbiAkFckrw7+u85CQvYh zT5nWSAMAPjny5Y0Qmee57f67QfNWQ+ONbOhu84WZ/FY0o2UfWG2WWZrBmawJw82N+ao6w /IMWPKNKVIn/SmWECE7AsKCxBrJpusWVtF2JRcCH8eaB+6cQSr/vZNik76el1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hT4wy0ksQzyR8 for ; Mon, 24 Aug 2026 09:14:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 196e8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Aug 2026 09:14:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 1c6690a9b5ea - stable/14 - ixgbe: Compare flow control against requested mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1c6690a9b5eaedb4f8fd5bea3fda70bb5455b21a Auto-Submitted: auto-generated Date: Mon, 24 Aug 2026 09:14:26 +0000 Message-Id: <6a8c0b72.196e8.59d133b4@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=1c6690a9b5eaedb4f8fd5bea3fda70bb5455b21a commit 1c6690a9b5eaedb4f8fd5bea3fda70bb5455b21a Author: Kevin Bowling AuthorDate: 2026-08-10 15:09:56 +0000 Commit: Kevin Bowling CommitDate: 2026-08-24 09:12:22 +0000 ixgbe: Compare flow control against requested mode The flow-control sysctl represents the configured policy, while current_mode is the mode negotiated with the link partner. Comparing a new request with current_mode can needlessly reprogram an unchanged policy or skip a requested policy change that happens to match the current negotiation result. Compare with requested_mode before deciding that no update is needed. (cherry picked from commit c410551b9feadf9b65f920fd25714fcda8299a56) --- sys/dev/ixgbe/if_ix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 8c3bb0c790af..b67d18a2c41d 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -5254,7 +5254,7 @@ ixgbe_sysctl_flowcntl(SYSCTL_HANDLER_ARGS) /* Serialize the live register update with the administrative task. */ ctx_lock = iflib_ctx_lock_get(sc->ctx); sx_xlock(ctx_lock); - if (fc == sc->hw.fc.current_mode) + if (fc == sc->hw.fc.requested_mode) error = 0; else error = ixgbe_set_flowcntl(sc, fc);