git: b92d13ab60dc - stable/14 - pfsync: handle large MTU pfsync interfaces

From: Kristof Provost <kp_at_FreeBSD.org>
Date: Mon, 24 Aug 2026 07:27:00 UTC
The branch stable/14 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=b92d13ab60dc0eb929e66edddf6f389e5b56e50d

commit b92d13ab60dc0eb929e66edddf6f389e5b56e50d
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2026-08-07 14:07:09 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2026-08-24 07:17:33 +0000

    pfsync: handle large MTU pfsync interfaces
    
    pfsync packets were allocated with m_get2(), which can't return packets
    larger than MJUMPAGESIZE. As a result 9k MTU pfsync interfaces simply didn't work.
    
    Use m_get3(), which can allocate sufficiently large mbufs.
    
    Extend the pfsync:bulk test case to provoke this problem.
    
    PR:             297307
    MFC after:      2 weeks
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit 7e2781fdcfdbe489cc07572d33dc36bca06a342d)
---
 sys/netpfil/pf/if_pfsync.c     |  2 +-
 tests/sys/netpfil/pf/pfsync.sh | 11 ++++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c
index 4d83962abc74..1868bf35fa76 100644
--- a/sys/netpfil/pf/if_pfsync.c
+++ b/sys/netpfil/pf/if_pfsync.c
@@ -1830,7 +1830,7 @@ pfsync_sendout(int schedswi, int c)
 		return;
 	}
 
-	m = m_get2(max_linkhdr + b->b_len, M_NOWAIT, MT_DATA, M_PKTHDR);
+	m = m_get3(max_linkhdr + b->b_len, M_NOWAIT, MT_DATA, M_PKTHDR);
 	if (m == NULL) {
 		if_inc_counter(sc->sc_ifp, IFCOUNTER_OERRORS, 1);
 		V_pfsyncstats.pfsyncs_onomem++;
diff --git a/tests/sys/netpfil/pf/pfsync.sh b/tests/sys/netpfil/pf/pfsync.sh
index 01d76e23889c..b87621204ff7 100644
--- a/tests/sys/netpfil/pf/pfsync.sh
+++ b/tests/sys/netpfil/pf/pfsync.sh
@@ -203,13 +203,14 @@ bulk_body()
 
 	# pfsync interface
 	jexec one ifconfig ${epair_sync}a 192.0.2.1/24 up
+	jexec one ifconfig ${epair_sync}a mtu 9000
 	jexec one ifconfig ${epair_one}a 198.51.100.1/24 up
 	jexec one ifconfig pfsync0 \
 		syncdev ${epair_sync}a \
-		maxupd 1\
-		up
+		up mtu 9000
 	jexec two ifconfig ${epair_two}a 198.51.100.2/24 up
 	jexec two ifconfig ${epair_sync}b 192.0.2.2/24 up
+	jexec two ifconfig ${epair_sync}b mtu 9000
 
 	# Enable pf
 	jexec one pfctl -e
@@ -223,7 +224,11 @@ bulk_body()
 
 	ifconfig ${epair_one}b 198.51.100.254/24 up
 
-	# Create state prior to setting up pfsync
+	# Create states prior to setting up pfsync
+	${common_dir}/pft_synflood.py \
+		--sendif ${epair_one}b \
+		--to 198.51.100.1 \
+		--count 2500
 	ping -c 1 -S 198.51.100.254 198.51.100.1
 
 	# Wait before setting up pfsync on two, so we don't accidentally catch