From nobody Mon Aug 24 00:58:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hSswz1rZmz6q2Wl for ; Mon, 24 Aug 2026 00:58:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hSswy3c91z46GR for ; Mon, 24 Aug 2026 00:58:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787533122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v6N7eBJOC6uK/OYEonIeAO8F8r8ajgBnCxSRjOLlhUc=; b=hvRWbDoeGh8CSIdD1L9bcesWyiB3pTeOWaS4T3lAF7aEwC1YRvxeDEfEmchTq9pePOPc14 iJbim8HmcmAmik1Ogx+Pg6DqVgZhDAWFnji7eJsoW1LnVGyDLPwvSiuZ6KnbDcJ5Rpx0Ss JIi8C7eZWNFeGAeHaz5McCSwud9ul1qbJRemev2BfRYH69k9Q6tXSuNm50j1+IwrCm6JyL FF2yoQm3YoJaQymuYfwC2CinY9jCMRR2b6Wgx54688t1mCNvrnqK4tgMh/dU7YE2TzUTpM yNZA0UYkwGZy5mDPrl5T+ePoKEec90LDwhxhq9JizlkQJbz6D8mIXDVkKmg29A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787533122; a=rsa-sha256; cv=none; b=uShg0LWWfA31+lD/svXTH0rxp/Zh1TLjEQJoAuADLdwaR3SvCA4TTJZUIP2RUZbaMu9QCU g3WZikLgoBULc/464IAcVOgECVrQ9m7XIblwiYDSzoKNFTMo/UAsb5zbzjTIPdTL7d1uV6 kjpWZ87bgFdiVo425JFv6CwboEi+PWuIfOHqdrqpSeefInIx7SlV1HB1kyLta/HazP5ZFb xGt0Gaa4SGy+Wb5TcvA3q3CsZSYZcp8RrS2waF2mD3CB2YFBV0p7BUABelOScgM+aV4Lkg UsWjZYO5OU9ONrZ2DJNCDtxVYg47yZt1USuqMjOQepPw4bTlwteLTTdufYvv+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787533122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v6N7eBJOC6uK/OYEonIeAO8F8r8ajgBnCxSRjOLlhUc=; b=dfMusEk6607Jjjzg0vacG/Ua4+NQecOT5Qw7BWAoQTyQwHvP+yQ2i//dhUY6jSPznjy1GX 1JJecIJ1rmSRzCoY4Q2k4lkG91jccsTQDfRtnpO2VWDDklBb3YX0FWf4Q7B2nD/r7sMYqu 4k3bJ8vrhFOy9pGKXwQAzZk2lYHKzHL6l8qB0uFxOAxYRLKwklPlVoXzaTcKkI9HyxH17F BIQ4KCZXqXO4VUQa9vncpLPI5HpE0fFBUynHx2UkUVGLk5OaU4sDskcGHU7NZoLiQ9MRsj EvQZjzrh7GIH9FAnFrTWf1xjAMl0JHvs+ZBVCfw3CdzopMKGXf2IhqP8d/wqpg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hSswy2b7xzj8h for ; Mon, 24 Aug 2026 00:58:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32b22 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Aug 2026 00:58:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 78f5c8efef89 - stable/14 - iavf: Honor iflib transmit completion batching List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 78f5c8efef89c8927f5e9a67197d86d5bb6ca076 Auto-Submitted: auto-generated Date: Mon, 24 Aug 2026 00:58:42 +0000 Message-Id: <6a8b9742.32b22.55d341b6@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=78f5c8efef89c8927f5e9a67197d86d5bb6ca076 commit 78f5c8efef89c8927f5e9a67197d86d5bb6ca076 Author: Kevin Bowling AuthorDate: 2026-08-10 07:31:56 +0000 Commit: Kevin Bowling CommitDate: 2026-08-24 00:56:35 +0000 iavf: Honor iflib transmit completion batching iavf uses descriptor writeback by default. Hardware writes completion status into a transmit descriptor only when it completes a descriptor marked RS. iavf marked every packet RS even though its report-status queue recorded and inspected only descriptors selected by iflib. The other completion writes could not help reclaim descriptors. iflib marks selected packets with IPI_TX_INTR as completion checkpoints. It forces a checkpoint as deferred work or ring pressure grows. Retain EOP on every packet, but set RS only at those checkpoints. The deprecated head-writeback option on 700-series VFs gets the same batching: each RS checkpoint permits hardware to publish the completed ring head. DPDK uses the same sparse RS design. Let iflib choose the adaptive interval for FreeBSD. This is a PCIe/memory bandwidth savings. (cherry picked from commit 8eb4403e9d4a35f33a0ce41067ccb1924c6960dd) --- sys/dev/iavf/iavf_txrx_iflib.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/dev/iavf/iavf_txrx_iflib.c b/sys/dev/iavf/iavf_txrx_iflib.c index 4707421748bc..991238b73e7a 100644 --- a/sys/dev/iavf/iavf_txrx_iflib.c +++ b/sys/dev/iavf/iavf_txrx_iflib.c @@ -304,8 +304,6 @@ iavf_tso_setup(struct tx_ring *txr, if_pkt_info_t pi) return ((idx + 1) & (scctx->isc_ntxd[0]-1)); } -#define IAVF_TXD_CMD (IAVF_TX_DESC_CMD_EOP | IAVF_TX_DESC_CMD_RS) - /** * iavf_isc_txd_encap - Encapsulate a Tx packet into descriptors * @arg: void pointer to the VSI structure @@ -327,7 +325,7 @@ iavf_isc_txd_encap(void *arg, if_pkt_info_t pi) bus_dma_segment_t *segs = pi->ipi_segs; struct iavf_tx_desc *txd = NULL; int i, j, mask, pidx_last; - u32 cmd, off, tx_intr; + u32 cmd, off, tx_intr, txd_cmd; if (__predict_false(pi->ipi_len < IAVF_MIN_FRAME)) { que->pkt_too_small++; @@ -338,6 +336,9 @@ iavf_isc_txd_encap(void *arg, if_pkt_info_t pi) i = pi->ipi_pidx; tx_intr = (pi->ipi_flags & IPI_TX_INTR); + txd_cmd = IAVF_TX_DESC_CMD_EOP; + if (tx_intr) + txd_cmd |= IAVF_TX_DESC_CMD_RS; /* Set up the TSO/CSUM offload */ if (pi->ipi_csum_flags & CSUM_OFFLOAD) { @@ -384,7 +385,7 @@ iavf_isc_txd_encap(void *arg, if_pkt_info_t pi) } /* Set the last descriptor for report */ txd->cmd_type_offset_bsz |= - htole64(((u64)IAVF_TXD_CMD << IAVF_TXD_QW1_CMD_SHIFT)); + htole64((u64)txd_cmd << IAVF_TXD_QW1_CMD_SHIFT); /* Add to report status array (if using TX interrupts) */ if (!vsi->enable_head_writeback && tx_intr) { txr->tx_rsq[txr->tx_rs_pidx] = pidx_last;