From nobody Mon Aug 24 00:53:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hSsqJ44q6z6q2SF for ; Mon, 24 Aug 2026 00:53:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hSsqJ0Prlz3vyy for ; Mon, 24 Aug 2026 00:53:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787532828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yzv7nCyEgZ/RgdLomaoS1e7yjKW7d4pL7qa7dbmwrnc=; b=GTfxRBHdRhiI+KYwyFiSxlIzpwQZH7puvbeb1tvgh0xAt4Bf1isQ2/iYbb+xv5ehTAy6rC untJcEqoTBFhsWRteie2iIJ3AFMt9CTBc0RRzRMhkpkSCXevkP7BQvFh1xdUYdQVturll8 BW4XjzRqCNAodzX5OF9VX2u8TSZHYBOMkcPjai60NnKV9hJBt5OWoTjJG+howQQtanJ4M5 G9loU/QNrwOTM+QE5Cw/ilYDQAYszf8h397xUnhXgBHS2YG8A2sS3RsEMwq2A5f4yIeSch XjdVxForTwWg1LQVkiB+tTS3Zwcihm/fduQRYA9miRytsr4cU3vpcDXi15mjqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787532828; a=rsa-sha256; cv=none; b=KjDwwahlkoKe95TzFFeK+zQEfqSiQQM7qZTrCn6iTj66YohVq47SCG6FIs92f14MQz5MoB a538drCSIunFI4K4Wh4E431/F9ZVZv5BurgPaSHbMjozX3OTOpAiQc9UAIuYCWziMzsF/R o0KTp6jeh6BpUAo38QvNcQqgDlhMzTfTwLQT0GK7D4X9pW7XO+Q7MnE5PHtt+QOcsdu7SB WKyRz1nNbKM9gMjY54H9u+aw7e5HZh7vzweSMDeUrFXP/MzWKN4r87RndWmlYv6EPIzoBa 9ABs7abnlkxMCIJNUeEP8u/WYWm6EuBZcCIQ1GBeJJNB/WAvc5+WBiwgy37L0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787532828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yzv7nCyEgZ/RgdLomaoS1e7yjKW7d4pL7qa7dbmwrnc=; b=hOmQNWoc39WekREVTcjo2TVIcxenMwiwMohFNHheCffwGZvgaelqkRipHXfdj/LMjkMa3Q 0+0StwajeEuswSd1NtBgGqS1W5f+6ZEnH+B4HbMNd4/XAKYjpQcRFmKQxj6PHYPakeazP5 OdB5ntvkM7zfiq6Y6gjmJEY5qTuUgtnGTDjJf1v4W1Zn9F8DcTYw32NVEM9lk2PNS22Sj6 eVaIieRKmWpx2KeO/iLBaFjisjbm9ixqK7HdEjOmKXlvwHEFKTkoFuLQHl3wcQrKKS1hLl r15/QW2F9wXC+cbKGA+ez53W3r1Eqcof9Gc/wY3PV6fl39+ovk6bIGXoijOvOQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hSsqH5qs1zjNW for ; Mon, 24 Aug 2026 00:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32ca4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Aug 2026 00:53:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: c8d38edfa266 - stable/15 - ixgbe: Compare flow control against requested mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c8d38edfa266266a2ad20595c248124b3c4e138d Auto-Submitted: auto-generated Date: Mon, 24 Aug 2026 00:53:47 +0000 Message-Id: <6a8b961b.32ca4.61e7224a@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c8d38edfa266266a2ad20595c248124b3c4e138d commit c8d38edfa266266a2ad20595c248124b3c4e138d Author: Kevin Bowling AuthorDate: 2026-08-10 15:09:56 +0000 Commit: Kevin Bowling CommitDate: 2026-08-24 00:51:15 +0000 ixgbe: Compare flow control against requested mode The flow-control sysctl represents the configured policy, while current_mode is the mode negotiated with the link partner. Comparing a new request with current_mode can needlessly reprogram an unchanged policy or skip a requested policy change that happens to match the current negotiation result. Compare with requested_mode before deciding that no update is needed. (cherry picked from commit c410551b9feadf9b65f920fd25714fcda8299a56) --- sys/dev/ixgbe/if_ix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 8c3bb0c790af..b67d18a2c41d 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -5254,7 +5254,7 @@ ixgbe_sysctl_flowcntl(SYSCTL_HANDLER_ARGS) /* Serialize the live register update with the administrative task. */ ctx_lock = iflib_ctx_lock_get(sc->ctx); sx_xlock(ctx_lock); - if (fc == sc->hw.fc.current_mode) + if (fc == sc->hw.fc.requested_mode) error = 0; else error = ixgbe_set_flowcntl(sc, fc);