From nobody Fri Aug 21 21:41:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hRYfp6KGgz6pbv8 for ; Fri, 21 Aug 2026 21:41:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hRYfp5lzTz3rDM for ; Fri, 21 Aug 2026 21:41:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787348514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cs4n486PfrFj4co4/CDvsBRXQRv6Hma3pZtb9zwxRWw=; b=bqJkqQILPDk9x2R0gOa5izO00XjGRtTzK4XZH6AvMUl7OeWeE3DsJ3KGW3IziebqUkoP0w uJdqGUGKmRSmfJUUjf5DL4dSH/9gWhibPi/Jt9Mm+qGKZk9moXBB/Le6SqF0caa0jM99lS qyGAKonm6bb06jzgwSCIKqrQsPnHM6D4tNR1KhXIXQmykZ/LQjBNvaSrj4B7VYhzOJM7FR R3CYp9VfD+kW6nwDDUzbFZQdsQYAoi1sv3EVevD1RrZ/pnX0bHhZY/dCVjDV/2DZtqVOiN RAY1kl0JLLy//XSxW/RMo5XlH+Wz6GQNqSrZu5glEr3qBaZkE1hhNScCmmYgGw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787348514; a=rsa-sha256; cv=none; b=Deqs1bksfer1ypUC7Hd7pfctmfk47ueteUvq6ausHm4InSgQRwcPRYqDAbR7TaAQauRKiZ 5IQCH5Qs1OvHxKok8bSfkknpDQp8NGZ3KVQnQ2+nUcc2XW4poOmgTmnju/gk7z4aA7VziV WeFa6CKcG9g+msRTVj1L6F9Bff6Rj9kPAkekT+pqUimF0cb25z3SejGAAzV6IjaaUult/F HbRnpJLJsekn/jrk9SqzLIxxkqZICq+uPd29XFm9N1xr1YK6pkWCR0DilUka1ooW+iXipj CEVL6jLK+leTBPSkIMxD2v+q07XAvxbNkxW4Z0V1EPYJtvGpFfBoRvLR4N8ppw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787348514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cs4n486PfrFj4co4/CDvsBRXQRv6Hma3pZtb9zwxRWw=; b=yTeC6pjJzmiIvp034mIQpCpvqEDo2YItv1rYib15ViZEssOQexwSkWqvpZgXD+gT+j7AKJ r/Bm2bAPbrAYI4KMtWCieBP5/FjYiMKq627G8nT1y7SCtdxdio4eSu/BdnKNi/iu9JtBtI yuLSsfGhb30hUo73Cf0R7GgTWbVXrQxwLyS9QW2dp+h8ngKRe5S9GlKZyrHWXxUvyWJZQr g22PDxErbsste924wgYiKGZJOH8zyYYZ5nHOPDS+rxZgpbx0C/cUHBSlo8+eaxdF/AxqBA lc9/S7wP4psj+GYpKytF+mxCkpNPsL690vwCAIubYsZuntJFAM3RInr/Hhj4lA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hRYfp4Vbfz5tH for ; Fri, 21 Aug 2026 21:41:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4044d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Aug 2026 21:41:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 82a3337952b9 - main - pmc: Use isascii(3) to check if a character is ASCII List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 82a3337952b922c48c55d1359ab0472f1d116c7a Auto-Submitted: auto-generated Date: Fri, 21 Aug 2026 21:41:54 +0000 Message-Id: <6a88c622.4044d.6ee55748@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=82a3337952b922c48c55d1359ab0472f1d116c7a commit 82a3337952b922c48c55d1359ab0472f1d116c7a Author: John Baldwin AuthorDate: 2026-08-21 20:19:56 +0000 Commit: John Baldwin CommitDate: 2026-08-21 20:56:05 +0000 pmc: Use isascii(3) to check if a character is ASCII The previous check did not work on architectures where `char` is unsigned as noted by GCC on aarch64: usr.sbin/pmc/view.cc: In member function 'void pmcview::loadsymboltable(image*, Elf*, Elf_Scn*, GElf_Shdr*)': usr.sbin/pmc/view.cc:627:38: error: comparison is always false due to limited range of data type [-Werror=type-limits] 627 | if (fname[i] < 0) { | ~~~~~~~~~^~~ Reported by: GCC 15 --- usr.sbin/pmc/view.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/pmc/view.cc b/usr.sbin/pmc/view.cc index a678c061d490..f3585ac75043 100644 --- a/usr.sbin/pmc/view.cc +++ b/usr.sbin/pmc/view.cc @@ -624,7 +624,7 @@ pmcview::loadsymboltable(image *im, Elf *e, Elf_Scn *scn, GElf_Shdr *sh) // XXX: Extra checks to make sure we don't get corrupted for (int i = 0; fname[i] != 0 && i < 32; i++) { - if (fname[i] < 0) { + if (!isascii(fname[i])) { printf("EEEK SYMBOL\n"); printf("%s\n", fname); assert(false);