From nobody Fri Aug 21 19:15:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hRVPx2p6Fz6pPZf for ; Fri, 21 Aug 2026 19:15:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hRVPw5NBVz3Td0 for ; Fri, 21 Aug 2026 19:15:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787339732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fu4PJOxoNgqsXWzsxRcZ1nNx10QhXa4JuclVFNdq1IY=; b=IPLKkGtxntySOzs82U70QxbT2vZ0aAWwX84Q+mAgr0wFwawFlOXKm+zq+esgYmmXwcVbBI ddLhV0EqeXdUOK71emCBqGwi31d1zaxq3fe7QqH+HslvE6vG7BjgYTRhX9CI3ild9Guptw Z7sP880MtNZqgXXLkzYwRXsINdlGIMQlDXkMRsPjoPYEadpuQi3shlFXWH/qibdVTmKr13 KxNiCJ+4KCp35KYikNwYa47WltKY7S16Z8omj739ni5C8aIvymu/I0AUlVOvVgQeJ2ZsH6 TlG1ADRDhCpswNh0uUJGIP94wqyuVXQLlzJ+3yZ/yFtwnvw88m4CXlP68QfCpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787339732; a=rsa-sha256; cv=none; b=wGmIkkDQlFS2cMjaCrl6ZsOHwu/jcoOj6kBsXfTNYehab3CHRcB2RPIeg8MnD8eqWdoues DB+hl0LHWf3Teh0ULbHsA/YtifAiSLIx1HPLyeP+j3hh7LX0YXwSPcTuNjj5+2Mggr1fvj 6VG0zuUhaaF3ZtnrLXxPPHP2qlCzwt7rFryAH95J6t1OsamDCcc7K5rBN9x/xVoQcZGY8s ZobdcpKSiiCUQq+7/H5wYWJ3uJpVhUEUFBGVFjGWFO4ak+xN4hsgB4kHQ5vgOi76Q3GiIM eqj7bp9wRHsAzuBTFb9QsI3oFWQvCJ/NP2b3oj1QDdvqYAr3RZ6l03U7dhXWpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787339732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Fu4PJOxoNgqsXWzsxRcZ1nNx10QhXa4JuclVFNdq1IY=; b=hwpO+PzvnRcyVHDNhpfTje3fwfoBs3wIsvVedxqwQkq1MD1qiET70p4tq84S0ewubR0MWx qJt0VkcSbZtf+Z3Bpa6neisfL7UP0mwbIACoNY4MYu3UUJPs20Cyx+JevIuAUVa6cteh8x MXvtgrhAX9X73aZAn/A0UV2+8RlPlmtfxynnIP3vTWhfqz2e1nXEfH/2c4tvCjA8A1zovc SHz566Igq8z27L+pJx5/WMd7NxmY2Pyj6cGxR+cfJmE1iqYTePERI4MyrtTKmZNSN8WG7j 9OD0EcTvz5rUtljFV1yWhQC3ExPXcHOyZoVLYIC7qZMErxfgF7Ma66sfvexSeQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hRVPt74JPz1nX for ; Fri, 21 Aug 2026 19:15:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32eb0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Aug 2026 19:15:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jose Luis Duran Subject: git: 2916ae647303 - main - makefs: Fix atime tests on MS-DOS (FAT) file systems List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2916ae647303e3bd92e533002a8e6c476417fe7f Auto-Submitted: auto-generated Date: Fri, 21 Aug 2026 19:15:25 +0000 Message-Id: <6a88a3cd.32eb0.38a5be96@gitrepo.freebsd.org> The branch main has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=2916ae647303e3bd92e533002a8e6c476417fe7f commit 2916ae647303e3bd92e533002a8e6c476417fe7f Author: Jose Luis Duran AuthorDate: 2026-08-21 19:14:03 +0000 Commit: Jose Luis Duran CommitDate: 2026-08-21 19:14:03 +0000 makefs: Fix atime tests on MS-DOS (FAT) file systems On FAT file systems, access time has a resolution of 1 day, so it is really the access date. Strip the time component from the epoch timestamp in order to check the access time. Reference: https://learn.microsoft.com/en-us/windows/win32/sysinfo/file-times Reviewed by: ngie MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54584 --- usr.sbin/makefs/tests/makefs_msdos_tests.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/usr.sbin/makefs/tests/makefs_msdos_tests.sh b/usr.sbin/makefs/tests/makefs_msdos_tests.sh index f800bbcd6925..3abf17528559 100644 --- a/usr.sbin/makefs/tests/makefs_msdos_tests.sh +++ b/usr.sbin/makefs/tests/makefs_msdos_tests.sh @@ -48,6 +48,8 @@ atf_test_case T_flag_dir cleanup T_flag_dir_body() { timestamp=1742574908 # Even value, timestamp precision is 2s. + # FAT directory entries don't have an access time, just a date. + timestamp_atime=$((timestamp - timestamp % 86400)) create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -56,8 +58,7 @@ T_flag_dir_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_atime atf_check_equal $st_mtime $timestamp atf_check_equal $st_ctime $timestamp } @@ -72,6 +73,9 @@ T_flag_F_flag_body() { timestamp_F=1742574908 # Even value, timestamp precision is 2s. timestamp_T=1742574910 + # FAT directory entries don't have an access time, just a date. + timestamp_F_atime=$((timestamp_F - timestamp_F % 86400)) + create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -82,8 +86,7 @@ T_flag_F_flag_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_F_atime atf_check_equal $st_mtime $timestamp_F atf_check_equal $st_ctime $timestamp_F } @@ -97,6 +100,8 @@ atf_test_case T_flag_mtree cleanup T_flag_mtree_body() { timestamp=1742574908 # Even value, timestamp precision is 2s. + # FAT directory entries don't have an access time, just a date. + timestamp_atime=$((timestamp - timestamp % 86400)) create_test_dirs mkdir -p $TEST_INPUTS_DIR/dir1 @@ -106,8 +111,7 @@ T_flag_mtree_body() mount_image eval $(stat -s $TEST_MOUNT_DIR/dir1) - # FAT directory entries don't have an access time, just a date. - #atf_check_equal $st_atime $timestamp + atf_check_equal $st_atime $timestamp_atime atf_check_equal $st_mtime $timestamp atf_check_equal $st_ctime $timestamp }