From nobody Fri Aug 21 00:44:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hR1mT6RYtz6pP7P for ; Fri, 21 Aug 2026 00:44:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hR1mT3lZcz45GN for ; Fri, 21 Aug 2026 00:44:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787273097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BXKymEDM+doq8IIQQyq1U9+xdED9gL8CitL9PeUoKsc=; b=cp0+5TEErTv0ugdzv8YLMost9sxVoB2sC1pJ10CbCKnAHEcPCIO2pQeFzm6RgjHCC8AuEs 7fgrrkiVwzS3yQ7+x9MX/npqbisulFdXvS5+PlgYBtew0xVfCs7eyksYc0+znoctNXolf4 ZlFPrj570QvLVIucWPVrHXNST8mD7EEr4KZEzcD1sxJSk3vdw4EpBxR/lfqGkzftIXGhz5 elYlNIxNOY/DAKpjdBUkAm3eGuUXsg99Jpi26Vnruek+oTBLM9GbclfBdV/uUuZPni4dbj KcHZhWQozXxFZTyvDXbCHeZyp9oe/VOUZrvjjCT/MvnYIfGCHhhqpkUpyyCtOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787273097; a=rsa-sha256; cv=none; b=doPKRI2zcHKOYEmVaxCzWq3ojPQHFet8g7NC1vKJHxh6Jl+yoUmn0XjQEu/hOU0l9Dk8K9 ifxAQriMO03RUjHQzwISDMNHruOjPjP4LqpW6FxQTqxH+rp/cgapuvQ5N/cccpoNt53uj/ srBfZ0ErPKzYRjfENUEMrKK5ELhkiOw0gVW+HaS3GMQcLC0KpMZe+JX9BrScuEzS4Er3bo YPjOAb6OdOs/NYT4n7QMACHmuakvhhKhiTOXxPIZjCbcP0Up1rvox6AKVDyT4AG1aUZBYP nkIl1n8x3UFmIlfdd4h1PdOgaXEcciqkE0H/aCS8ViM54ylDs4InWU7IsPJvDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787273097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BXKymEDM+doq8IIQQyq1U9+xdED9gL8CitL9PeUoKsc=; b=HnWnnaOBJSrmfagsVg45unzy1KCol++x5Zvg8hWndl43lE98djAYyp/rKbzf0k48wROf6P A7kG/LF34BURlstByXZTvOjEFT61ApCqZ14UqeTKu+AZRt/8IHyFydKAf4fqA59iiICnpz vJ1MJ4Sjkf/D+hLmcimiyEBoIkujUzjX13j7Cxqe0LbO2V0WC0n2F/WHuEJKklV0ds1j2m jQsO6GsW1Oh/tMLpKKzyxd2k5LEom0rfbSwBAY9Nyz7bhBQa1cGfVcFg3l7Kfi29tZiEL8 BFmHPt4LHN8RLaIrsmhVyZr0giaLPnFqaMRc4wK46AL5l5gP5pkovFscsyGBPQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hR1mT1RpqzhBj for ; Fri, 21 Aug 2026 00:44:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24940 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Aug 2026 00:44:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 9f8a26691256 - stable/14 - ixgbe: Apply the 82599 D3 link workaround only for D3 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9f8a2669125695334d5d6eee998d9e5dea86f906 Auto-Submitted: auto-generated Date: Fri, 21 Aug 2026 00:44:57 +0000 Message-Id: <6a879f89.24940.6a21fff1@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9f8a2669125695334d5d6eee998d9e5dea86f906 commit 9f8a2669125695334d5d6eee998d9e5dea86f906 Author: Kevin Bowling AuthorDate: 2026-08-05 14:33:32 +0000 Commit: Kevin Bowling CommitDate: 2026-08-21 00:43:46 +0000 ixgbe: Apply the 82599 D3 link workaround only for D3 ixgbe_stop_mac_link_on_d3_82599() implements the workaround for 82599 erratum 33. It forces incompatible auto-negotiation settings before the device enters D3, and reset clears them when returning to D0. ixgbe_if_stop() is also used for ordinary interface reconfiguration and recovery. Those paths do not enter D3 and should not program this power-management workaround. They continue to stop the adapter and disable the transmit laser. Move the call to ixgbe_setup_low_power_mode(), after ixgbe_if_stop(). This preserves the required ordering for detach, shutdown, and suspend while avoiding the D3 settings during ordinary restarts. (cherry picked from commit d025b84268ec18d55c2d3088729cf4ad7673ecac) --- sys/dev/ixgbe/if_ix.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 2b023ce67eed..7588cb369a10 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -3777,6 +3777,10 @@ ixgbe_setup_low_power_mode(if_ctx_t ctx) ixgbe_if_stop(ctx); } + /* Disable the 82599 link only when actually entering D3. */ + if (hw->mac.type == ixgbe_mac_82599EB) + ixgbe_stop_mac_link_on_d3_82599(hw); + return error; } /* ixgbe_setup_low_power_mode */ @@ -4747,8 +4751,6 @@ ixgbe_if_stop(if_ctx_t ctx) ixgbe_reset_hw(hw); hw->adapter_stopped = false; ixgbe_stop_adapter(hw); - if (hw->mac.type == ixgbe_mac_82599EB) - ixgbe_stop_mac_link_on_d3_82599(hw); /* Turn off the laser - noop with no optics */ ixgbe_disable_tx_laser(hw);