From nobody Fri Aug 21 00:33:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hR1Vx6JVqz6pNQT for ; Fri, 21 Aug 2026 00:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hR1Vx4QYtz41hr for ; Fri, 21 Aug 2026 00:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787272393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LYgFIG2nGPGbaYhkenojMdSu/abwvnPoOjMnrjsuX+w=; b=pchRdByW8FKK7G7C83VEZdfF4HsWwh96RvCFgB+M9fAQr/oQZPtZaB6rDSBFY3kjhH3Kcs meIkIgXWdNKz3eM8XlAcYQC6u55aKG5FR+eWe6kwxAvKe+j4e0v1Ee/wq/4FR3OH8J/vE5 u+8VE7FvUO9f6niROza8ygzYDCGBkI2856B2qOw/71zICXDlsi3IvTuBdlkgSj7xO2dpFC +oRCSuRR197bGzIOAQp9UbnZkgaA58SQj7fENOHqEiN/YPMYz6l8b4uetKmYRt2kzyVe+t zeOoHN4VF8kmqC9oHkjHX8UQcCfmKKz5lZrkYsdsSd++GPDciLPBdGeI5hN/Mg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1787272393; a=rsa-sha256; cv=none; b=rPiU3Ct05uIBpFvJh3LJr8rF8jJ+tZbim8xrnVSUb2QLSzeIRpJgCgAS/Lscaoe4OPxErk jtbEgquiudDuGg2qEKvtMrpDO1uaWsrETX8BOcq7VFsxnXsofnGsYGb7el7mJk8ua4FO8p bX3zTxTIwKxnbUExjHXVQ4ax3yu/19hH8gTJrg7P8zUVrG7iKf9yAoypOyTmgMVUAV6Tr+ M7GSzv+VXozwV+LlD2G3rBQUfz/Y1q9BXGANMj39wbXnOJJsMNbAQNooYpe8vyMfJhTmZk 5Bz9uRQizreboB2FcQGEwUq2nP+gaI3/h6GqnN/nGiZOkyp3PktezutEu7ySgw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1787272393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LYgFIG2nGPGbaYhkenojMdSu/abwvnPoOjMnrjsuX+w=; b=aRUdDH2jA0sG6bNCSOGfFZbLkHZulGZIvjb0+rQjYDF/ic9ILAEPA1Ea89wa8RcwNHGm7c 2BkVb1PEz87jDc3cYd8rSFJ265uYetH0KUk7hRjfpaBXxgQzxtdkq/mOmxh2LRw1KRtvT7 aZqxraNTcIecXsmHnpXf0XQwWQwJsmZRw6ITS5Rar/SshoRComWWsYA61zx8D+BS5VMBKx VZu7ZyHbRULAG41dxM2XMGDtjEjCkmJpKONHBABAU+FhS7KhrrTEHzpWL07ZtyhghCyfIe ZpPsnxK7+n6tsSE5ZhDqoN9m+KekiAvVfGLM9SF7J//lYI2dX2Q6zf3oJswogg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hR1Vx3C1wzhHl for ; Fri, 21 Aug 2026 00:33:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21faf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Aug 2026 00:33:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 990f2ad47fa1 - stable/15 - ixgbe: Apply the 82599 D3 link workaround only for D3 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 990f2ad47fa1af2e4e05abc86631a8ba6725165b Auto-Submitted: auto-generated Date: Fri, 21 Aug 2026 00:33:13 +0000 Message-Id: <6a879cc9.21faf.3cefafdd@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=990f2ad47fa1af2e4e05abc86631a8ba6725165b commit 990f2ad47fa1af2e4e05abc86631a8ba6725165b Author: Kevin Bowling AuthorDate: 2026-08-05 14:33:32 +0000 Commit: Kevin Bowling CommitDate: 2026-08-21 00:33:03 +0000 ixgbe: Apply the 82599 D3 link workaround only for D3 ixgbe_stop_mac_link_on_d3_82599() implements the workaround for 82599 erratum 33. It forces incompatible auto-negotiation settings before the device enters D3, and reset clears them when returning to D0. ixgbe_if_stop() is also used for ordinary interface reconfiguration and recovery. Those paths do not enter D3 and should not program this power-management workaround. They continue to stop the adapter and disable the transmit laser. Move the call to ixgbe_setup_low_power_mode(), after ixgbe_if_stop(). This preserves the required ordering for detach, shutdown, and suspend while avoiding the D3 settings during ordinary restarts. (cherry picked from commit d025b84268ec18d55c2d3088729cf4ad7673ecac) --- sys/dev/ixgbe/if_ix.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 2b023ce67eed..7588cb369a10 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -3777,6 +3777,10 @@ ixgbe_setup_low_power_mode(if_ctx_t ctx) ixgbe_if_stop(ctx); } + /* Disable the 82599 link only when actually entering D3. */ + if (hw->mac.type == ixgbe_mac_82599EB) + ixgbe_stop_mac_link_on_d3_82599(hw); + return error; } /* ixgbe_setup_low_power_mode */ @@ -4747,8 +4751,6 @@ ixgbe_if_stop(if_ctx_t ctx) ixgbe_reset_hw(hw); hw->adapter_stopped = false; ixgbe_stop_adapter(hw); - if (hw->mac.type == ixgbe_mac_82599EB) - ixgbe_stop_mac_link_on_d3_82599(hw); /* Turn off the laser - noop with no optics */ ixgbe_disable_tx_laser(hw);