From nobody Mon Aug 17 12:10:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hNs9D0N4Pz6pCJY for ; Mon, 17 Aug 2026 12:10:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hNs9C6cwbz3DsR for ; Mon, 17 Aug 2026 12:10:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786968623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WNWassHD17GW/FxKIK5XGLEcVqdbM2YThqBesqFZz+w=; b=Wc1+j7g549tqDo3uX0hZLHuqjnHUCH5S/Rq1dmVgOwylxjxqqNWTI4zyT7uIq8isXqeFAJ UM2F+dSh8QlQQSy/i/nNcjqUsxOSOhvClC5oJZy/fTsehj2H6JpczoB2yNChiCRKMLEUBt SgwK8YJN7pxfmoHovgu8V7WQBDyXfqZoIkPMNIKUhypWhLaHoFdfIDP6lAO8sHbmEqucKP syKawBGIvME5VaxfWwWvg0/GnJviPhBF0X0K64PAZT1YdWJZiLPUn+wNMdxFAAann6JfO8 rtiyCEytMfXCRAmbVgPl9RwPo6pGZVwvpcg5ebw1mhcDi0+GBIsQ5m0GCdgeRA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786968623; a=rsa-sha256; cv=none; b=xnvo56DFJ7TosYdo7PR7NKuew88E667RrHB7XcitElYQPnw/AQoHi91cSUBSjg9CqtdP5I QjsizSiBfkd308yKrSqw38Xutb6P5/rpbEHGE1t3zcJtSvtRg4vjO3UEcSTtvbyUR1PsQP lP9XSXALwTP74FqxN8EdAeExcpRur1rZBCDEuWk29ALAty9QVGZD/+GqIWPWxx12i45bqY BuVwEnRBqUsSgKMnzLJlcxympTEKjGXTonS1vBpPowfveI6wGWF1LDTLK1hCdSwusblX/3 vbNZDG8jW1HtM4bzSrtDAWqZ3d+WPw4kx80q8ZsEH+edGwNzaXPqN3dV/SkHzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786968623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WNWassHD17GW/FxKIK5XGLEcVqdbM2YThqBesqFZz+w=; b=v/E6Mf/fwGGzVpThrG8FKvvusKEb83u2vnUbVDfjbQM0mqrK2pVElzcpKrNlBYDw8VhAH1 7sQPpH66kvkXTslRj+renPWorstBY+enAbex6DNQfys+pueXuvfzdAQbIdgnp1cPzPtBpK ZUA+EEbhqHxWYoAH3eKMxGvI7ztrKVVQ1luOkIqchX/97/FtYcKclkGOmCU2we5INaff++ 0HWBN/fsSDDtwWn3einbO00DZfQcjA8d7Q+QVNBIaXNJ/GerWnhrJC3hT9jPLAKaLAFLdq yyvS05s04rqHDqqa4ikikbeX43XU0mb7RYJbUuUlyEgmL1THLJrQ+Rt04R0pcw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hNs9C5dDPz1C7L for ; Mon, 17 Aug 2026 12:10:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bc74 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 17 Aug 2026 12:10:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 582e01321ac6 - stable/15 - bhyve: tpm: Avoid printing a message when clearing the cancel bit List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 582e01321ac6204f3560674c290a58ed89de39f5 Auto-Submitted: auto-generated Date: Mon, 17 Aug 2026 12:10:23 +0000 Message-Id: <6a82fa2f.3bc74.56a47bc1@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=582e01321ac6204f3560674c290a58ed89de39f5 commit 582e01321ac6204f3560674c290a58ed89de39f5 Author: Mark Johnston AuthorDate: 2026-07-31 14:22:46 +0000 Commit: Mark Johnston CommitDate: 2026-08-17 12:07:41 +0000 bhyve: tpm: Avoid printing a message when clearing the cancel bit Some drivers do this routinely, e.g., FreeBSD's tpm20 does this every time it sends a command in tpmcrb_transmit(). This causes the console to fill up with messages. Instead, only print a warning if the cancel bit is set to one. Reviewed by: corvink MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D52425 (cherry picked from commit 1c1a3646a1c86624e67a42636894fd1685386cf1) --- usr.sbin/bhyve/tpm_intf_crb.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/usr.sbin/bhyve/tpm_intf_crb.c b/usr.sbin/bhyve/tpm_intf_crb.c index 9b44d1d133b0..bf5602a87659 100644 --- a/usr.sbin/bhyve/tpm_intf_crb.c +++ b/usr.sbin/bhyve/tpm_intf_crb.c @@ -371,11 +371,18 @@ tpm_crb_mem_handler(struct vcpu *vcpu __unused, const int dir, break; } case offsetof(struct tpm_crb_regs, ctrl_cancel): { - /* TODO: cancel the tpm command */ - warnx( - "%s: cancelling a TPM command is not implemented yet", - __func__); + union tpm_crb_reg_ctrl_cancel cancel; + + if ((size_t)size > sizeof(cancel)) + goto err_out; + tpm_crb_mmiocpy(&cancel, val, size); + if (cancel.cancel != 0) { + /* TODO: cancel the tpm command */ + warnx( + "%s: cancelling a TPM command is not implemented yet", + __func__); + } break; } case offsetof(struct tpm_crb_regs, int_enable):