From nobody Sun Aug 16 21:24:55 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hNTWk3P7Fz6pd38; Sun, 16 Aug 2026 21:25:06 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp-relay-int.realworks.nl (smtp-relay-int.realworks.nl [31.134.205.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hNTWk0h5yz3HWj; Sun, 16 Aug 2026 21:25:05 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Authentication-Results: mx1.freebsd.org; none Date: Sun, 16 Aug 2026 23:24:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1786915497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mf3mVObyFjnZ7RYoJ26iwfRdBZJvTeCh9CEJOMuIq+k=; b=rMDB0IAYM6+LcXu53eluUsY5pe3tu3Au6Lf2MOsUMxhzsXlLp9OR0hbtrRxGkqcDPglMw5 aYUNBU7D2x0bhty2/NTgxK0LucUxcOpWsnf+ucOcEpDpMWiF4L6PHqQganUKUvXiI4noeI lT6nGviPGuKgmmkKQnk/fPWB+lS6dw50IPl1wkUttw4H42CUcdRLvZG/ExDAV1caZUGqBV o5rtiHW26+yBdeUaIA7zxGvazGv70xeKJjvBGKWVLq/NkM/YrlapZ/Lk/YYo5sdNpDkvy6 OdJSbIOuvzkpn70TUKVVkKnzYCZWkYgkTmq5JJGY59nkHoDxFCzfjhdCaPAkaA== From: Ronald Klop To: Alan Somers Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, voidanix Message-ID: <1394173135.167669.1786915495022@localhost> In-Reply-To: <6a820c72.3d6f3.358d7bf2@gitrepo.freebsd.org> References: <6a820c72.3d6f3.358d7bf2@gitrepo.freebsd.org> Subject: Re: git: 95a4412e3a4d - main - zonectl: Consistently report ZAC conv. zones WP LBA List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_167668_321652842.1786915495017" X-Mailer: Realworks (807.184) Importance: Normal X-Priority: 3 (Normal) X-Rspamd-Queue-Id: 4hNTWk0h5yz3HWj X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:51088, ipnet:31.134.200.0/21, country:NL] X-Spamd-Bar: ---- ------=_Part_167668_321652842.1786915495017 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Would it be helpful for future readers of the code to have a constant defin= ed for these? Instead of 2 =E2=80=9Cmagic=E2=80=9D values.=20 Regards, Ronald Van: Alan Somers Datum: 16 augustus 2026 21:16 Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commi= ts-src-main@FreeBSD.org CC: voidanix Onderwerp: git: 95a4412e3a4d - main - zonectl: Consistently report ZAC conv= . zones WP LBA >=20 >=20 > The branch main has been updated by asomers: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D95a4412e3a4d41b430f298ea2c= 2a51f8aa119c2c >=20 > commit 95a4412e3a4d41b430f298ea2c2a51f8aa119c2c > Author: voidanix=20 > AuthorDate: 2026-07-30 23:50:32 +0000 > Commit: Alan Somers=20 > CommitDate: 2026-08-16 19:15:33 +0000 >=20 > zonectl: Consistently report ZAC conv. zones WP LBA > =20 > On ZAC drives, conventional zones conventionally report a write point= er > LBA of 0xffffffffffff. This field is 48 bits wide, unlike ZBC's 64 bi= ts. > =20 > Recognize both ZAC and ZBC all-ones behaviour in the WRITE POINTER LB= A > field to indicate non-valid information. > =20 > Tested by: fuz > Discussed with: fuz, asomers, ken > Fixes: 4735ef6196bc ("zonectl: display conventional zones be= tter") > MFC after: 2 weeks > Sponsored by: Google Summer Of Code 2026 > Reviewed by: asomers > Pull Request: https://github.com/freebsd/freebsd-src/pull/2345 > --- > usr.sbin/zonectl/zonectl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/usr.sbin/zonectl/zonectl.c b/usr.sbin/zonectl/zonectl.c > index 9dc6ddfd1aae..462353cd58ef 100644 > --- a/usr.sbin/zonectl/zonectl.c > +++ b/usr.sbin/zonectl/zonectl.c > @@ -292,7 +292,8 @@ zonectl_print_rz(struct disk_zone_report *report, zon= e_output_flags out_flags, > (uintmax_t)entry->zone_start_lba, > field_widths[ZONE_FW_LEN], > (uintmax_t)entry->zone_length); > - if (entry->write_pointer_lba =3D=3D 0xffffffffffffffff) { > + if (entry->write_pointer_lba =3D=3D 0xffffffffffff || > + entry->write_pointer_lba =3D=3D 0xffffffffffffffff) { > /* > * This value is reported by HDDs for conventional > * zones. It really means "N/A". Reported it as -1, >=20 >=20 >=20 >=20 >=20 ------=_Part_167668_321652842.1786915495017 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Would it be helpful for future readers of the code= to have a constant defined for these? Instead of 2 =E2=80=9Cmagic=E2=80=9D= values. 

Regards,
Ronald

<= p>Van: Alan Somers <asomers@FreeBSD.org>
<= strong>Datum: 16 augustus 2026 21:16
Aan: src-= committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-ma= in@FreeBSD.org
CC: voidanix <voidanix@freebsd.org>= ;
Onderwerp: git: 95a4412e3a4d - main - zonectl: Consis= tently report ZAC conv. zones WP LBA

The branch main has been updated by asomers:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D95a4412e= 3a4d41b430f298ea2c2a51f8aa119c2c

commit 95a4412e3a4d41b430f298ea2c2a51f8aa119c2c
Author:     voidanix
AuthorDate: 2026-07-30 23:50:32 +0000
Commit:     Alan Somers
CommitDate: 2026-08-16 19:15:33 +0000

    zonectl: Consistently report ZAC conv. zones WP LBA=
    
    On ZAC drives, conventional zones conventionally re= port a write pointer
    LBA of 0xffffffffffff. This field is 48 bits wide, = unlike ZBC's 64 bits.
    
    Recognize both ZAC and ZBC all-ones behaviour in th= e WRITE POINTER LBA
    field to indicate non-valid information.
    
    Tested by:      fuz
    Discussed with: fuz, asomers, ken
    Fixes:        &n= bsp; 4735ef6196bc ("zonectl: display conventional zones better")
    MFC after:      2 weeks     Sponsored by:   Google Summer Of Code 202= 6
    Reviewed by:    asomers
    Pull Request:   https://github.com/freebsd/freebsd-src/= pull/2345
---
 usr.sbin/zonectl/zonectl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/usr.sbin/zonectl/zonectl.c b/usr.sbin/zonectl/zonectl.c
index 9dc6ddfd1aae..462353cd58ef 100644
--- a/usr.sbin/zonectl/zonectl.c
+++ b/usr.sbin/zonectl/zonectl.c
@@ -292,7 +292,8 @@ zonectl_print_rz(struct disk_zone_report *report, zone_= output_flags out_flags,
            (ui= ntmax_t)entry->zone_start_lba,
            fie= ld_widths[ZONE_FW_LEN],
            (ui= ntmax_t)entry->zone_length);
-       if (entry->write_pointer_lba =3D= =3D 0xffffffffffffffff) {
+       if (entry->write_pointer_lba =3D= =3D 0xffffffffffff ||
+           entry->wri= te_pointer_lba =3D=3D 0xffffffffffffffff) {
            /*<= br>             &nb= sp;* This value is reported by HDDs for conventional
            &nb= sp;* zones.  It really means "N/A".  Reported it as -1,




------=_Part_167668_321652842.1786915495017--