From nobody Sun Aug 16 02:47:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hN0jn6464z6pHCw for ; Sun, 16 Aug 2026 02:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hN0jn3THlz3ffM for ; Sun, 16 Aug 2026 02:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786848429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f9ziL91BKR0ygsS7VHOSOTHYQt6stQleDk+aBryTtLQ=; b=TiZT0GdXv7TrLXbU2GqSMkUrgwdZSCRlkwSwgzbWShENiA+Jmd+hP5hO08DGnNUwEydsHI g8pUR05MKZzNFIHGyeRhp1vKWXj8BuzJEPVQ7mwQNR6CTgBeqyqgxcbEuSFzr+JxQc7FK9 bzWHZC9DmPpoBpLpP+eHzZYTnI4dNem+v7wq3nEP6Tqus5jqjRU0X++Z8aCBV//1D/2+Fp Eh+czBSohPJR3+hM74TIJSb1yrkhzeIyjg0fdrzYLT6oILd0Ds+C+UOBF5aphOpSKKQosD k7pxrBEW/wQ0wfi1V1UjhJZKq6pw5bHi+q1yhRng2BjcxZZrSOk8znB/MCDo5Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786848429; a=rsa-sha256; cv=none; b=jwBBKRgoLdrMfh0BYuKFr7HXuYBgCZUL3SMp5Ub949V6hMc9+sSbF1/+afIbwmh9NmnZOm rI+nJD8zAlPAXe2JsEV/PBPNqobInlvjfi9BrDF0deAI04nbkekgPRg/DX2D9RQqCgUobT HX1oyhxyYpaRVtQN7tFfWPIVN5lNK3GBF8xJRnGcWlxpYYRhRp0BqglkIoF1Px1m7PdRsj EjFTNh5/2fuLy10UajgcwEYn4/o9emxlsgj6XOo/oMuj05ZpNzJx6q2AmlOKSoquRj8TUN CCUFvl1GADuMAlha7XzPm4+kHLMuKUNEsD/wJGgcT+RyDodVCcK+dXHg+K2n/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786848429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f9ziL91BKR0ygsS7VHOSOTHYQt6stQleDk+aBryTtLQ=; b=Wgv0Uu73JI8fBY0+Rdjn9/zIjNQaTOOmZGciH+SLhDt8GTjeFhCjLC+HK0N3wazlAyJp2r 16DKXCoxrhiQXIMc8mw1nUYpgz2etMSF1u6R4UTRhgnEk9Ox5ILRMqBf3wNAQpGy2XNNxQ lAaFoXmNWske8DOJ2ujQdbIVFpd8wmoI/YuoW+5d6eDKD2HKNMqiLPP+zcvuJ5l1aYDx2q yVHFkcCRsHzFe9SB6Xq0MzQOQJHJyVwv/I9vhl0rOgrQzAvvUCkhv/FKoscrW6WjWeZ4Fm Et16esQQkpslVEeWCoT5+oNIzwdmzadcSrccJ0JZgm5imYAW1rtznnxcY38clw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hN0jn2HySz189B for ; Sun, 16 Aug 2026 02:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 451ea by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 16 Aug 2026 02:47:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mark Johnston From: Konstantin Belousov Subject: git: 4435b4fbe0d0 - stable/15 - procdesc: Disallow pddupfd() of non-passable files List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 4435b4fbe0d04718705de623ad68d79f44295d9d Auto-Submitted: auto-generated Date: Sun, 16 Aug 2026 02:47:09 +0000 Message-Id: <6a8124ad.451ea.599dcd1c@gitrepo.freebsd.org> The branch stable/15 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=4435b4fbe0d04718705de623ad68d79f44295d9d commit 4435b4fbe0d04718705de623ad68d79f44295d9d Author: Mark Johnston AuthorDate: 2026-07-24 20:05:26 +0000 Commit: Konstantin Belousov CommitDate: 2026-08-16 02:41:34 +0000 procdesc: Disallow pddupfd() of non-passable files (cherry picked from commit 91e11c8f2b38eb1d1f3a1d57b27378fb2c6ab3c1) --- lib/libsys/pdfork.2 | 6 ++++++ sys/kern/sys_procdesc.c | 10 +++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/libsys/pdfork.2 b/lib/libsys/pdfork.2 index 584c87e17e38..1b99157203c1 100644 --- a/lib/libsys/pdfork.2 +++ b/lib/libsys/pdfork.2 @@ -195,6 +195,8 @@ flag set. The .Fa flags argument is reserved and must be zero. +Certain file descriptor types cannot be copied this way, namely +kqueues. .Pp The following system calls also have effects specific to process descriptors: .Pp @@ -350,6 +352,10 @@ The file descriptor is not a valid file descriptor in the specified process. .It Bq Er ENOENT The specified process does not have a file descriptor table. +.It Bq Er EOPNOTSUPP +.Fa remotefd +refers to a file that cannot be duplicated across a process boundary, +such as a kqueue. .El .Sh SEE ALSO .Xr close 2 , diff --git a/sys/kern/sys_procdesc.c b/sys/kern/sys_procdesc.c index 6eed8c7f0267..9b007aa8997b 100644 --- a/sys/kern/sys_procdesc.c +++ b/sys/kern/sys_procdesc.c @@ -799,9 +799,13 @@ kern_pddupfd(struct thread *td, int pdfd, int fd, int flags) PROC_UNLOCK(p); error = fget_remote(td, p, fd, &fcaps, &fd_flags, &fp); if (error == 0) { - error = finstall_refed(td, fp, &fdr, O_CLOEXEC | - ((fd_flags & FD_RESOLVE_BENEATH) != 0 ? - O_RESOLVE_BENEATH : 0), &fcaps); + if ((fp->f_ops->fo_flags & DFLAG_PASSABLE) == 0) { + error = EOPNOTSUPP; + } else { + error = finstall_refed(td, fp, &fdr, O_CLOEXEC | + ((fd_flags & FD_RESOLVE_BENEATH) != 0 ? + O_RESOLVE_BENEATH : 0), &fcaps); + } if (error != 0) { fdrop(fp, td); filecaps_free(&fcaps);