From nobody Sat Aug 15 18:09:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hMnDT743xz6p80y; Sat, 15 Aug 2026 18:09:29 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hMnDT51H4z3TZ8; Sat, 15 Aug 2026 18:09:29 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786817369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QuulYBEJQeR4tOSuh9Z88W8q1lyBsp3eE2BYv6hWe+Y=; b=ZJRVJhcc81H8HDU78PcIYxVmUFuOVhA1RiUXNsGlre7cfRWOBMYF2HDCIRodp/5m8HcOZm EL6/ZFEE9c0jQuosb1g/9wcvUiVd81eN+bcAcAG7AgsTOOPg2pJaTD00P8tLAl85UfFIas WNmQRYmhiMycdPPlEZoHJY5F/s9jTI2FWFIZ+Bg9mxjfeZ2OqgRN3JhVtedRlzh8J2opsw TXiv2nrFDuDAv/yzeMQ3wGHwmjYpUhi2uiy7yjShmFCEV67rvmQ3vJKj4cNjW6V0ICOow4 iLYfuV2udlChMaaGCbFveQiB79xH/DXOj7PLpaLIBQj1xLlYCbLhnn7PYJ3biw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786817369; a=rsa-sha256; cv=none; b=R7c9tAHRcU5QdDga15l6kZFDbCPJrfZKXz3eAQpvU12jVhbzHh2W3ZzZZxQR3MMKSDL1qX Dt51svaE+x0TBDObZSZ17juAjrGhzKWVRV+IytKrlv6abcKNalpdjhmmDuhuZ2CiaGaXxY tw4DlERxeq2DD4/NpGy6HE/E0LLGh9IlKi/ANriOoF0nqPCxjPeNzyrjnzQG4hzWPqwd69 nZQ+DqCNZ6LrJ53K4cQFscX1QAx8MO4FDm9/17fZ6CLOY+SoKH7MxslM5qtyT1A4gRvWFw mdjYVmuZjOhhUbop5mx7LpEqLhHhKyMctjqmu2CbuGDVwnCtGTXNlyE87PTxdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786817369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QuulYBEJQeR4tOSuh9Z88W8q1lyBsp3eE2BYv6hWe+Y=; b=Lwqy7hM8AW+yvJ6P2+vbvYqi7IWVSyC41jpk6/uDL7Lwt7sO4j3rLAdWDwxPP8j7wZxplc C435MkAKfpFQTcFpZNicyFEri8iKedcCGrv8nVMC41X9XHzlvHm4AnqHgsXvaY0Tw8Cc12 HOhpIupkomQoE8URF1XMBy83dbi7wKfbIMPzYX03EK5tyWrx1ZISTNlLK3nhvLMvX8dfzB 7e1lt6X1tAK6f6AtpI+bskfT/W1km4DqpfZDUEOpQOckJoymIEFCIxb/U3e8i1t9PByUSp VHrnOTojpbWo5cJrc88YC5TNqsvqJgw+o4KCi8EvkmnxnW3x78amLMKxcoJ4KA== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "YE2" (not verified)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hMnDT37fyzs9m; Sat, 15 Aug 2026 18:09:29 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (bladnoch.home.andric.com [192.168.0.20]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 5D01330904; Sat, 15 Aug 2026 20:09:28 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.8\)) Subject: Re: git: cd0727ec709b - main - libc: Add C23 feature test macro From: Dimitry Andric In-Reply-To: Date: Sat, 15 Aug 2026 20:09:28 +0200 Cc: Faraz Vahedi , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: <3521D35A-40D0-48B6-808C-E18C15FC69D8@FreeBSD.org> References: <6a7f6d6a.372ae.3079abac@gitrepo.freebsd.org> To: Robert Clausecker X-Mailer: Apple Mail (2.3826.700.81.1.8) On 15 Aug 2026, at 20:00, Robert Clausecker wrote: > > Hi Dimitry, > > The test used by this package seems defective. > I don't think we should try to support such defective code. > Perhaps the gmp source can be patched to check for > __STDC_VERSION_STDIO_H__? Of course it could, and the patch is pretty simple. But I do not agree that the code is "defective". Before C23, there was no standard way of checking whether you had FILE declared. So this part of gmp, while admittedly ugly, is a fine way to work around the fact there was no standard. It simply enumerates defines which have been available for years, or even decades. I would call it "effective", not "defective". :-) That said, I have applied such a patch locally, and it seems to work. But obviously a maintainer of a port would say "this has worked for 20 years, why change it now" ? :) -Dimitry