From nobody Fri Aug 14 22:57:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hMHfx65g4z6nvRJ for ; Fri, 14 Aug 2026 22:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hMHfx40Vqz3pld for ; Fri, 14 Aug 2026 22:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786748233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CUt45XZpqrriKbP+UhW3i2gob3zBy6ncPYFqQ0qjCsM=; b=Zb7EJEQG0rV4+ro3LEwPjkukwwkyjydOfommbZdsUv7q2v18XBypVj8F/3ToEuGbli3F+N p4kVmOGy5xRzIGG3lR3cb1ReugTjsFfI9nTsDXyT1LKOLgxlUc6NTHV+4q8z8xITbato7m ObFzOh6n5taEDwl6i7LF/sgPec1mMHZrigDV5T7XPuqdXpRBykC976rimZO5jKTYNyi+Gt 2K74ur9OR6D8smdieKGvIv7aMJtorjsw6DJrC8RRcZy85fqQUzRJ9kzLK1fMEDwNQX0fD5 kS2J+I5cWDBCOsThVICs1Syw37n9rrYyupo0/ZyYd7qqGJbYUC5HzVxFP5evTg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786748233; a=rsa-sha256; cv=none; b=tQ7s4SBhFv22GmBuD9DxdjVZrOWU+aVJVhzL151B+/01r3dg131cF0FXJiLoGE459ZzMWm ucUvAoRkZVuUOgKwGVHge1FuR0sh1eaGHL3Ek6AUAwYRcHgL/F9alxz3JicnhBONcsDe0I Q9dkMH4kLG6R9/b19PJRTtygTH+ubQe4o1tCSP+BvylYr+vStR+PHXOo+BFuo8gSFprvAd LR+GKWMtfOgEJTszoicO6P29CKksDLU43ahxAvATgvOdI51hnP8/ZswfG8xhW+3INUq3uK V58Pnvtw//Iqu7zGhJgkpDKXkht6qehy+NS1a6ODemURb0ilWTo+KKVQ1kY9sA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786748233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CUt45XZpqrriKbP+UhW3i2gob3zBy6ncPYFqQ0qjCsM=; b=I2lotmBcViE5DLd7tpwnCL+r2Q2GzmrIh6jpsyMg4IvUu5gZKpiineiEjoDjuxfYT27gQj rUCr5hhpJYM1nGvEcqoxGPU/Hv96vA9q1DZMeD4C+adfL04mtJI5sVwTq1P6XeQzsbqLfD lRDGxC/u31FbsNOfmv5bKbbSq1IURPW2NnukOhrrHxLtHqVUiBl29XNpO7S5ch5igVoGIO B2yivqN5szXrie6HRJwwqvMCE7f6NveX4I7GcpZdAlvNFxWQ+RSMJLlxJDT4quQVmTvA3h A/LIajh56A8+Z0bMTNjlNk0Tk/dyJD448xG+kH774aJ8GIWYinqdE28JYOIpWQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hMHfx2Jmqz3HP for ; Fri, 14 Aug 2026 22:57:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24096 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 14 Aug 2026 22:57:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 06aaca43fe05 - main - iflib: actually disable simple_tx when ALTQ is in use List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 06aaca43fe05d22cd289af9b6fa751b9bd08b560 Auto-Submitted: auto-generated Date: Fri, 14 Aug 2026 22:57:08 +0000 Message-Id: <6a7f9d44.24096.3adb10c0@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=06aaca43fe05d22cd289af9b6fa751b9bd08b560 commit 06aaca43fe05d22cd289af9b6fa751b9bd08b560 Author: Andrew Gallatin AuthorDate: 2026-08-14 22:54:21 +0000 Commit: Andrew Gallatin CommitDate: 2026-08-14 22:56:35 +0000 iflib: actually disable simple_tx when ALTQ is in use When getting some baseline ALTQ numbers, I noticed that if simlple_tx is enabled in kenv, we wind up re-setting the transmit routine, but I neglected to actually clear ctx->ifc_sysctl_simple_tx. That leads to many different panics as we run a mixture of mp_ring and simple_tx. Pointy-hat to: gallatin Sponsored by: Netflix --- sys/net/iflib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/iflib.c b/sys/net/iflib.c index d4e23a70d569..c8662b6b7e69 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -5285,6 +5285,7 @@ iflib_device_register(device_t dev, void *sc, if_shared_ctx_t sctx, if_ctx_t *ct device_printf(dev, "using simple if_transmit\n"); #else device_printf(dev, "ALTQ prevents using simple if_transmit\n"); + ctx->ifc_sysctl_simple_tx = 0; #endif } iflib_reset_qvalues(ctx);