From nobody Thu Aug 13 16:36:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hLWGM0r8mz6nxKT; Thu, 13 Aug 2026 16:36:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hLWGL75l2z3V4m; Thu, 13 Aug 2026 16:36:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786639003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ALko66/mie5C7jneT9kLPB/kkUYJFKvj3CLsdJck7/w=; b=OOwyFwupuxDtd6BguvUM9j3VpQzX4rDIzoY0iynPe29fovax4239202QBdQ4RAmudmoXtV g8/6UjXdU4hDoTh/k1aFgiNKdi9FNKnlvD2YtEuLaF8ZcFrQ4cRzKQl84sPCa3wY76AI4J n4hXr/H3BprWnImak5qzQSEie46gppuMMOtnqu+SqdVXNRWDhYA7Wc680/FLzh0vi0b7k2 i0ZjInCkpyfQHxXBgEv6J++ue8AZCUya+7NDb12336OpOWbmQ7DRVQiWX+HM5RVQHIOh14 RLuPwxN9/qExMyjt2+jVcuxhns/6OjFy2dSh0n8qG7w18FWDfvhp3+Sq3aRQIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786639003; a=rsa-sha256; cv=none; b=KeiuLgn/y1UMl0OH+VrQU2UkqbXOsK1udaI2tgvOVhB0ACd0p3ay4W7+rouZwNdDTSXBKj 7PgjLZZ4ScOMulu+sjcroqjjZTpvr2TQ4LO8DFXZ8Z0HqQ1V/MqxqAm/AhTdst2aZCgsst UTKTF84y1tsyCg8LcM4ea83IUoRUKDZh2f+dWpAlCWgyYysVpR8OWrlzhU8VsUo1+LuwsO hkxZwxM8TKgmHT7nf36aVSVK4ErUztFlUPhGGI0qCWBtEHaxf4ydFnJaRU2o29NUB2uxkT HrOwQTVEL64Xv7H/iqKiCOfoqKuZzlJbaO0j4SKgD8mR32tXdSIQrOk2ldVkpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786639003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ALko66/mie5C7jneT9kLPB/kkUYJFKvj3CLsdJck7/w=; b=OAdCuivYLH+hkG/cwSz/t/om6/crfAImpRB8c3fFnInyYNwRIrj0Q253EsLyMgSKXjuA8y W1ff9LVPlo7vBex4sHA324eW1wNkuAINLjuIcOc6Gv9qULmizWXTr9vI5G0ataaBSFDTIt VX722amJXR2xAnlXE2hf7uxQU8IzcRVA7YUptYZfKMto87zJ5aYEH3zETz3eZvbkSNglbL OMlRRw+awzTGsCmrrHFTtoowBqxLrDBII4ZzpRsiaqLAaOiVojn3KhPwL6nVdWnwVvqG2T i82z+o0J03syVD8XC6cT2lofVmMuhIIgFO/5+wKVx+QP9KjIhP0V+MzCTv1ffA== Received: from [IPV6:2601:5c0:4202:5670:dde5:51c4:14c7:319a] (unknown [IPv6:2601:5c0:4202:5670:dde5:51c4:14c7:319a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hLWGL2kJkzlDM; Thu, 13 Aug 2026 16:36:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <69df1fc3-353f-40d3-a2f3-f7066fc3ac27@FreeBSD.org> Date: Thu, 13 Aug 2026 12:36:41 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 1ccf543b21ef - main - ifconfig: Add SR-IOV VF status output Content-Language: en-US To: Kevin Bowling , Gleb Smirnoff Cc: Kevin Bowling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Eric Joyner References: <6a78228f.3fa89.2de83f53@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/10/26 15:03, Kevin Bowling wrote: > On Mon, Aug 10, 2026 at 11:57 AM Gleb Smirnoff wrote: >> >> Kevin, >> >> On Sun, Aug 09, 2026 at 06:47:43AM +0000, Kevin Bowling wrote: >> K> The branch main has been updated by kbowling: >> K> >> K> URL: https://cgit.FreeBSD.org/src/commit/?id=1ccf543b21eff6e0828142e5c1d09519247143f4 >> K> >> K> commit 1ccf543b21eff6e0828142e5c1d09519247143f4 >> K> Author: Eric Joyner >> K> AuthorDate: 2019-03-18 18:30:00 +0000 >> K> Commit: Kevin Bowling >> K> CommitDate: 2026-08-09 06:46:29 +0000 >> K> >> K> ifconfig: Add SR-IOV VF status output >> K> >> K> - Adds SR-IOV VF status to the existing ifconfig "-v" output >> K> - Adds ioctl command for reporting VF status info from drivers >> K> - Adds support to iflib for drivers to handle this new ioctl >> K> - Add support for ioctl in ixl(4) >> K> >> K> Signed-off-by: Eric Joyner >> K> >> K> Relnotes: yes >> K> Differential Revision: https://reviews.freebsd.org/D19647 >> >> This is not a reviewed change. The D19647 itself was not accepted 7 years ago. >> Just an URL to reviews.freebsd.org doesn't warrant that change is reviewed. >> Even if it was accepted, just 7 year lag itself requires a re-review. > > I reviewed it. > >> This particular change brings a lot of new ioctl(2) APIs. It is the opposite >> of what other people were doing with ifconfig in the last years - reducing >> ioctl use and switching to netlink. > > This was to give Eric proper credit and provenance, it is immediately > replaced by an nvlist. A netlink interface is provided. What > concretely is your suggestion? FYI, you can add Eric in a Co-authored-by trailer to give credit to your final implementation. -- John Baldwin