From nobody Wed Aug 12 20:30:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hL0VQ2qYvz6nvp7 for ; Wed, 12 Aug 2026 20:30:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hL0VQ1Kzfz4F0W for ; Wed, 12 Aug 2026 20:30:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786566622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oZvzSAei8NyKDFVbPs+fbsoB2oAEwZ+HGOXLgX6Y0B4=; b=HilCF6VQ1faF1KyjmgJata1L8x45ESZFZgguYcfnulvOUS4NybOwTya19MwCsKTBdYYgAM pKFGxZ2yy7u9YtgR74+7kcF/Hj6QFBJPwezx0F6QoJhCfMxCtoZ1mkTdOMiL0zxS1b0EOs ZFSb6KNZOh5N0nBMTEHABOoGoaquBrNAAbAa4QQDjL18YOm+yP8+qnajz8BCOOhMAgzzuE EAmkDmctyDJqaXdQK2ihwZFEDFh16swlFGBSwXb+U+UNUAzQzL7Vde3WaL7a6PHkRXqi9k smsr4Gp7YuxM8dqisCGgc1amy9fdgtgRhh1mDL7HiinlKbERl60NsrchKbCGgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786566622; a=rsa-sha256; cv=none; b=V5HdgfffY3O9zBx/3N9MRE++LAB0ik9oijksaJc8IbFREesyj/R/weA0H0+7mrafMroA/J 6CJhippIBIH5Ry252Suw4/G4GXfj59bC3Q7Plc7lHGqoOyH8U78hJKszDaMmZ91464l10Q sPvdYAr1cjfoB+AL8qljwAQcADamjBW7CMF22z5j61bM33EJ1cPcvsuQdIu0PxX1ahdw+F eadKCteJ5t8Zx5U0qamaITwNk42iQfoPWpfR03kuD5ybT3s+F0xcR73sOS7B9I1nN7yZNR V7lRPjae+fzqA362QqJ6A9mYlMlrXsnHzveTXCptKIxLZPbj9gLBrGtFWw+TKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786566622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oZvzSAei8NyKDFVbPs+fbsoB2oAEwZ+HGOXLgX6Y0B4=; b=N8tpKEryM6mom2kWvDpvoXSO2g2AFU8lxBXzS1fOoXlDFjXFblSeFH8WnV0pr0yobnl9PI 7/xDUaQHguamJkQYeOSL3Vx3lt3FCWlL0BnCIvkNYNp0d/Yps7/976WE/T9JFWvILJZFwu Q8ZLA70G1fjkW5UTRKti7/gqnj3EkHoDgFNszZmAI5eKQAOEuwQNoxsSBR3z3uOjXiKEX1 YlMje1kSERrax2znz0iZXP3fNuZHe4Kvr2pOeA0Pi8VzgRX4nuQwcBlfx+oE1bglLc4sD9 WhWapsROiHCPbwNpbtBRYpEYLmnTrFWnpLBLxPTonmdOYGTWv2r6G1baplfXQg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hL0VP6Wqpzh4k for ; Wed, 12 Aug 2026 20:30:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3854e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 12 Aug 2026 20:30:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Kevin Bowling Subject: git: e22491cb9bdc - stable/15 - igc: defer sysctl-driven reinit to the admin task List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e22491cb9bdc84a425fab63c1351f576e018e16b Auto-Submitted: auto-generated Date: Wed, 12 Aug 2026 20:30:21 +0000 Message-Id: <6a7cd7dd.3854e.2eaf3cb2@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=e22491cb9bdc84a425fab63c1351f576e018e16b commit e22491cb9bdc84a425fab63c1351f576e018e16b Author: Abdelkader Boudih AuthorDate: 2026-08-05 04:40:58 +0000 Commit: Kevin Bowling CommitDate: 2026-08-12 20:29:50 +0000 igc: defer sysctl-driven reinit to the admin task igc_sysctl_eee() and igc_sysctl_dmac() called igc_if_init() directly. Request the reset through iflib instead, and skipping while the interface is down; the new value is picked up by the next init. Unlike e1000, igc has no ASSERT_CTX_LOCK_HELD and no acquire_swflag path, so the defect is silent here rather than an assertion failure. While here also remove unnecessary igc_if_init uses: iflib_if_init_locked() already runs after IFDI_RESUME and IFDI_MEDIA_CHANGE, so the trailing *_if_init() only added an unstopped IFDI_INIT that the following iflib_stop() undoes. Differential Revision: https://reviews.freebsd.org/D58629 (cherry picked from commit 30ccf2f48c11e54fc0540510dcec7cd006a2c366) --- sys/dev/igc/if_igc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index fe278f2029f3..c49948f7c57e 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -807,8 +807,6 @@ igc_if_resume(if_ctx_t ctx) */ igc_disable_broken_l1_2(ctx); - igc_if_init(ctx); - return(0); } @@ -1288,8 +1286,6 @@ igc_if_media_change(if_ctx_t ctx) device_printf(sc->dev, "Unsupported media type\n"); } - igc_if_init(ctx); - return (0); } @@ -3224,6 +3220,16 @@ igc_set_flowcntl(SYSCTL_HANDLER_ARGS) return (error); } +static void +igc_sysctl_request_reinit(struct igc_softc *sc) +{ + if ((if_getflags(iflib_get_ifp(sc->ctx)) & IFF_UP) == 0) + return; + + iflib_request_reset(sc->ctx); + iflib_admin_intr_deferred(sc->ctx); +} + /* * Manage DMA Coalesce: * Control values: @@ -3269,7 +3275,7 @@ igc_sysctl_dmac(SYSCTL_HANDLER_ARGS) return (EINVAL); } /* Reinit the interface */ - igc_if_init(sc->ctx); + igc_sysctl_request_reinit(sc); return (error); } @@ -3290,7 +3296,7 @@ igc_sysctl_eee(SYSCTL_HANDLER_ARGS) return (error); sc->hw.dev_spec._i225.eee_disable = (value != 0); - igc_if_init(sc->ctx); + igc_sysctl_request_reinit(sc); return (0); }