From nobody Wed Aug 12 03:03:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKYGl1gHVz6m9bs for ; Wed, 12 Aug 2026 03:03:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKYGl0prwz3jBw for ; Wed, 12 Aug 2026 03:03:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786503823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hboOBemOzRjzah71/CIe00Mt23misBC0ec///gCK4Uo=; b=QG7bgYtliAcZvgiKm9IRtPjbHET00403uS0AiAWN7yswHp34V53UPV/sjmG1lIkQsY50yN IZmH+/2WERA5azxwupaVf1VpIcqbvHAElr60xSec5RnbbT+s3DNG0jzZ8Wy6dXWMKNMzjs ubf9rBJGvFHpLbB21fHIXHcGUs9PnwNh7PEq5cvguVjRq7fNqNrpIGnCGPTNXo4bWg66+I v/fpCVaWnChm5dNjWmZ+KuJZKKNVXh2dqT3kgFw24OVPKS1lNbp/T1gn4+GXlDYUG34rn2 8lrQGEAat8Jk6zPv8OIzy75ykpJMQWQDCp1kVWeacjvoNA+ubmq70WwcrW1peQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786503823; a=rsa-sha256; cv=none; b=dA4Nbvac/G03H6iPf7B1OnVyFJjqN5Qj+dOS+jKrMzcEP6/wjEBQzqt/8dxg5C54+CEgDs 1Gf6osl7TmTN2v2BTmwn2r04rXg9qX063mR5uXD3DlOLwRvRDr026vdDdF94vDnOiFfSnm OgRXFP9UCxdRGoPAcNzyIlyWlQQtrm05+uPkgjFwqqByi4PJ/BqVX6SZfY/y1OoMaLX82C wwRFaSksyRUFKkqKVBV3kQHj8fjGHijgxUbzuV+btUK+LJmFESpfmAqrrZ9qW9YA/QUbEU s62OyL/z2wYVN6x6SW3eyhS1ceEQsmqbjHtoVAejydsc81Lg3cyGWNJlGohKrw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786503823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hboOBemOzRjzah71/CIe00Mt23misBC0ec///gCK4Uo=; b=RwyGg9Mj7BJxwkvbz2TXMiV/PDbhkELNytX0mJLVYa7bFS7YPkDnQS1Lcs7TaM+MR9MvYh iPpnDhr30ue5eVdmbWgq0y1FNoYM5dOWml5M+BUr7eXEpRwJQHR1Zm0aa5Tb4kVVNyDTqV wbBt/qYOYOgodcfUmnbQhrQFQrtJdSmL98HRiGSlgSDChxPTOKLuyBlgPHFTEbtLWFjY7T 7gj5lJ5TfqqGSjzWavmWqTKi2bxHgr5HDOzUbG5UIrJZpXxnW1T9KKze0nyon3HUOcp/Sj 0xolRkxXAM1E6tA131hhhXDZfbpcKtCRfbOovKL+5/PXFDQGZPfJGQRKf0HhRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKYGk6nHJz1Lmj for ; Wed, 12 Aug 2026 03:03:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37b68 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 12 Aug 2026 03:03:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 423927d6c3dc - main - igc: Remove invalid debug ring pointer iteration List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 423927d6c3dc87628fc2a19f25b5b5c07b3b73e2 Auto-Submitted: auto-generated Date: Wed, 12 Aug 2026 03:03:42 +0000 Message-Id: <6a7be28e.37b68.6ed73dc1@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=423927d6c3dc87628fc2a19f25b5b5c07b3b73e2 commit 423927d6c3dc87628fc2a19f25b5b5c07b3b73e2 Author: Kevin Bowling AuthorDate: 2026-08-12 03:03:11 +0000 Commit: Kevin Bowling CommitDate: 2026-08-12 03:03:11 +0000 igc: Remove invalid debug ring pointer iteration The debug routine reads queue registers by queue index. It also advanced unused pointers to rings embedded in queue structures. Those pointers had the wrong stride and could proceed beyond the ring object. Remove the unused pointer arithmetic. MFC after: 2 weeks --- sys/dev/igc/if_igc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index 574cab87c305..359cd1d6dc39 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -3518,8 +3518,6 @@ igc_print_debug_info(struct igc_softc *sc) { device_t dev = iflib_get_dev(sc->ctx); if_t ifp = iflib_get_ifp(sc->ctx); - struct tx_ring *txr = &sc->tx_queues->txr; - struct rx_ring *rxr = &sc->rx_queues->rxr; if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) printf("Interface is RUNNING "); @@ -3531,14 +3529,14 @@ igc_print_debug_info(struct igc_softc *sc) else printf("and ACTIVE\n"); - for (int i = 0; i < sc->tx_num_queues; i++, txr++) { + for (int i = 0; i < sc->tx_num_queues; i++) { device_printf(dev, "TX Queue %d ------\n", i); device_printf(dev, "hw tdh = %d, hw tdt = %d\n", IGC_READ_REG(&sc->hw, IGC_TDH(i)), IGC_READ_REG(&sc->hw, IGC_TDT(i))); } - for (int j=0; j < sc->rx_num_queues; j++, rxr++) { + for (int j = 0; j < sc->rx_num_queues; j++) { device_printf(dev, "RX Queue %d ------\n", j); device_printf(dev, "hw rdh = %d, hw rdt = %d\n", IGC_READ_REG(&sc->hw, IGC_RDH(j)),