From nobody Tue Aug 11 21:00:14 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hKPCM2HqMz6X180 for ; Tue, 11 Aug 2026 21:00:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hKPCL6llBz4CmK for ; Tue, 11 Aug 2026 21:00:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MKWyiEDbiD6Y71VGUaalNW1cNihGt2uovhU9W/774yY=; b=v6DerN+u90/mY+U4GmqypNo8CgIUUIunzJDbe7iwBQmYExBW1dMqJs1lodI2G6n9i4Qn7g 5V+kVYdB52dtJqrYlhzE852Kt1AcEAmK6UXwDI7Ms531VbRQSYwRSRJIcMIaq6HgnDsyaj TP4lhww5ii9wkEiPqpXDLv4XGFF4oUXaPY7OX5ATvOh7DmPPwniYyrELVXFCedNRJoBZcO x+gEjhr6LoiFZ9JwQaOeeMzTXvq+6pXXGyEonczYzIX+cjQQz7wYipyRlAKoQs8Vxow7B9 8D+542jnon+wJEBaeoOhRESRwfr6IpTMmeozsqx6+HLFAOxd6aUb+8nTcEffjw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786482015; a=rsa-sha256; cv=none; b=Tj44oVvUhlxI4AmT96wx8EMLVKNvzZ0EK5jIjwT9ODNxjwJyLQM6Bqd6/8jOI98m+R/XPp +yVjM20jhlNqFbhHdVqxpUS2s5xuU0vkYkkr9ndRrX6FGckXRonldEgjkqqiRdUL7CK/HO A73+C8159Qs614LTv7rY0rDShqakvWbvlAm+3haSkl8lzjt9E2mNHMCNEddxfYVBNJlS2/ OD6/x9RU1pP3ml5VDGJ6eqT/DftbvBRwCKeyHQjvPtibFxjjn4vSwTyR94PifsPNwXRKEl 75/YqVt7aOplWIv48p4mnuCoCrNamn9HoBk+CWEqzwgEU6uGnh4HrqC/fsih6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786482015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MKWyiEDbiD6Y71VGUaalNW1cNihGt2uovhU9W/774yY=; b=n8Zh06ixmXFUyizUaZKV/r1YdnHGdELuh7tAHSNqFW0/PFPy6CmJa9okXLGfizGfO9fche k7RjJBrp11Pog4FMnOfK68ZQ+Ug2t/fiUM9hx15FD+F5/+OJPMDOaCT1iYyh0TgkaSW0QM UrUs09d2O/eDW11U8PRwfiScJ3q0Nq8uJuAw7geymt4cEkHqNceDsFXpbO31u5tl1UNtm8 sDhibl9G3/jJ7LmjQBOGytM2l3t5C5/Exmq/Cn+1pVv1X9ZpapeBwl4W99iYFw/kO1VHsg UgWdUS1WvxXBj9EcxZUQ+jpznPPob9RKe5FzGTyXIwLc76nRhp88SAmrmPQKMw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hKPCL4nSHz19fX for ; Tue, 11 Aug 2026 21:00:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3900a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 11 Aug 2026 21:00:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: f4bf1da7bac8 - main - ixgbe: Avoid a signed shift while assembling the PHY ID List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f4bf1da7bac80cbe3ec862f395c22a3c5d176312 Auto-Submitted: auto-generated Date: Tue, 11 Aug 2026 21:00:14 +0000 Message-Id: <6a7b8d5e.3900a.32c3a348@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f4bf1da7bac80cbe3ec862f395c22a3c5d176312 commit f4bf1da7bac80cbe3ec862f395c22a3c5d176312 Author: Kevin Bowling AuthorDate: 2026-08-11 19:41:07 +0000 Commit: Kevin Bowling CommitDate: 2026-08-11 20:59:34 +0000 ixgbe: Avoid a signed shift while assembling the PHY ID The PHY identifier word is promoted to signed int when the cast is applied after the shift. Cast the 16-bit register value first so identifiers with their high bit set are assembled as unsigned data. MFC after: 2 weeks --- sys/dev/ixgbe/ixgbe_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/ixgbe_phy.c b/sys/dev/ixgbe/ixgbe_phy.c index 4913afd4e6d5..4200d0cd7f68 100644 --- a/sys/dev/ixgbe/ixgbe_phy.c +++ b/sys/dev/ixgbe/ixgbe_phy.c @@ -434,7 +434,7 @@ s32 ixgbe_get_phy_id(struct ixgbe_hw *hw) &phy_id_high); if (status == IXGBE_SUCCESS) { - hw->phy.id = (u32)(phy_id_high << 16); + hw->phy.id = (u32)phy_id_high << 16; status = hw->phy.ops.read_reg(hw, IXGBE_MDIO_PHY_ID_LOW, IXGBE_MDIO_PMA_PMD_DEV_TYPE, &phy_id_low);