git: 275ca86f6abf - main - igc: Avoid a signed multicast bitmap shift
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 11 Aug 2026 20:59:59 UTC
The branch main has been updated by kbowling:
URL: https://cgit.FreeBSD.org/src/commit/?id=275ca86f6abffc4ee6e52a6daab06f5e5c21aa05
commit 275ca86f6abffc4ee6e52a6daab06f5e5c21aa05
Author: Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2026-08-11 19:27:35 +0000
Commit: Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2026-08-11 20:59:32 +0000
igc: Avoid a signed multicast bitmap shift
The multicast hash bit can be 31. Use an unsigned value so setting the
bit cannot shift a signed integer into its sign bit.
MFC after: 2 weeks
---
sys/dev/igc/igc_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/dev/igc/igc_mac.c b/sys/dev/igc/igc_mac.c
index 2afba299e147..6a00867c7a8e 100644
--- a/sys/dev/igc/igc_mac.c
+++ b/sys/dev/igc/igc_mac.c
@@ -387,7 +387,7 @@ void igc_update_mc_addr_list_generic(struct igc_hw *hw,
hash_reg = (hash_value >> 5) & (hw->mac.mta_reg_count - 1);
hash_bit = hash_value & 0x1F;
- hw->mac.mta_shadow[hash_reg] |= (1 << hash_bit);
+ hw->mac.mta_shadow[hash_reg] |= 1U << hash_bit;
mc_addr_list += (ETH_ADDR_LEN);
}