From nobody Mon Aug 10 08:27:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJSYd6Wvcz6nMqj for ; Mon, 10 Aug 2026 08:27:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJSYd5fRdz3hM1 for ; Mon, 10 Aug 2026 08:27:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786350469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wDAPAxhvtb1nyt/8sgv1FL5mzvQ4VB1ldYnoz0mpc9A=; b=bbTK2JV3j4g/rySfXp5wAMOqjzlSmcaUnPbgorLLLbw1sWdkjmzUPwl4ITHFPi5IQXgigX +n2lN/kv2k+2X+O11x/5pzz0Bb+pHmtBWQaibLJl+rOFLpdZLazuRZ9yoyqVCA0z6umJ9Z plh0MJwKuo2C9iYNioldREgPJ7WtRNccjGTgEYJUUGL4FRq4y5KhVfyKNTR8wlfR+IFgUi mcy04hS9wS5y/u77KZ4QquCUszkxNaZD7kvcK1yHydLajsroRRkADqzlr9VMHbkR5BpQcJ pZXSyqNfx49DY8zf15NlZuCkGUoNymlACZic3OkOSIYUB+UbTaozkIuUC85RWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786350469; a=rsa-sha256; cv=none; b=LP4vCkEp4C2nIn8ky9WrYi6u0FwsyswS0RcXtm4zmsMcDquFYYfgacW/jC7WD+H9e7VoMH l6byAvPDOLFEOpcQa/W7mgTDS0T424nk/tNG2Bp1Bx+I3swNbWQ8R2g0Cuq4DDoxCk3Ye+ jlIGPA58mNrworEFtAXg+pU0M+UVQ8e8b/WI9C8sxd4KpKzWamducE2HBxNO+I3vFjzWzK +qq/F0X2w9UQbm0OJiLMu5XrABtyg3GR6FcJtVoLSbLccluNV2F/Tjq8R9RuUXZgXCmUFd 8C+xvtouEyDSYKXYAivUzA2KOFwZKc/cZB2BW1REJszAyMg/5OkZElNXhSas1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786350469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wDAPAxhvtb1nyt/8sgv1FL5mzvQ4VB1ldYnoz0mpc9A=; b=jNtUAMuCtCO5SlY211NwrGDCll8VlJ29C0KoPuYh74QQfyDCNu7HQMIQHIIawJFLbxluyZ gGnabxa6IWxdyYd0orNYxM7bUvU22BTU1+fshLh//s4q9pS1zJ1pSwPTOzBV8Rz0XFkL6b 7c+nT7mHq8nfE7qugw5hEYoPLu7m4U5jmkv9NZyXA8WG71UNnfpThEMqMaGB3O75CIv7yg /eIYOTEHHMfRdLZxhr30oPZXfYHief65JpEXc0iTrfq/ADmk0KEqOXbsOkzHOV026WEwBs X961jZSLUa8ZPo2oya80hwC90gFxEIW0K2NtZU5Zm3eSot2k7VFmpU/xC9ngRA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJSYd49N9z11ql for ; Mon, 10 Aug 2026 08:27:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 251a1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 10 Aug 2026 08:27:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: dd32931271c7 - main - ixl: Honor iflib transmit completion batching List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dd32931271c784caf2c51e27f24514093b81429c Auto-Submitted: auto-generated Date: Mon, 10 Aug 2026 08:27:44 +0000 Message-Id: <6a798b80.251a1.10a53050@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=dd32931271c784caf2c51e27f24514093b81429c commit dd32931271c784caf2c51e27f24514093b81429c Author: Kevin Bowling AuthorDate: 2026-08-10 07:31:48 +0000 Commit: Kevin Bowling CommitDate: 2026-08-10 08:26:31 +0000 ixl: Honor iflib transmit completion batching ixl uses head writeback by default. Hardware publishes the transmit ring head through DMA only after completing a descriptor marked RS. Marking every packet requested much more frequent head updates than iflib needs to reclaim descriptors. iflib marks selected packets with IPI_TX_INTR as completion checkpoints. It forces a checkpoint as deferred work or ring pressure grows. Retain EOP on every packet, but set RS only at those checkpoints. This batches head writebacks while preserving bounded descriptor reclamation. The optional descriptor writeback mode benefits as well. ixl already recorded only IPI_TX_INTR descriptors in its report-status queue, so status written for every other packet was not inspected. DPDK uses the same sparse RS design. Let iflib choose the adaptive interval for FreeBSD. This is a PCIe/memory bandwidth savings. MFC after: 2 weeks --- sys/dev/ixl/ixl_txrx.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/dev/ixl/ixl_txrx.c b/sys/dev/ixl/ixl_txrx.c index bca5abd370f5..d047733ecbbb 100644 --- a/sys/dev/ixl/ixl_txrx.c +++ b/sys/dev/ixl/ixl_txrx.c @@ -332,8 +332,6 @@ ixl_tso_setup(struct tx_ring *txr, if_pkt_info_t pi) * - return 0 on success, positive on failure * **********************************************************************/ -#define IXL_TXD_CMD (I40E_TX_DESC_CMD_EOP | I40E_TX_DESC_CMD_RS) - static int ixl_isc_txd_encap(void *arg, if_pkt_info_t pi) { @@ -345,12 +343,15 @@ ixl_isc_txd_encap(void *arg, if_pkt_info_t pi) bus_dma_segment_t *segs = pi->ipi_segs; struct i40e_tx_desc *txd = NULL; int i, j, mask, pidx_last; - u32 cmd, off, tx_intr; + u32 cmd, off, tx_intr, txd_cmd; cmd = off = 0; i = pi->ipi_pidx; tx_intr = (pi->ipi_flags & IPI_TX_INTR); + txd_cmd = I40E_TX_DESC_CMD_EOP; + if (tx_intr) + txd_cmd |= I40E_TX_DESC_CMD_RS; /* Set up the TSO/CSUM offload */ if (pi->ipi_csum_flags & CSUM_OFFLOAD) { @@ -397,7 +398,7 @@ ixl_isc_txd_encap(void *arg, if_pkt_info_t pi) } /* Set the last descriptor for report */ txd->cmd_type_offset_bsz |= - htole64(((u64)IXL_TXD_CMD << I40E_TXD_QW1_CMD_SHIFT)); + htole64((u64)txd_cmd << I40E_TXD_QW1_CMD_SHIFT); /* Add to report status array (if using TX interrupts) */ if (!vsi->enable_head_writeback && tx_intr) { txr->tx_rsq[txr->tx_rs_pidx] = pidx_last;