From nobody Mon Aug 10 02:31:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hJJfV01QVz6pVLW for ; Mon, 10 Aug 2026 02:31:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hJJfT3w2jz400l for ; Mon, 10 Aug 2026 02:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786329089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T2Ll0EDZLjJlusilWURbMBTe5W2I86j1DLbebsn3h4U=; b=nlkqk6FOX8Fj5wMmFzVbtjbpTgYy1eZ798/mwyKDBse7hSCQD6qonKtBmpNtK+TJ5fOR5d QPtkXZV3pnUn6gMcFnxakXtd8oUjLEzhTlxVsvVnbhuNcyibXZxb+ZpmhN798yOdldePav 23rijybynegCh9KnRLMPDpJXyRcBRF3r+CLHj7HnPGbiMEXBzJyb+TyJfIt6wRoJRpGPSE uJTj1/J0l237FPLJGCLfrL8C0TweFM9SofIgdqEU4PzpT3YEq6glQ2D+jucSPVFubrVBWq qMby/YYImVO7EdtEWZBGNybFruZe2oVpjraKPO+6y12D+PtfqsQO78/2xWH+aQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786329089; a=rsa-sha256; cv=none; b=dtfWFsHuUzr+stIT+fpzZ5zSMyew0sTa7EmrgDYIS2V6BPjX5BaS2hrAHNbyya8/uiGz4G p7BGqq1cn0ycgQ6dUClGdIzKs6g4DZ5Bj9sG2XxrberXVXHIXY3ehG7ofeFFE0eiVDGC1p vq75ezekwjMoFa002zYKGFoM3A7uFE8gi7SDlBa28XkPYshf1r2BuuYhBdARAisdeTNwaF hyrontc4K8I3SH5neNoo7/Wl0d7dK8JrLjra0IGudiL7B8A2hWOudz/u6QORclJVoVnswi R/a7Lgq4ygI9tKoQggui2geYJplummpLobUGWJ75P3JjSzO5xjUbXdZ0tO5EVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786329089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T2Ll0EDZLjJlusilWURbMBTe5W2I86j1DLbebsn3h4U=; b=XbPbGT7AFon9Lkevp6yEtvbUaP16gtEoJJvHS1Lf9U+h4VNbAQ6+aNwe9MKKJl+BT5l8F7 gUqrnbqHUJ4xaAC464pF5tKmg9MAtHUTU1EjFYofGDg5fJ5kv051QuA24RLsmaq1W+9NmL bt0NpdfyarVdbfWpyh4fNt7b3ayABKEwnXuGcsMZ42U7DWCVMj9p073cOgPsA0XEYw5t8r P7U1zsfSLxWUlZEOTu7tz9kMTpk7+Tu4ctFvznRgP9LFhNbgPkxwa4n1Ts3jEElMSsNarI HBe7+ZXINoOZS1RFQjLSFL9/KmHZwLlmJtekZfrNE1HXpc6271oPNa8nj1wLdw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hJJfT2B6Mzqbf for ; Mon, 10 Aug 2026 02:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cdee by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 10 Aug 2026 02:31:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jaeyoon Choi Subject: git: af00e00f23a1 - main - ufshci: initialize desc_size for non-descriptor query requests List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jaeyoon X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: af00e00f23a1d427d96fecbb39e276fc2d7dfde1 Auto-Submitted: auto-generated Date: Mon, 10 Aug 2026 02:31:29 +0000 Message-Id: <6a793801.1cdee.1f386bae@gitrepo.freebsd.org> The branch main has been updated by jaeyoon: URL: https://cgit.FreeBSD.org/src/commit/?id=af00e00f23a1d427d96fecbb39e276fc2d7dfde1 commit af00e00f23a1d427d96fecbb39e276fc2d7dfde1 Author: Jaeyoon Choi AuthorDate: 2026-08-10 01:47:38 +0000 Commit: Jaeyoon Choi CommitDate: 2026-08-10 02:28:52 +0000 ufshci: initialize desc_size for non-descriptor query requests The flag and attribute query builders left param.desc_size uninitialized, so stack garbage was sent as the query UPIU length field. Devices generally ignore the length for these opcodes, which hid the bug. Zero it explicitly. Sponsored by: Samsung Electronics Reviewed by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D58665 --- sys/dev/ufshci/ufshci_dev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/ufshci/ufshci_dev.c b/sys/dev/ufshci/ufshci_dev.c index 454572f966d5..18546d7120c0 100644 --- a/sys/dev/ufshci/ufshci_dev.c +++ b/sys/dev/ufshci/ufshci_dev.c @@ -86,6 +86,7 @@ ufshci_dev_read_flag(struct ufshci_controller *ctrlr, param.index = 0; param.selector = 0; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -118,6 +119,7 @@ ufshci_dev_set_flag(struct ufshci_controller *ctrlr, param.index = 0; param.selector = 0; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -148,6 +150,7 @@ ufshci_dev_clear_flag(struct ufshci_controller *ctrlr, param.index = 0; param.selector = 0; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -179,6 +182,7 @@ ufshci_dev_read_attribute(struct ufshci_controller *ctrlr, param.index = index; param.selector = selector; param.value = 0; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr, @@ -212,6 +216,7 @@ ufshci_dev_write_attribute(struct ufshci_controller *ctrlr, param.index = index; param.selector = selector; param.value = value; + param.desc_size = 0; status.done = 0; error = ufshci_ctrlr_cmd_send_query_request(ctrlr,