Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently

> On Apr 27, 2026, at 11:36 AM, Simon J. Gerraty <sjg@juniper.net> wrote:
> 
> Dag-Erling Smørgrav <des@freebsd.org> wrote:
>>> The goal here is to ensure a line like that will be ignored.
>> 
>> That's beside the point, which is that your regex is incorrect.  It will
>> treat e.g. `:foo` as a comment.
> 
> Which is fine by me.
> 
> That is not a syntax one commonly expects to see in rc.conf.d/*
> 
> safe_eval is used it sitations where we are paranoid,
> normally only wanting to read *verified* input, but there are exceptions
> to every rule, and the goal of safe_set is to ensure nothing wicked gets
> eval'd.  So I don't mind rejecting :foo=bar

	Using `:` as a comment marker seems a bit esoteric (at best) — especially when it has other meanings in /bin/sh .
	I'd vote for reverting the change personally, but I’m not going to be adamant about it.
Cheers,
-Enji