git: 19fb4df14257 - stable/15 - sctp: fix socket type created by sctp_peeloff()

The branch stable/15 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=19fb4df1425706119b78769031def4bf6f131340

commit 19fb4df1425706119b78769031def4bf6f131340
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2026-01-31 18:11:08 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2026-04-26 07:47:26 +0000

    sctp: fix socket type created by sctp_peeloff()
    
    When calling sctp_peeloff() on a SOCK_SEQPACKET socket, the created
    and returned socket has the type SOCK_STREAM.
    This is specified in section 9.2 of RFC 6458.
    
    Reported by:    Xin Long
    MFC after:      3 days
    Event:          Wiesbaden Hackathon 2026
    
    (cherry picked from commit d195b3783fa4de5c1a95f6d95eb9444abce6778b)
---
 sys/kern/uipc_socket.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c
index b7e4646fea68..91a3717b876f 100644
--- a/sys/kern/uipc_socket.c
+++ b/sys/kern/uipc_socket.c
@@ -1303,7 +1303,7 @@ solisten_enqueue(struct socket *so, int connstatus)
 
 #if defined(SCTP) || defined(SCTP_SUPPORT)
 /*
- * Socket part of sctp_peeloff().  Detach a new socket from an
+ * Socket part of sctp_peeloff().  Create a new socket for an
  * association.  The new socket is returned with a reference.
  *
  * XXXGL: reduce copy-paste with solisten_clone().
@@ -1315,6 +1315,8 @@ sopeeloff(struct socket *head)
 
 	VNET_ASSERT(head->so_vnet != NULL, ("%s:%d so_vnet is NULL, head=%p",
 	    __func__, __LINE__, head));
+	KASSERT(head->so_type == SOCK_SEQPACKET,
+	    ("%s: unexpecte so_type: %d", __func__, head->so_type));
 	so = soalloc(head->so_vnet);
 	if (so == NULL) {
 		log(LOG_DEBUG, "%s: pcb %p: New socket allocation failure: "
@@ -1322,7 +1324,7 @@ sopeeloff(struct socket *head)
 		    __func__, head->so_pcb);
 		return (NULL);
 	}
-	so->so_type = head->so_type;
+	so->so_type = SOCK_STREAM;
 	so->so_options = head->so_options;
 	so->so_linger = head->so_linger;
 	so->so_state = (head->so_state & SS_NBIO) | SS_ISCONNECTED;