git: 3df5cc33d894 - main - ctld: Ports without a portal group are not dummy ports
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 23 Apr 2026 19:17:48 UTC
The branch main has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=3df5cc33d894edd6b0ae87e51f0e35c3501fb907
commit 3df5cc33d894edd6b0ae87e51f0e35c3501fb907
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2026-04-23 19:16:08 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-04-23 19:16:08 +0000
ctld: Ports without a portal group are not dummy ports
The default implementation of is_dummy should return false. Only
portal group ports should possibly return true.
PR: 293076
Reported by: Ken J. Thomson <thomsonk@yandex.com>
Fixes: 6acc7afa34aa ("ctld: Convert struct port to a hierarchy of C++ classes")
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D56524
---
usr.sbin/ctld/ctld.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usr.sbin/ctld/ctld.hh b/usr.sbin/ctld/ctld.hh
index 11bda5f25f8c..a1bd5a62cf3b 100644
--- a/usr.sbin/ctld/ctld.hh
+++ b/usr.sbin/ctld/ctld.hh
@@ -269,7 +269,7 @@ struct port {
virtual struct auth_group *auth_group() const { return nullptr; }
virtual struct portal_group *portal_group() const { return nullptr; }
- virtual bool is_dummy() const { return true; }
+ virtual bool is_dummy() const { return false; }
virtual void clear_references();