Re: git: f3bd86ba1851 - main - freebsd-version(1): Disable pathname expansion in -j option
- Reply: Dag-Erling_Smørgrav : "Re: git: f3bd86ba1851 - main - freebsd-version(1): Disable pathname expansion in -j option"
- In reply to: Jessica Clarke : "Re: git: f3bd86ba1851 - main - freebsd-version(1): Disable pathname expansion in -j option"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 22 Apr 2026 21:48:32 UTC
Hi, On 4/23/26 00:53, Jessica Clarke wrote: >> -set -e >> +set -ef > > This is a big hammer that could lead to quite surprising results. Is > there a reason we don’t just quote things appropriately? Or at least > limit the scope of set -f to be only around specific places. > > Jessica You're right, quoting the variable alone would be enough for this. However, I reviewed the code and found the patch acceptable. I didn't found any issues with set -f for freebsd-version. I've added @des (original author) to this loop to get his feedback on whether we should revert the `set -f` part. Thank you for raising this! -- Pouria