Re: git: c0d9a07101a1 - main - MFV: zstd 1.5.7.

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Sat, 18 Apr 2026 12:04:31 UTC
On Wed, 8 Apr 2026, Xin LI wrote:

> The branch main has been updated by delphij:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=c0d9a07101a1e72769ee0619a583f63a078fb391
>
> commit c0d9a07101a1e72769ee0619a583f63a078fb391
> Merge: dd201e407e48 7e509d50854e
> Author:     Xin LI <delphij@FreeBSD.org>
> AuthorDate: 2026-04-08 21:22:45 +0000
> Commit:     Xin LI <delphij@FreeBSD.org>
> CommitDate: 2026-04-08 21:22:45 +0000
>
>    MFV: zstd 1.5.7.
>
>    MFC after:      2 weeks
>    Relnotes:       yes

gcc buildworld (not kernel) complains about

  310962 /usr/local/bin/x86_64-unknown-freebsd14.3-ld: /obj/freebsd-src/amd64.amd64/tmp/usr/lib/libzpool.so: undefined reference to `ZSTD_XXH64'
  310963 /usr/local/bin/x86_64-unknown-freebsd14.3-ld: /obj/freebsd-src/amd64.amd64/tmp/usr/lib/libzpool.so: undefined reference to `ZSTD_XXH64_digest'
  310964 /usr/local/bin/x86_64-unknown-freebsd14.3-ld: /obj/freebsd-src/amd64.amd64/tmp/usr/lib/libzpool.so: undefined reference to `ZSTD_XXH64_reset'
  310965 /usr/local/bin/x86_64-unknown-freebsd14.3-ld: /obj/freebsd-src/amd64.amd64/tmp/usr/lib/libzpool.so: undefined reference to `ZSTD_XXH64_update'
  310966 /usr/local/bin/x86_64-unknown-freebsd14.3-ld: /obj/freebsd-src/amd64.amd64/tmp/usr/lib/libzpool.so: undefined reference to `ZSTD_isError'

Do we need to add them to sys/contrib/zstd/lib/common/xxhash.h or how do we get them exported?

-- 
Bjoern A. Zeeb                                                     r15:7