Re: git: 688e289ee904 - main - ifconfig: Add support for geneve (netlink)

From: Kristof Provost <kp_at_FreeBSD.org>
Date: Thu, 16 Apr 2026 22:21:51 UTC 
On 13 Apr 2026, at 16:16, Pouria Mousavizadeh Tehrani wrote:
> The branch main has been updated by pouria:
>
> URL: 
> https://cgit.FreeBSD.org/src/commit/?id=688e289ee904fe625d92f93680a71753d03ba2ee
>
> commit 688e289ee904fe625d92f93680a71753d03ba2ee
> Author:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
> AuthorDate: 2026-04-11 18:38:41 +0000
> Commit:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
> CommitDate: 2026-04-13 14:15:01 +0000
>
>     ifconfig: Add support for geneve (netlink)
>
>     This implementation is netlink only
>
>     Differential Revision: https://reviews.freebsd.org/D55184

This fails to build if WITHOUT_NETLINK_SUPPORT=yes is set.

I think we need this:

	diff --git a/sbin/ifconfig/Makefile b/sbin/ifconfig/Makefile
	index cc518693c2f5..26391023d54a 100644
	--- a/sbin/ifconfig/Makefile
	+++ b/sbin/ifconfig/Makefile
	@@ -30,7 +30,6 @@ SRCS+=        ifmedia.c               # 
SIOC[GS]IFMEDIA support
	 SRCS+= iffib.c                 # non-default FIB support
	 SRCS+= ifvlan.c                # SIOC[GS]ETVLAN support
	 SRCS+= ifvxlan.c               # VXLAN support
	-SRCS+= ifgeneve.c              # GENEVE support
	 SRCS+= ifgre.c                 # GRE keys etc
	 SRCS+= ifgif.c                 # GIF reversed header workaround
	 SRCS+= ifipsec.c               # IPsec VTI
	@@ -67,6 +66,7 @@ LIBADD+=      nv

	 .if ${MK_NETLINK_SUPPORT} != "no"
	 SRCS+= ifconfig_netlink.c
	+SRCS+= ifgeneve.c              # GENEVE support
	 .else
	 CFLAGS+=-DWITHOUT_NETLINK
	 .endif

Best regards,
Kristof