Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets
Date: Wed, 15 Apr 2026 14:48:38 UTC
On 4/14/26 18:13, Gleb Smirnoff wrote:
> On Tue, Apr 14, 2026 at 06:37:18PM +0000, John Baldwin wrote:
> J> The branch main has been updated by jhb:
> J>
> J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4
> J>
> J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4
> J> Author: John Baldwin <jhb@FreeBSD.org>
> J> AuthorDate: 2026-04-14 18:07:51 +0000
> J> Commit: John Baldwin <jhb@FreeBSD.org>
> J> CommitDate: 2026-04-14 18:07:51 +0000
> J>
> J> tcp_close: Use in6_pcbdisconnect for INET6 sockets
> J>
> J> This also fixes the LINT-NOINET builds.
> J>
> J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()")
>
> I think this change is also required.
>
> Almost sure it will fix panic observed by Navdeep.
Yes, I had missed that when comparing the two.
Given how similar this functions are, I wonder if in_pcbdisconnect() should be a shared
method that just has a few AF-specific bits of code? The old in_pcbdrop() function was
shared and not INET vs INET6 specific.
--
John Baldwin