From nobody Sat Apr 11 11:02:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ft9kg6lvVz6YJVv for ; Sat, 11 Apr 2026 11:03:07 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ft9kg618Gz3lVt for ; Sat, 11 Apr 2026 11:03:07 +0000 (UTC) (envelope-from lwhsu@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775905387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OhsINEgOWpwukSK/ve/hjp7F9ghMwaCsisd1kYWPlgI=; b=H48oZHM4b8vxvP7ac5dB0aeT27jYljVhv/6cTjcPgE3EaiLmWYf0BP1F1ycg59fyvdnN2Z sjdibvMnxS+dM5vEtuMipMKO+1UVcJtoG89ZlJVt3vZk2hdTYklNanVtq201suLHDgeheX YfYEpMzXRKmW1ZvVi9hbhxHKj73Y/Kr8x3F54lwm9a1TxrScPlB08kyYGpJQhs0t7wW4Iw LDdeif9ScvwdjcBwwrX2A16iaFhepLxdSWZYvKuagAmkntK0znC+StyZjhx7JSiPGcqmW/ j+Yy7x+dMaLW7/7/Q4TwFa4pB6YcNCGn8LqCIBgapzJf3oHkPv5JzP6wrgNsdQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775905387; a=rsa-sha256; cv=none; b=fLPKjuEwNV+d8Y5lCz7xrNTVCvcjrt/uAhgdvBGhdPUNh6chYYgVqezszHBGFJ+G8KIpxL 2zvlAFFDozky+eN4eM8hxErFrKNhP+mxHOF66IOIbTzUIBYd54SO7z0/ISloew2zMK+ESD L5MOkWi/UhtOcZVKDD9BllJTWOVGa9bhoL4B9UJgMVR/fRRozQvIHBBbTspJTwI35EsCSq STnRGhW61QCp0HercPlcmFKh7b35qqEDM2G0YVH+wLsEuApTYgJXFAzdHzD+LIc8OMmoMZ AHBgkRayhIpPSZtHQEDqORr/iQ8mK23W5Q6rjC7ApZzaoCS3Y2akrkJ68SmL4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775905387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OhsINEgOWpwukSK/ve/hjp7F9ghMwaCsisd1kYWPlgI=; b=t26+6w2qR2eOHlRUxe5G79aZLr8zxdxW4PYMCOW9Bs8tywzPv4k8tX2LsBYHZx7nHYCC5c 55ft/Da4HcaOrEwiDmPTArxl9RDY7+u+BGN9cM28SDIW2AyR5ZLQyl5lCBjuOWwptgO2J3 1Z4HPs98f5BsrU1/wRi/a6uVOhDzyj6ltrH2zQLo8rj2hg9fSHxNmcCQhSQwUUGVjoOWHN Q46Z3FNZcVv9ZCfrc9TWAUgb8/Q6HCODQC1Yvpfhm4qGL8t+n+B8PkHeoZw+92aL76lv5v 52Q16pgAsPiFaucARfl1+rIogZfPzwDsD1EgzksGQJxalfFNZ+lmMj2KZmI++A== Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: lwhsu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ft9kg4djwzpfV for ; Sat, 11 Apr 2026 11:03:07 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7d55b97f358so1780185a34.3 for ; Sat, 11 Apr 2026 04:03:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW9DKvSjpJoiqKJBY02vG8r4c0xfAdMb7af6QFmtmul07/5ijGEQrBchQ8hwn7kGw4jAmWwsdmznXArrLm5IQvc8l4l@freebsd.org X-Gm-Message-State: AOJu0YwdWN/EF61WWxEGVjeOKUBqwzDxgkxoWAONHF0Dn7EyKVApnyEZ BqdoTJEaVOd2yBZIGMvesmT6xDMxd5GbUgZvI9eaLQqhLjKQI9HwZeqtqkp9W4aMR0q+SSFVLd2 STnYm8hD1tjkFZyOnkvSMLQ+XoqySmko= X-Received: by 2002:a05:6830:6a8e:b0:7d4:4af4:b7d4 with SMTP id 46e09a7af769-7dc27c64607mr3980925a34.1.1775905386925; Sat, 11 Apr 2026 04:03:06 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69d6c795.18adf.7af84449@gitrepo.freebsd.org> <60q35572-pprr-op23-p392-266469oon60@mnoonqbm.arg> In-Reply-To: From: Li-Wen Hsu Date: Sat, 11 Apr 2026 19:02:56 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AQROBzAV247s24-GMrpCfLGZpoC7zoQ7ToDMZ874f428jJnSDbxHzORdN0vuPIU Message-ID: Subject: Re: git: c0d9a07101a1 - main - MFV: zstd 1.5.7. To: Michael Tuexen Cc: Xin Li , Adrian Chadd , "Bjoern A. Zeeb" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000be175e064f2d3185" --000000000000be175e064f2d3185 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Apr 11, 2026 at 18:32 Li-Wen Hsu wrote: > On Sat, Apr 11, 2026 at 3:25=E2=80=AFPM Michael Tuexen wrote: > >> > On 11. Apr 2026, at 06:56, Xin Li wrote: >> > >> > On 2026-04-10 21:00, Adrian Chadd wrote: >> >> hi! >> >> Same; this is breaking on my Snapdragon X1E FDT BSP work. >> >> It fails super early in kernel hand-off. It's going to be a pain to >> >> figure out locally as I have a framebuffer and I'd have to go do all >> >> the early mapping to do super early (in initarm()) framebuffer work. >> >> Is this reproducible by anyone else? delphij@, do you have any arm64 >> >> FDT devices? Or maybe QEMU? >> > >> > bz@ and lwhsu@ did some diagnostic work, and this should help (adding >> -DZSTD_NO_TRACE to ZSTD_C) >> > >> > diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk >> > index 871cd1c0705a..043d3fd0927c 100644 >> > --- a/sys/conf/kern.pre.mk >> > +++ b/sys/conf/kern.pre.mk >> > @@ -158,7 +158,7 @@ NORMAL_FWO=3D ${CC:N${CCACHE_BIN}} -c ${ASM_CFLAGS= } >> ${WERROR} -o ${.TARGET} \ >> > NOSAN_C=3D ${NORMAL_C:N-fsanitize*:N-fno-sanitize*:N-fasan-shadow-offs= et*} >> > >> > # for ZSTD in the kernel (include zstd/lib/freebsd before other CFLAGS= ) >> > -ZSTD_C=3D ${CC} -c -DZSTD_HEAPMODE=3D1 -I$S/contrib/zstd/lib/freebsd >> ${CFLAGS} \ >> > +ZSTD_C=3D ${CC} -c -DZSTD_NO_TRACE -DZSTD_HEAPMODE=3D1 >> -I$S/contrib/zstd/lib/freebsd ${CFLAGS} \ >> > -I$S/contrib/zstd/lib -I$S/contrib/zstd/lib/common ${WERROR} \ >> > -Wno-missing-prototypes -U__BMI__ -DZSTD_NO_INTRINSICS ${.IMPSR= C} >> > # https://github.com/facebook/zstd/commit/812e8f2a [zstd 1.4.1] >> Should building a new kernel with this patch resolve the issue or >> is a buildworld/installworld required? >> >> I tested building a new kernel with this patch and it does not resolve t= he >> issue for me (VirtualBox VM on macOS and QEMU on Rasbian). > > > I haven't tested this one, the original patch was adding: > > #define ZSTD_TRACE 0 > > to > > sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.h > > This fixes my case running in QEMU. > I also tested the version modifies sys/conf/kern.pre.mk and it works. It should be the better fix. Best regards >> Michael >> > >> > >> > >> >> -adrian >> >> On Thu, 9 Apr 2026 at 19:31, Bjoern A. Zeeb wrote: >> >>> >> >>> On Wed, 8 Apr 2026, Xin LI wrote: >> >>> >> >>>> The branch main has been updated by delphij: >> >>>> >> >>>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3Dc0d9a07101a1e72769ee0619a583f6= 3a078fb391 >> >>>> >> >>>> commit c0d9a07101a1e72769ee0619a583f63a078fb391 >> >>>> Merge: dd201e407e48 7e509d50854e >> >>>> Author: Xin LI >> >>>> AuthorDate: 2026-04-08 21:22:45 +0000 >> >>>> Commit: Xin LI >> >>>> CommitDate: 2026-04-08 21:22:45 +0000 >> >>>> >> >>>> MFV: zstd 1.5.7. >> >>>> >> >>>> MFC after: 2 weeks >> >>>> Relnotes: yes >> >>> >> >>> I do not know how but this makes an arm64 machine, >> >>> doing a UEFI netboot (in case it matters) fetching the >> /boot/loader.efi, >> >>> to fail. >> >>> Kernel is the GENERIC-MMCCAM and I do not do ZFS, just to be sure. >> >>> >> >>> See this thread for a "bisect" and symptoms: >> >>> https://lists.freebsd.org/archives/freebsd-arm/2026-April/005757.htm= l >> >>> >> >>> /bz >> >>> >> >>> -- >> >>> Bjoern A. Zeeb >> r15:7 >> >>> >> > >> > >> >> >> --000000000000be175e064f2d3185 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Apr 11, 2026 at 18:32 Li-Wen Hsu <lwhsu@freebsd.org> wrote:
On Sat, Apr 11, 2= 026 at 3:25=E2=80=AFPM Michael Tuexen <tuexen@freebsd.org> wrote:
> On 11. Apr 2026, at 06:56, Xin Li &= lt;delphij@freebsd= .org> wrote:
>
> On 2026-04-10 21:00, Adrian Chadd wrote:
>> hi!
>> Same; this is breaking on my Snapdragon X1E FDT BSP work.
>> It fails super early in kernel hand-off. It's going to be a pa= in to
>> figure out locally as I have a framebuffer and I'd have to go = do all
>> the early mapping to do super early (in initarm()) framebuffer wor= k.
>> Is this reproducible by anyone else? delphij@, do you have any arm= 64
>> FDT devices? Or maybe QEMU?
>
> bz@ and lwhsu@ did some diagnostic work, and this should help (adding = -DZSTD_NO_TRACE to ZSTD_C)
>
> diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk
> index 871cd1c0705a..043d3fd0927c 100644
> --- a/sys/conf/kern.pre.mk
> +++ b/sys/conf/kern.pre.mk
> @@ -158,7 +158,7 @@ NORMAL_FWO=3D ${CC:N${CCACHE_BIN}} -c ${ASM_CFLAGS= } ${WERROR} -o ${.TARGET} \
> NOSAN_C=3D ${NORMAL_C:N-fsanitize*:N-fno-sanitize*:N-fasan-shadow-offs= et*}
>
> # for ZSTD in the kernel (include zstd/lib/freebsd before other CFLAGS= )
> -ZSTD_C=3D ${CC} -c -DZSTD_HEAPMODE=3D1 -I$S/contrib/zstd/lib/freebsd = ${CFLAGS} \
> +ZSTD_C=3D ${CC} -c -DZSTD_NO_TRACE -DZSTD_HEAPMODE=3D1 -I$S/contrib/z= std/lib/freebsd ${CFLAGS} \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 -I$S/contrib/zstd/lib -I$S/contrib/zstd/lib= /common ${WERROR} \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 -Wno-missing-prototypes -U__BMI__ -DZSTD_NO= _INTRINSICS ${.IMPSRC}
> # https://github.com/facebook/zstd/commit/812e8= f2a [zstd 1.4.1]
Should building a new kernel with this patch resolve the issue or
is a buildworld/installworld required?

I tested building a new kernel with this patch and it does not resolve the<= br> issue for me (VirtualBox VM on macOS and QEMU on Rasbian).

I h= aven't tested this one, the original patch was adding:

#define ZSTD_TRACE 0

to

sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.h

This fixes my case running in QEMU.

I also tested the vers= ion modifies=C2=A0
sys/conf/kern.pre.mk=C2=A0and it works. = It should be the better fix.

Best regards
Michael
>
>
>
>> -adrian
>> On Thu, 9 Apr 2026 at 19:31, Bjoern A. Zeeb <bz@freebsd.org> wrote:
>>>
>>> On Wed, 8 Apr 2026, Xin LI wrote:
>>>
>>>> The branch main has been updated by delphij:
>>>>
>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0d9a07101a1e72769ee0619a583f= 63a078fb391
>>>>
>>>> commit c0d9a07101a1e72769ee0619a583f63a078fb391
>>>> Merge: dd201e407e48 7e509d50854e
>>>> Author:=C2=A0 =C2=A0 =C2=A0Xin LI <delphij@FreeBSD.org&= gt;
>>>> AuthorDate: 2026-04-08 21:22:45 +0000
>>>> Commit:=C2=A0 =C2=A0 =C2=A0Xin LI <delphij@FreeBSD.org&= gt;
>>>> CommitDate: 2026-04-08 21:22:45 +0000
>>>>
>>>>=C2=A0 =C2=A0 MFV: zstd 1.5.7.
>>>>
>>>>=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 2 weeks
>>>>=C2=A0 =C2=A0 Relnotes:=C2=A0 =C2=A0 =C2=A0 =C2=A0yes
>>>
>>> I do not know how but this makes an arm64 machine,
>>> doing a UEFI netboot (in case it matters) fetching the /boot/l= oader.efi,
>>> to fail.
>>> Kernel is the GENERIC-MMCCAM and I do not do ZFS, just to be s= ure.
>>>
>>> See this thread for a "bisect" and symptoms:
>>> https://lists.free= bsd.org/archives/freebsd-arm/2026-April/005757.html
>>>
>>> /bz
>>>
>>> --
>>> Bjoern A. Zeeb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r15:7
>>>
>
>


--000000000000be175e064f2d3185--