Re: git: 3a01e1e1a50c - main - msun/aarch64: convert fenv functions to proper linkage
- In reply to: Dima Panov : "git: 3a01e1e1a50c - main - msun/aarch64: convert fenv functions to proper linkage"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 06 Apr 2026 17:32:52 UTC
On Mon, Apr 06, 2026 at 08:25:02PM +0300, Dima Panov wrote:
>
>
> On 06.04.2026 20:05, Konstantin Belousov wrote:
> > diff --git a/lib/msun/arm/Makefile.inc b/lib/msun/arm/Makefile.inc
> > index 6e3ddb351dd3..e155f1a2cae4 100644
> > --- a/lib/msun/arm/Makefile.inc
> > +++ b/lib/msun/arm/Makefile.inc
> > @@ -1,5 +1,4 @@
> > LDBL_PREC = 53
> > -SYM_MAPS += ${.CURDIR}/arm/Symbol.map
>
> Nope, amd64 is also have Symbol.map included in Makefile.inc
>
> --- a/lib/msun/aarch64/Makefile.inc
> +++ b/lib/msun/aarch64/Makefile.inc
> @@ -12,3 +12,5 @@ CFLAGS+=-DUSE_BUILTIN_FMIN
>
> CFLAGS+=-DUSE_BUILTIN_SQRTF
> CFLAGS+=-DUSE_BUILTIN_SQRT
> +
> +SYM_MAPS += ${.CURDIR}/aarch64/Symbol.map
>
> and no need to patch msun/Makefile with additional checks/includes
It can be done generically, so it is better to be done that way.
The patch is preliminary anyway, I will do the pass over all arches.