Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217

On 9/21/25 20:56, Gleb Smirnoff wrote:
> On Sun, Sep 21, 2025 at 06:02:24PM +0200, Guido Falsi wrote:
> G> A C program would have included the system include and noticed the change,
> G> but this software has hardcoded the struct in go code and requires
> G> patching.
> G>
> G> I'm attaching a simple patch for the ports tree for this port, it compiles
> G> but I've not tested it at runtime, could you try applying this patch to the
> G> ports tree and recompile the port, and report back?
> G>
> G> Please note this is not a proper patch for the ports tree, it just fixes
> G> the problem, but would break it for anyone else, I'll produce a proper
> G> patch for the ports tree once I have confirmed the approach woks.
> 
> Is struct nd_ifinfo something that is used as argument to ioctl(2)?
> If so, then adding counter_u64_t into it is not correct.
> 
> I would suggest to not revert the change as a whole, but remove the
> counter only and bring struct nd_ifinfo back to original.  The counter
> should probably go into struct in6_ifextra that is pointed by
> if->if_afdata[AF_INET6].

Thanks for the feedback and suggestion!

You are definitely right! I'm in the process to create a review for such 
a change shortly, I'll post it as soon as I'm able to have the code tested.

-- 
Guido Falsi <madpilot@FreeBSD.org>