Re: git: d20c82507278 - main - Revert "libc: Remove readdir_r(3)"

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Thu, 11 Sep 2025 19:40:17 UTC 
On 9/11/25 12:57, Warner Losh wrote:
> On Thu, Sep 11, 2025 at 10:27 AM Olivier Cochard-Labbé <olivier@freebsd.org>
> wrote:
> 
>>
>> On Thu, Sep 11, 2025 at 8:12 AM Dag-Erling Smørgrav <des@freebsd.org>
>> wrote:
>>
>>> The branch main has been updated by des:
>>>
>>> URL:
>>> https://cgit.FreeBSD.org/src/commit/?id=d20c82507278e003f391c3fb04f4e49afd1537ab
>>>
>>> commit d20c82507278e003f391c3fb04f4e49afd1537ab
>>> Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
>>> AuthorDate: 2025-09-11 15:12:22 +0000
>>> Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
>>> CommitDate: 2025-09-11 15:12:22 +0000
>>>
>>>      Revert "libc: Remove readdir_r(3)"
>>>
>>>      This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4.
>>>
>>>
>> Hi Dag-Erling,
>> Could you please explain why this change was reversed?
>> Because the reason was missing from this commit message.
>>
> 
> Rust breaks with this change. While rust can be fixed (and will be) since
> it's doing some sketch things and the fix is to just remove the sketch
> stuff. However, part of Rust's work flow is to do A/B testing between new
> runs under test, and older Rust versions. The old binaries work fine, but
> newly-built copies of the old versions do not. Until those old versions
> 'age out' of this setup, we'll be stuck with this.

That's a good reason, but I think the point about the commit log stands.
A commit log for a revert that is unedited and just "Revert foo" isn't
useful.  Developers need to edit the log message to add the why.  The above
paragraph belonged in the commit log.

-- 
John Baldwin