git: f51d7d5139a7 - main - kern_thr_exit(): clear kASTs in advance

From: Konstantin Belousov <kib_at_FreeBSD.org>
Date: Tue, 09 Sep 2025 03:06:13 UTC
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=f51d7d5139a76d225c9f537bd948525ababdef0c

commit f51d7d5139a76d225c9f537bd948525ababdef0c
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2025-09-08 03:43:09 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2025-09-09 02:51:08 +0000

    kern_thr_exit(): clear kASTs in advance
    
    PR:     289204
    Reviewed by:    markj
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D52421
---
 sys/kern/kern_thr.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/sys/kern/kern_thr.c b/sys/kern/kern_thr.c
index 0e8c2b9f362e..4329959a2ef4 100644
--- a/sys/kern/kern_thr.c
+++ b/sys/kern/kern_thr.c
@@ -346,6 +346,17 @@ kern_thr_exit(struct thread *td)
 
 	p = td->td_proc;
 
+	/*
+	 * Clear kernel ASTs in advance of selecting the last exiting
+	 * thread and acquiring schedulers locks.  It is fine to
+	 * clear the ASTs here even if we are not going to exit after
+	 * all.  On the other hand, leaving them pending could trigger
+	 * execution in subsystems in a context where they are not
+	 * prepared to handle top kernel actions, even in execution of
+	 * an unrelated thread.
+	 */
+	ast_kclear(td);
+
 	/*
 	 * If all of the threads in a process call this routine to
 	 * exit (e.g. all threads call pthread_exit()), exactly one