Re: git: af60084978a4 - main - Add description for WITH_PTHREADS_ASSERTIONS
Date: Fri, 05 Sep 2025 22:07:39 UTC
On 9/5/25 14:57, Nuno Teixeira wrote: > For people that turn off debug on main, should WITH_PTHREADS_ASSERTIONS be > turned off? > > e.g. > /etc/src.conf: > WITH_MALLOC_PRODUCTION=yes > WITHOUT_LLVM_ASSERTIONS=yes According to commit 642cd511028b running WITHOUT_PTHREADS_ASSERTIONS improves mutex performance by 5-18%. So yes if you want maximal performance on HEAD you should probably turn this off. Colin Percival > > Thanks, > > Colin Percival <cperciva@freebsd.org <mailto:cperciva@freebsd.org>> escreveu > (sexta, 5/09/2025 à(s) 22:36): > > The branch main has been updated by cperciva: > > URL: https://cgit.FreeBSD.org/src/commit/? > id=af60084978a43632c5ab2d6e3aca41be7a658d8c <https://cgit.FreeBSD.org/src/ > commit/?id=af60084978a43632c5ab2d6e3aca41be7a658d8c> > > commit af60084978a43632c5ab2d6e3aca41be7a658d8c > Author: Colin Percival <cperciva@FreeBSD.org> > AuthorDate: 2025-09-05 21:29:51 +0000 > Commit: Colin Percival <cperciva@FreeBSD.org> > CommitDate: 2025-09-05 21:35:53 +0000 > > Add description for WITH_PTHREADS_ASSERTIONS > > This option is turned on by default in -CURRENT but will be turned off > in 15-STABLE; this description will land in the src.conf(5) man page > in that branch. > > MFC after: 1 minute > --- > tools/build/options/WITH_PTHREADS_ASSERTIONS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/build/options/WITH_PTHREADS_ASSERTIONS b/tools/build/ > options/WITH_PTHREADS_ASSERTIONS > new file mode 100644 > index 000000000000..03c15b76fb85 > --- /dev/null > +++ b/tools/build/options/WITH_PTHREADS_ASSERTIONS > @@ -0,0 +1 @@ > +Enable debugging assertions in pthreads library. > > > > -- > Nuno Teixeira > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org <https:// > FreeBSD.org> -- Colin Percival FreeBSD Release Engineering Lead & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid