Re: git: a930cc8bad64 - main - GEOM_UNION: Should free sc in g_union_ctl_create when error happened.

On 9/5/25 14:42, Warner Losh wrote:
> The branch main has been updated by imp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=a930cc8bad644039cfcfa5ff7c6fe3e8548aa9ae
> 
> commit a930cc8bad644039cfcfa5ff7c6fe3e8548aa9ae
> Author:     Wuyang Chung <wy-chung@outlook.com>
> AuthorDate: 2025-09-02 06:23:26 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2025-09-05 18:42:20 +0000
> 
>      GEOM_UNION: Should free sc in g_union_ctl_create when error happened.
>      
>      Signed-off-by: Wuyang Chung <wy-chung@outlook.com>
>      Reviewed by: imp
>      Pull Request: https://github.com/freebsd/freebsd-src/pull/1835
> ---
>   sys/geom/union/g_union.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sys/geom/union/g_union.c b/sys/geom/union/g_union.c
> index 9734fc1bcfe3..0701e76db671 100644
> --- a/sys/geom/union/g_union.c
> +++ b/sys/geom/union/g_union.c
> @@ -358,6 +358,7 @@ fail2:
>   fail1:
>   	g_destroy_consumer(lowercp);
>   	g_destroy_provider(newpp);
> +	g_free(sc);
>   	g_destroy_geom(gp);
>   }

Hmm, as markj@ noted in the review, this also needs an `rw_destroy`.

-- 
John Baldwin